Skip to content

Fix regression in name resolution in parameter #38351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2020
Merged

Fix regression in name resolution in parameter #38351

merged 1 commit into from
May 6, 2020

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented May 5, 2020

This ensures we don't overwrite associatedDeclarationForContainingInitializerOrBindingName in resolveNameHelper so we can be sure we have the correct associated declaration.

Fixes #38243

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@RyanCavanaugh
Copy link
Member

@typescript-bot cherry-pick this to release-3.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 6, 2020

Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into release-3.9 on this PR at 39e6856. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @RyanCavanaugh, I've opened #38364 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 6, 2020

Verified

This commit was signed with the committer’s verified signature.
heitorlessa Heitor Lessa
Component commits:
39e6856 Fix regression in name resolution in parameter
@rbuckton rbuckton merged commit 4b08c05 into master May 6, 2020
@rbuckton rbuckton deleted the fix38243 branch May 7, 2020 20:23
DanielRosenwasser added a commit that referenced this pull request May 8, 2020
🤖 Pick PR #38351 (Fix regression in name resolution i...) into release-3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.9 regression: reference error setting default values in nested parameter destructuring
4 participants