Skip to content

fix(33286): Code folding fail for arrow function when param list has no parentheses #38631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2020
Merged

fix(33286): Code folding fail for arrow function when param list has no parentheses #38631

merged 2 commits into from
May 21, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #33286

@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label May 19, 2020
sandersn
sandersn requested changes May 19, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need another test (or we might already have it and I just don't know about it).

@sandersn sandersn self-assigned this May 19, 2020
@a-tarasyuk a-tarasyuk requested a review from sandersn May 21, 2020 13:29
sandersn
sandersn approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the GitHub app, hop his workscrrectly.

@sandersn sandersn merged commit c00aeb5 into microsoft:master May 21, 2020
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request May 26, 2020
@cangSDARM
Merge remote-tracking branch 'upstream/master'
470bcf6 
* upstream/master:
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Fix relation between generic mapped types and types with index signatures (microsoft#38761)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Revert "Wrap classes with decorators or static properties in an IIFE, even for ES2015+ (microsoft#32011)"
  Preserve module marker in es2015+ module emit for tool compatability (microsoft#38712)
  Fix recently added test so it is cross-plat
  fix(33286): add outlining for arrow function with one parameter (microsoft#38631)
  fix(38463): show completions for index access properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code folding fail for arrow function when param list has no parentheses
2 participants
@a-tarasyuk @sandersn