Fix handling of aruments in the emitter
#38880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
approved these changes
Jun 2, 2020
rbuckton
suggested changes
Jun 5, 2020
rbuckton
reviewed
Jun 11, 2020
Two problems are fixed: * `isArgumentsLocalBinding` did only `PropertyAccessExpression`, now it's also doing `PropertyAssignment` (doesn't affect other files, since it's only used in the emitter). * `visitShorthandPropertyAssignment` should call `visitIdentifier` on the synthesized id. (For completion it might be better to make it visit the the original?) Fixes microsoft#38594.
rbuckton
reviewed
Jun 11, 2020
I ran into it and the comment at the top tripped me, then I proceeded to simplify the code. Patched a bit more of the function to make sure that the indentation doesn't change, and added tests.
rbuckton
reviewed
Jun 12, 2020
| switch (_c.label) { | ||
| case 0: | ||
| _b = { | ||
| a: 1 |
There was a problem hiding this comment.
We still seem to have excess indentation. At this point it doesn't seem worth the extra time to keep digging into this. We can just remove the hasComputed check and possibly come back to it later.
rbuckton
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two problems are fixed:
isArgumentsLocalBindingdid onlyPropertyAccessExpression, now it's also doingPropertyAssignment(doesn't affect other files, since it's only used in the emitter).visitShorthandPropertyAssignmentshould callvisitIdentifieron the synthesized id. (For completion it might be better to make it visit the the original?)Fixes #38594.
Also, simplify
visitObjectLiteralExpression(I ran into it and the comment at the top tripped me, then I proceeded to simplify the code. Patched a bit more of the function to make sure that the indentation doesn't change, and added tests.) This is in a separate commit since it's only loosely related.