Split the GH actions CI into multiple stages #39210
Merged
+40
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
commented
Jun 23, 2020
orta
commented
Jun 23, 2020
orta
commented
Jun 23, 2020
| else { | ||
| args.push("--format", "autolinkable-stylish"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Stylish:
/Users/ortatherox/dev/typescript/typescript-compiler/src/compiler/builderState.ts
93:90 error Missing semicolon @typescript-eslint/semi
94:83 error Missing semicolon @typescript-eslint/semi
Autolinkable Stylish
Error: /Users/ortatherox/dev/typescript/typescript-compiler/src/compiler/builderState.ts:93:90 @typescript-eslint/semi Missing semicolon.
Error: /Users/ortatherox/dev/typescript/typescript-compiler/src/compiler/builderState.ts:94:83 @typescript-eslint/semi Missing semicolon.
Stylish support is shipped with setup-node here: https://github.com/actions/setup-node/blob/master/.github/eslint-stylish.json
There was a problem hiding this comment.
Looks like this in the files tab of the PR:
|
OK, I'm confident in this as an improvement 👍 |
andrewbranch
approved these changes
Jul 1, 2020
|
This seems to be breaking my build and maybe ignoring the config file? https://github.com/microsoft/TypeScript/pull/39119/checks?check_run_id=842427208#step:9:24 The config has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all of the CI is a single "install and run CI" - by splitting it into separate tasks, you can see at a glance what failed