Skip to content

fix: fix RelativeTimeFormat type definition #39661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2021
Merged

fix: fix RelativeTimeFormat type definition #39661

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d44809
fix: fix RelativeTimeFormat type definition
longlho Jul 19, 2020
7ccf482
address feedbacks
longlho Sep 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/lib/es2020.intl.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
declare namespace Intl {

/**
* [BCP 47 language tag](http://tools.ietf.org/html/rfc5646) definition.
* [Unicode BCP 47 Locale Identifiers](https://unicode.org/reports/tr35/#Unicode_Language_and_Locale_Identifiers) definition.
*
* [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#locales_argument).
*
* [Wikipedia](https://en.wikipedia.org/wiki/IETF_language_tag).
*/
type BCP47LanguageTag = string;
type UnicodeBCP47LocaleIdentifier = string;

/**
* Unit to use in the relative time internationalized message.
Expand Down Expand Up @@ -78,7 +77,7 @@ declare namespace Intl {
* [Specification](https://tc39.es/ecma402/#table-relativetimeformat-resolvedoptions-properties)
*/
interface ResolvedRelativeTimeFormatOptions {
locale: BCP47LanguageTag;
locale: UnicodeBCP47LocaleIdentifier;
style: RelativeTimeFormatStyle;
numeric: RelativeTimeFormatNumeric;
numberingSystem: string;
Expand Down Expand Up @@ -221,7 +220,7 @@ declare namespace Intl {
* [Specification](https://tc39.es/ecma402/#sec-intl-relativetimeformat-constructor).
*/
new(
locales?: BCP47LanguageTag | BCP47LanguageTag[],
locales?: UnicodeBCP47LocaleIdentifier | UnicodeBCP47LocaleIdentifier[],
options?: RelativeTimeFormatOptions,
): RelativeTimeFormat;

Expand Down Expand Up @@ -257,9 +256,9 @@ declare namespace Intl {
* [Specification](https://tc39.es/ecma402/#sec-Intl.RelativeTimeFormat.supportedLocalesOf).
*/
supportedLocalesOf(
locales: BCP47LanguageTag | BCP47LanguageTag[],
locales?: UnicodeBCP47LocaleIdentifier | UnicodeBCP47LocaleIdentifier[],
options?: RelativeTimeFormatOptions,
): BCP47LanguageTag[];
): UnicodeBCP47LocaleIdentifier[];
};

interface NumberFormatOptions {
Expand Down