Skip to content

fix export * as default syntax #39803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2020
Merged

fix export * as default syntax #39803

merged 2 commits into from
Aug 10, 2020

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jul 29, 2020 •
edited by rbuckton
Loading

Fixes #39769
Fixes #39803

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 29, 2020
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jul 29, 2020 •
edited
Loading

[[Do not merge before Friday]]

sandersn
sandersn requested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question.

The implementation looks reasonable to me, but @rbuckton should definitely sign off on the emitted code before this goes in.

rbuckton
rbuckton approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@rbuckton rbuckton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emit seems fine to me.

@Kingwl
Copy link
Contributor Author

Kingwl commented Jul 30, 2020

[[Do not merge before Friday]]

Maybe you need a label Don't merge now :XD

@DanielRosenwasser DanielRosenwasser merged commit a80f60c into microsoft:master Aug 10, 2020
@Kingwl Kingwl deleted the export_star_as_default branch August 19, 2020 03:02
@rbuckton rbuckton mentioned this pull request Dec 17, 2020
Closed
@johnnaegle johnnaegle mentioned this pull request Aug 9, 2022
Closed
@tomekzaw tomekzaw mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@sandersn sandersn sandersn requested changes

+1 more reviewer

@rbuckton rbuckton rbuckton approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sandersn sandersn

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

export * as default from "module" syntax should work as per ECMA-262
5 participants
@Kingwl @DanielRosenwasser @sandersn @rbuckton @typescript-bot