-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Revert to including only open files in partial semantic server mode #40026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot cherry-pick this to release-4.0 |
Heya @sheetalkamat, I've started to run the task to cherry-pick this into |
Hey @sheetalkamat, I've opened #40028 for you. |
Component commits: 8f442ba Revert to including only open files in partial semantic server mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the code in detail, but I'm totally on board with the concept.
@typescript-bot pack this |
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 8f442ba. You can monitor the build here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naively, looks good. I'll try this out locally tonight and merge the 4.0 PR if appropriate.
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running |
Looks good to me locally after some finagling. |
Component commits: 8f442ba Revert to including only open files in partial semantic server mode Co-authored-by: Sheetal Nandi <[email protected]>
No description provided.