feat(40197): No "did you mean to call" error when invocation is part of a logical expression #40260

a-tarasyuk · 2020-08-26T09:59:35Z

src/compiler/binder.ts

RyanCavanaugh · 2020-08-26T16:23:24Z

@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2020-08-26T16:23:27Z

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at ce4dcf3. You can monitor the build here.

typescript-bot · 2020-08-26T16:23:27Z

Heya @RyanCavanaugh, I've started to run the parallelized community code test suite on this PR at ce4dcf3. You can monitor the build here.

typescript-bot · 2020-08-26T16:39:30Z

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

RyanCavanaugh

RWC analysis

typeof window !== 'undefined' && window.console && (window.console.firebug || window.console.exception && window.console.table) || // Is firefox >= v31?

This is OK

var myUid = process.getuid && process.getuid()

This should be fixed; if the right operand refers to the function anywhere, it shouldn't be an error (same as for if)

src/compiler/checker.ts

tests/baselines/reference/truthinessCallExpressionCoercion2.errors.txt

DanielRosenwasser · 2020-08-28T17:48:08Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2020-08-28T17:48:11Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at b08d886. You can monitor the build here.

typescript-bot · 2020-08-28T17:48:11Z

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at b08d886. You can monitor the build here.

typescript-bot · 2020-08-28T17:48:11Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at b08d886. You can monitor the build here.

typescript-bot · 2020-08-28T17:48:12Z

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at b08d886. You can monitor the build here.

Update: The results are in!

typescript-bot · 2020-08-28T17:48:12Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at b08d886. You can monitor the build here.

typescript-bot · 2020-08-28T18:25:32Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..40260

_Metric	_master	₄₀₂₆₀	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{344,546k (± 0.02%)}	_{344,288k (± 0.03%)}	_{-258k (- 0.07%)}	_344,097k	_344,547k
_{Parse Time}	_{1.99s (± 0.49%)}	_{2.01s (± 0.57%)}	_{+0.02s (+ 0.90%)}	_1.99s	_2.03s
_{Bind Time}	_{0.82s (± 0.68%)}	_{0.82s (± 0.63%)}	_{-0.00s (- 0.36%)}	_0.81s	_0.83s
_{Check Time}	_{4.78s (± 0.66%)}	_{4.78s (± 0.46%)}	_{+0.00s (+ 0.04%)}	_4.73s	_4.84s
_{Emit Time}	_{5.17s (± 0.53%)}	_{5.17s (± 0.88%)}	_{+0.00s (+ 0.00%)}	_5.08s	_5.27s
_{Total Time}	_{12.77s (± 0.29%)}	_{12.79s (± 0.42%)}	_{+0.02s (+ 0.16%)}	_12.66s	_12.90s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{339,408k (± 0.03%)}	_{339,336k (± 0.03%)}	_{-72k (- 0.02%)}	_339,094k	_339,629k
_{Parse Time}	_{1.56s (± 0.49%)}	_{1.55s (± 0.48%)}	_{-0.00s (- 0.13%)}	_1.53s	_1.57s
_{Bind Time}	_{0.72s (± 0.51%)}	_{0.71s (± 0.66%)}	_{-0.01s (- 0.84%)}	_0.70s	_0.72s
_{Check Time}	_{4.97s (± 0.68%)}	_{4.95s (± 0.58%)}	_{-0.02s (- 0.44%)}	_4.91s	_5.05s
_{Emit Time}	_{2.75s (± 0.66%)}	_{2.73s (± 0.63%)}	_{-0.02s (- 0.87%)}	_2.69s	_2.78s
_{Total Time}	_{10.00s (± 0.50%)}	_{9.95s (± 0.36%)}	_{-0.06s (- 0.57%)}	_9.87s	_10.05s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{302,337k (± 0.04%)}	_{302,299k (± 0.02%)}	_{-38k (- 0.01%)}	_302,197k	_302,434k
_{Parse Time}	_{1.21s (± 0.72%)}	_{1.21s (± 0.64%)}	_{+0.00s (+ 0.25%)}	_1.20s	_1.23s
_{Bind Time}	_{0.67s (± 1.26%)}	_{0.67s (± 0.88%)}	_{+0.00s (+ 0.45%)}	_0.66s	_0.69s
_{Check Time}	_{4.47s (± 0.91%)}	_{4.46s (± 0.71%)}	_{-0.00s (- 0.09%)}	_4.42s	_4.57s
_{Emit Time}	_{2.92s (± 0.79%)}	_{2.89s (± 0.91%)}	_{-0.03s (- 1.20%)}	_2.82s	_2.93s
_{Total Time}	_{9.26s (± 0.71%)}	_{9.23s (± 0.46%)}	_{-0.03s (- 0.37%)}	_9.15s	_9.33s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{461,337k (± 0.01%)}	_{461,230k (± 0.01%)}	_{-107k (- 0.02%)}	_461,089k	_461,337k
_{Parse Time}	_{1.96s (± 0.51%)}	_{1.95s (± 0.57%)}	_{-0.01s (- 0.36%)}	_1.93s	_1.98s
_{Bind Time}	_{0.66s (± 1.14%)}	_{0.66s (± 1.16%)}	_{-0.01s (- 1.36%)}	_0.63s	_0.67s
_{Check Time}	_{13.52s (± 1.00%)}	_{13.49s (± 0.62%)}	_{-0.04s (- 0.28%)}	_13.28s	_13.72s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.15s (± 0.87%)}	_{16.10s (± 0.55%)}	_{-0.05s (- 0.31%)}	_15.90s	_16.34s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{321,687k (± 0.03%)}	_{321,555k (± 0.02%)}	_{-132k (- 0.04%)}	_321,463k	_321,704k
_{Parse Time}	_{1.99s (± 0.78%)}	_{1.99s (± 0.65%)}	_{-0.01s (- 0.30%)}	_1.96s	_2.01s
_{Bind Time}	_{0.81s (± 0.74%)}	_{0.81s (± 0.59%)}	_{+0.00s (+ 0.25%)}	_0.80s	_0.82s
_{Check Time}	_{4.67s (± 0.46%)}	_{4.69s (± 0.41%)}	_{+0.01s (+ 0.26%)}	_4.65s	_4.72s
_{Emit Time}	_{5.36s (± 1.08%)}	_{5.39s (± 1.17%)}	_{+0.02s (+ 0.43%)}	_5.30s	_5.60s
_{Total Time}	_{12.83s (± 0.37%)}	_{12.87s (± 0.63%)}	_{+0.03s (+ 0.24%)}	_12.72s	_13.12s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{321,619k (± 0.01%)}	_{321,641k (± 0.02%)}	_{+22k (+ 0.01%)}	_321,377k	_321,757k
_{Parse Time}	_{1.53s (± 0.80%)}	_{1.54s (± 0.75%)}	_{+0.01s (+ 0.72%)}	_1.52s	_1.56s
_{Bind Time}	_{0.69s (± 0.96%)}	_{0.69s (± 0.58%)}	_{-0.00s (- 0.29%)}	_0.68s	_0.70s
_{Check Time}	_{4.77s (± 0.31%)}	_{4.78s (± 0.53%)}	_{+0.01s (+ 0.27%)}	_4.72s	_4.84s
_{Emit Time}	_{2.82s (± 0.90%)}	_{2.81s (± 0.93%)}	_{-0.01s (- 0.46%)}	_2.76s	_2.89s
_{Total Time}	_{9.81s (± 0.31%)}	_{9.81s (± 0.51%)}	_{+0.01s (+ 0.06%)}	_9.75s	_9.97s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{286,688k (± 0.03%)}	_{286,585k (± 0.01%)}	_{-103k (- 0.04%)}	_286,503k	_286,694k
_{Parse Time}	_{1.23s (± 0.76%)}	_{1.23s (± 0.63%)}	_{-0.00s (- 0.16%)}	_1.21s	_1.25s
_{Bind Time}	_{0.64s (± 1.09%)}	_{0.64s (± 1.57%)}	_{+0.00s (+ 0.62%)}	_0.63s	_0.67s
_{Check Time}	_{4.36s (± 0.59%)}	_{4.36s (± 0.60%)}	_{+0.00s (+ 0.02%)}	_4.32s	_4.45s
_{Emit Time}	_{2.92s (± 0.71%)}	_{2.92s (± 0.59%)}	_{-0.00s (- 0.17%)}	_2.86s	_2.94s
_{Total Time}	_{9.15s (± 0.48%)}	_{9.15s (± 0.37%)}	_{-0.00s (- 0.01%)}	_9.10s	_9.26s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{439,707k (± 0.01%)}	_{439,555k (± 0.06%)}	_{-152k (- 0.03%)}	_438,489k	_439,782k
_{Parse Time}	_{1.98s (± 0.53%)}	_{1.97s (± 0.56%)}	_{-0.01s (- 0.25%)}	_1.94s	_1.99s
_{Bind Time}	_{0.63s (± 0.91%)}	_{0.62s (± 1.09%)}	_{-0.01s (- 0.95%)}	_0.61s	_0.64s
_{Check Time}	_{12.17s (± 1.26%)}	_{12.09s (± 0.96%)}	_{-0.07s (- 0.59%)}	_11.84s	_12.40s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.77s (± 1.06%)}	_{14.69s (± 0.81%)}	_{-0.08s (- 0.57%)}	_14.43s	_14.98s
_{Angular - node (v8.9.0, x64)}
_{Memory used}	_{341,102k (± 0.02%)}	_{340,929k (± 0.02%)}	_{-173k (- 0.05%)}	_340,804k	_341,099k
_{Parse Time}	_{2.54s (± 0.58%)}	_{2.53s (± 0.44%)}	_{-0.01s (- 0.39%)}	_2.51s	_2.56s
_{Bind Time}	_{0.85s (± 0.58%)}	_{0.85s (± 0.78%)}	_{+0.00s (+ 0.47%)}	_0.83s	_0.86s
_{Check Time}	_{5.40s (± 0.48%)}	_{5.42s (± 0.47%)}	_{+0.02s (+ 0.31%)}	_5.36s	_5.48s
_{Emit Time}	_{5.92s (± 0.49%)}	_{5.88s (± 1.16%)}	_{-0.05s (- 0.83%)}	_5.63s	_5.98s
_{Total Time}	_{14.72s (± 0.30%)}	_{14.68s (± 0.59%)}	_{-0.04s (- 0.28%)}	_14.39s	_14.81s
_{Monaco - node (v8.9.0, x64)}
_{Memory used}	_{340,627k (± 0.01%)}	_{340,590k (± 0.02%)}	_{-37k (- 0.01%)}	_340,416k	_340,664k
_{Parse Time}	_{1.87s (± 0.41%)}	_{1.87s (± 0.36%)}	_{+0.00s (+ 0.11%)}	_1.86s	_1.89s
_{Bind Time}	_{0.89s (± 0.56%)}	_{0.89s (± 0.58%)}	_{+0.00s (+ 0.34%)}	_0.88s	_0.90s
_{Check Time}	_{5.48s (± 0.53%)}	_{5.50s (± 0.38%)}	_{+0.02s (+ 0.36%)}	_5.46s	_5.54s
_{Emit Time}	_{3.21s (± 0.58%)}	_{3.24s (± 1.10%)}	_{+0.03s (+ 0.78%)}	_3.19s	_3.35s
_{Total Time}	_{11.45s (± 0.32%)}	_{11.51s (± 0.49%)}	_{+0.05s (+ 0.47%)}	_11.43s	_11.68s
_{TFS - node (v8.9.0, x64)}
_{Memory used}	_{303,971k (± 0.03%)}	_{303,938k (± 0.01%)}	_{-33k (- 0.01%)}	_303,834k	_304,063k
_{Parse Time}	_{1.55s (± 0.57%)}	_{1.55s (± 0.52%)}	_{-0.00s (- 0.13%)}	_1.53s	_1.57s
_{Bind Time}	_{0.68s (± 0.33%)}	_{0.67s (± 0.60%)}	_{-0.01s (- 1.18%)}	_0.66s	_0.68s
_{Check Time}	_{5.22s (± 0.68%)}	_{5.19s (± 0.55%)}	_{-0.03s (- 0.58%)}	_5.14s	_5.27s
_{Emit Time}	_{2.92s (± 0.94%)}	_{2.93s (± 0.66%)}	_{+0.01s (+ 0.38%)}	_2.89s	_2.98s
_{Total Time}	_{10.37s (± 0.42%)}	_{10.34s (± 0.38%)}	_{-0.03s (- 0.29%)}	_10.26s	_10.44s
_{material-ui - node (v8.9.0, x64)}
_{Memory used}	_{465,698k (± 0.01%)}	_{465,689k (± 0.01%)}	_{-10k (- 0.00%)}	_465,582k	_465,804k
_{Parse Time}	_{2.38s (± 0.47%)}	_{2.38s (± 0.71%)}	_{+0.00s (+ 0.13%)}	_2.35s	_2.42s
_{Bind Time}	_{0.78s (± 1.65%)}	_{0.78s (± 1.21%)}	_{+0.00s (+ 0.13%)}	_0.76s	_0.81s
_{Check Time}	_{17.87s (± 1.28%)}	_{17.94s (± 1.02%)}	_{+0.07s (+ 0.41%)}	_17.48s	_18.30s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{21.03s (± 1.08%)}	_{21.10s (± 0.84%)}	_{+0.07s (+ 0.35%)}	_20.63s	_21.43s
_{Angular - node (v8.9.0, x86)}
_{Memory used}	_{195,669k (± 0.02%)}	_{195,619k (± 0.02%)}	_{-51k (- 0.03%)}	_195,532k	_195,683k
_{Parse Time}	_{2.46s (± 0.72%)}	_{2.46s (± 0.63%)}	_{+0.01s (+ 0.29%)}	_2.43s	_2.48s
_{Bind Time}	_{0.99s (± 0.60%)}	_{0.98s (± 0.90%)}	_{-0.01s (- 0.61%)}	_0.95s	_0.99s
_{Check Time}	_{4.90s (± 0.44%)}	_{4.87s (± 0.58%)}	_{-0.03s (- 0.57%)}	_4.82s	_4.95s
_{Emit Time}	_{5.91s (± 0.73%)}	_{5.88s (± 1.24%)}	_{-0.03s (- 0.42%)}	_5.73s	_6.04s
_{Total Time}	_{14.24s (± 0.28%)}	_{14.19s (± 0.63%)}	_{-0.06s (- 0.40%)}	_14.00s	_14.44s
_{Monaco - node (v8.9.0, x86)}
_{Memory used}	_{193,655k (± 0.01%)}	_{193,665k (± 0.02%)}	_{+10k (+ 0.01%)}	_193,565k	_193,777k
_{Parse Time}	_{1.90s (± 0.53%)}	_{1.92s (± 1.36%)}	_{+0.02s (+ 0.94%)}	_1.87s	_1.97s
_{Bind Time}	_{0.70s (± 0.82%)}	_{0.71s (± 2.00%)}	_{+0.01s (+ 1.00%)}	_0.69s	_0.76s
_{Check Time}	_{5.60s (± 1.21%)}	_{5.58s (± 1.06%)}	_{-0.02s (- 0.32%)}	_5.37s	_5.67s
_{Emit Time}	_{2.71s (± 2.76%)}	_{2.70s (± 3.13%)}	_{-0.01s (- 0.41%)}	_2.64s	_3.04s
_{Total Time}	_{10.92s (± 0.47%)}	_{10.91s (± 0.57%)}	_{-0.01s (- 0.05%)}	_10.81s	_11.05s
_{TFS - node (v8.9.0, x86)}
_{Memory used}	_{173,889k (± 0.04%)}	_{173,871k (± 0.02%)}	_{-19k (- 0.01%)}	_173,791k	_173,919k
_{Parse Time}	_{1.59s (± 1.11%)}	_{1.59s (± 1.31%)}	_{-0.00s (- 0.13%)}	_1.56s	_1.65s
_{Bind Time}	_{0.65s (± 1.72%)}	_{0.65s (± 1.78%)}	_{+0.00s (+ 0.15%)}	_0.63s	_0.68s
_{Check Time}	_{4.73s (± 0.66%)}	_{4.75s (± 0.45%)}	_{+0.02s (+ 0.36%)}	_4.72s	_4.80s
_{Emit Time}	_{2.80s (± 1.40%)}	_{2.77s (± 0.86%)}	_{-0.03s (- 0.89%)}	_2.70s	_2.81s
_{Total Time}	_{9.76s (± 0.56%)}	_{9.75s (± 0.43%)}	_{-0.01s (- 0.11%)}	_9.66s	_9.86s
_{material-ui - node (v8.9.0, x86)}
_{Memory used}	_{263,677k (± 0.01%)}	_{263,658k (± 0.01%)}	_{-19k (- 0.01%)}	_263,608k	_263,744k
_{Parse Time}	_{2.44s (± 0.74%)}	_{2.42s (± 0.55%)}	_{-0.02s (- 0.70%)}	_2.40s	_2.45s
_{Bind Time}	_{0.68s (± 1.92%)}	_{0.67s (± 1.66%)}	_{-0.01s (- 1.77%)}	_0.65s	_0.70s
_{Check Time}	_{16.59s (± 0.56%)}	_{16.49s (± 0.62%)}	_{-0.11s (- 0.63%)}	_16.23s	_16.71s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{19.71s (± 0.50%)}	_{19.58s (± 0.52%)}	_{-0.13s (- 0.67%)}	_19.31s	_19.80s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-166-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v8.9.0, x64)
material-ui - node (v8.9.0, x86)

_Benchmark	_Name	_Iterations
_Current	₄₀₂₆₀	₁₀
_Baseline	_master	₁₀

DanielRosenwasser · 2020-09-08T17:56:49Z

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

typescript-bot · 2020-09-08T17:56:53Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at b08d886. You can monitor the build here.

typescript-bot · 2020-09-08T17:56:53Z

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at b08d886. You can monitor the build here.

typescript-bot · 2020-09-08T17:56:53Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at b08d886. You can monitor the build here.

sandersn

Can you also add a test with a nested || to show what happens there?

typeof window !== 'undefined' && window.console && (window.console.firebug || window.console.exception && window.console.table) || // Is firefox >= v31?

src/compiler/checker.ts

src/compiler/emitter.ts

src/compiler/checker.ts

sandersn

Can you try calling the uncalled functions in the emitter, since that was probably the original intent?

src/compiler/emitter.ts

sandersn · 2020-10-07T21:13:36Z

@DanielRosenwasser points out that this is a breaking change, so needs to wait until 4.2. I'll revert it for now and then merge once 4.1 has got its own branch.

…sions (#40260)" This reverts commit eaf4f46.

sandersn · 2020-10-07T21:22:09Z

OK, it's reverted. I'll revert the revert once release-4.1 is created and we are merging features into master again.

a-tarasyuk · 2020-10-08T06:37:52Z

@sandersn Do I need to re-open PR?

orta · 2020-10-08T22:56:52Z

~~Yes~~ No, I think Nathan is saying he'll handle it actually

sandersn · 2020-10-08T23:08:35Z

Right, I just made a TODO to revert the revert manually.

a-tarasyuk · 2020-10-09T06:22:36Z

@orta @sandersn Ok, thanks

…y expressions (#40260)"" This reverts commit cf3e28e.

…y expressions (#40260)"" (#41462) This reverts commit cf3e28e.

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 26, 2020

a-tarasyuk marked this pull request as draft August 26, 2020 10:20

a-tarasyuk marked this pull request as ready for review August 26, 2020 10:44

a-tarasyuk force-pushed the feat/40197 branch 2 times, most recently from 1899aa1 to ce4dcf3 Compare August 26, 2020 11:01

RyanCavanaugh reviewed Aug 26, 2020

View reviewed changes

src/compiler/binder.ts Show resolved Hide resolved

RyanCavanaugh reviewed Aug 26, 2020

View reviewed changes

src/compiler/binder.ts Show resolved Hide resolved

typescript-bot mentioned this pull request Aug 26, 2020

🤖 User test baselines have changed for feat/40197 typescript-bot/TypeScript#78

Open

RyanCavanaugh requested changes Aug 26, 2020

View reviewed changes

a-tarasyuk marked this pull request as draft August 26, 2020 16:48

a-tarasyuk force-pushed the feat/40197 branch from ce4dcf3 to 523e84c Compare August 26, 2020 19:46

a-tarasyuk marked this pull request as ready for review August 26, 2020 20:04

DanielRosenwasser reviewed Aug 27, 2020

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

a-tarasyuk force-pushed the feat/40197 branch 2 times, most recently from 70e03d8 to b08d886 Compare August 28, 2020 08:38

a-tarasyuk commented Aug 28, 2020

View reviewed changes

tests/baselines/reference/truthinessCallExpressionCoercion2.errors.txt Show resolved Hide resolved

sandersn added the Breaking Change Would introduce errors in existing code label Sep 8, 2020

sandersn requested changes Sep 8, 2020

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/emitter.ts Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

sandersn self-assigned this Sep 8, 2020

a-tarasyuk marked this pull request as draft September 8, 2020 18:41

feat(40197): handle uncalled function checks in binary expressions

cc1768c

a-tarasyuk force-pushed the feat/40197 branch from b08d886 to cc1768c Compare September 9, 2020 10:42

a-tarasyuk marked this pull request as ready for review September 28, 2020 12:45

sandersn requested changes Sep 30, 2020

View reviewed changes

src/compiler/emitter.ts Show resolved Hide resolved

sandersn approved these changes Oct 7, 2020

View reviewed changes

sandersn merged commit eaf4f46 into microsoft:master Oct 7, 2020

sandersn added a commit that referenced this pull request Oct 7, 2020

Revert "feat(40197): handle uncalled function checks in binary expres…

cf3e28e

…sions (#40260)" This reverts commit eaf4f46.

sandersn added a commit that referenced this pull request Nov 9, 2020

Revert "Revert "feat(40197): handle uncalled function checks in binar…

d40de9c

…y expressions (#40260)"" This reverts commit cf3e28e.

sandersn mentioned this pull request Nov 9, 2020

Revert "Revert "feat(40197): handle uncalled function checks in binar… #41462

Merged

sandersn added a commit that referenced this pull request Nov 9, 2020

Revert "Revert "feat(40197): handle uncalled function checks in binar…

64be2a8

…y expressions (#40260)"" (#41462) This reverts commit cf3e28e.

a-tarasyuk mentioned this pull request Nov 19, 2020

Uncalled-function error with function check in binary expression misses usage in body #41586

Closed

aweebit mentioned this pull request Jun 1, 2025

someBool || true gets the literal type true when assigned to a let variable at initialization (unlike true getting the type boolean) #61799

Closed

feat(40197): No "did you mean to call" error when invocation is part of a logical expression #40260

feat(40197): No "did you mean to call" error when invocation is part of a logical expression #40260

Uh oh!

Conversation

a-tarasyuk commented Aug 26, 2020

Uh oh!

Uh oh!

Uh oh!

RyanCavanaugh commented Aug 26, 2020

Uh oh!

typescript-bot commented Aug 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 26, 2020

Uh oh!

RyanCavanaugh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DanielRosenwasser commented Aug 28, 2020

Uh oh!

typescript-bot commented Aug 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 28, 2020

Uh oh!

DanielRosenwasser commented Sep 8, 2020

Uh oh!

typescript-bot commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sandersn commented Oct 7, 2020

Uh oh!

sandersn commented Oct 7, 2020

Uh oh!

a-tarasyuk commented Oct 8, 2020

Uh oh!

orta commented Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandersn commented Oct 8, 2020

Uh oh!

a-tarasyuk commented Oct 9, 2020

Uh oh!

Uh oh!

typescript-bot commented Aug 26, 2020 •

edited

Loading

typescript-bot commented Aug 26, 2020 •

edited

Loading

typescript-bot commented Aug 28, 2020 •

edited

Loading

typescript-bot commented Aug 28, 2020 •

edited

Loading

typescript-bot commented Aug 28, 2020 •

edited

Loading

typescript-bot commented Aug 28, 2020 •

edited

Loading

typescript-bot commented Aug 28, 2020 •

edited

Loading

typescript-bot commented Sep 8, 2020 •

edited

Loading

typescript-bot commented Sep 8, 2020 •

edited

Loading

typescript-bot commented Sep 8, 2020 •

edited

Loading

orta commented Oct 8, 2020 •

edited

Loading