Skip to content

Fix object.assign first param constraint #40909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2022

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Oct 2, 2020

Fixes #35621
Follow-up to #36768

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 2, 2020
@sandersn
Copy link
Member Author

sandersn commented Oct 2, 2020

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 2, 2020

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at f6f2baa. You can monitor the build here.

@sandersn
Copy link
Member Author

sandersn commented Oct 2, 2020

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 2, 2020

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at f6f2baa. You can monitor the build here.

@sandersn
Copy link
Member Author

sandersn commented Oct 2, 2020

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 2, 2020

Heya @sandersn, I've started to run the extended test suite on this PR at f6f2baa. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn
Copy link
Member Author

sandersn commented Oct 4, 2020

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 4, 2020

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at f6f2baa. You can monitor the build here.

@sandersn
Copy link
Member Author

sandersn commented Apr 6, 2021

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 6, 2021

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at b1350dd. You can monitor the build here.

@sandersn
Copy link
Member Author

sandersn commented Apr 6, 2021

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 6, 2021

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at b1350dd. You can monitor the build here.

@sandersn
Copy link
Member Author

sandersn commented Apr 6, 2021

DT is clean.

@sandersn
Copy link
Member Author

sandersn commented Apr 6, 2021

One more time:
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 6, 2021

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 2c3932c. You can monitor the build here.

@sandersn
Copy link
Member Author

sandersn commented Apr 7, 2021

User tests are clean.

@sandersn sandersn requested review from weswigham and orta April 7, 2021 00:10
@sandersn
Copy link
Member Author

sandersn commented Apr 7, 2021

I'm not going to put this into 4.3 since it's a lib change.

@sandersn sandersn merged commit 2477ff9 into main Feb 18, 2022
@sandersn sandersn deleted the fix-Object.assign-first-param-constraint branch February 18, 2022 21:30
@a-tarasyuk a-tarasyuk mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ObjectConstructor.assign
4 participants