Skip to content

fix(40929) PromiseConstructor error message for newer versions of ECMAScript #40931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Vboivin
Copy link
Contributor

@Vboivin Vboivin commented Oct 4, 2020

Fixes #40929

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 4, 2020
@Vboivin Vboivin changed the title Better PromiseConstructor error message for newer versions of ECMAScript Fix PromiseConstructor error message for newer versions of ECMAScript Oct 5, 2020
@Vboivin Vboivin changed the title Fix PromiseConstructor error message for newer versions of ECMAScript fix(40929) PromiseConstructor error message for newer versions of ECMAScript Oct 5, 2020
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks obviously correct, but can @DanielRosenwasser or @sandersn do a quick sanity check too?

@andrewbranch andrewbranch merged commit 5766160 into microsoft:master Oct 5, 2020
@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 5, 2020
@Vboivin Vboivin deleted the 40929-promiseconstructor-type branch October 7, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PromiseConstructor error message is not using the correct format for newer versions of ECMAScript
4 participants