Skip to content

[Perf test] Spread enum perf #41055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

[Perf test] Spread enum perf #41055

wants to merge 21 commits into from

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Oct 12, 2020

Fixes #

@Kingwl
Copy link
Contributor Author

Kingwl commented Oct 12, 2020

#40998

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 12, 2020
@Kingwl
Copy link
Contributor Author

Kingwl commented Oct 12, 2020

@typescript-bot perf test.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 12, 2020 •
edited
Loading

Heya @Kingwl, I've started to run the perf test suite on this PR at d06e6bc. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@Kingwl
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41055

Metric master 41055 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 349,757k (± 0.02%) 350,220k (± 0.02%) +463k (+ 0.13%) 350,077k 350,407k
Parse Time 2.01s (± 0.80%) 2.00s (± 0.83%) -0.00s (- 0.20%) 1.98s 2.04s
Bind Time 0.82s (± 1.07%) 0.82s (± 0.60%) +0.00s (+ 0.12%) 0.82s 0.84s
Check Time 4.94s (± 0.54%) 4.96s (± 0.66%) +0.02s (+ 0.38%) 4.89s 5.04s
Emit Time 5.19s (± 0.41%) 5.27s (± 0.75%) +0.08s (+ 1.52%) 5.18s 5.34s
Total Time 12.96s (± 0.34%) 13.05s (± 0.39%) +0.09s (+ 0.69%) 12.93s 13.17s
Monaco - node (v10.16.3, x64)
Memory used 354,351k (± 0.02%) 354,377k (± 0.02%) +26k (+ 0.01%) 354,185k 354,486k
Parse Time 1.57s (± 0.57%) 1.56s (± 0.54%) -0.01s (- 0.32%) 1.54s 1.58s
Bind Time 0.71s (± 0.56%) 0.71s (± 0.67%) +0.00s (+ 0.28%) 0.70s 0.72s
Check Time 5.07s (± 0.54%) 5.08s (± 0.29%) +0.01s (+ 0.16%) 5.04s 5.11s
Emit Time 2.76s (± 0.93%) 2.76s (± 0.64%) -0.01s (- 0.29%) 2.73s 2.80s
Total Time 10.11s (± 0.37%) 10.11s (± 0.20%) -0.01s (- 0.05%) 10.06s 10.14s
TFS - node (v10.16.3, x64)
Memory used 307,640k (± 0.04%) 307,676k (± 0.02%) +36k (+ 0.01%) 307,575k 307,805k
Parse Time 1.22s (± 0.76%) 1.22s (± 0.67%) -0.00s (- 0.41%) 1.20s 1.23s
Bind Time 0.66s (± 1.37%) 0.67s (± 0.51%) +0.01s (+ 1.82%) 0.67s 0.68s
Check Time 4.57s (± 0.94%) 4.57s (± 0.51%) +0.00s (+ 0.09%) 4.51s 4.63s
Emit Time 2.90s (± 1.72%) 2.91s (± 0.88%) +0.01s (+ 0.28%) 2.86s 2.98s
Total Time 9.35s (± 0.59%) 9.37s (± 0.37%) +0.02s (+ 0.21%) 9.30s 9.44s
material-ui - node (v10.16.3, x64)
Memory used 489,125k (± 0.02%) 489,108k (± 0.01%) -17k (- 0.00%) 488,975k 489,268k
Parse Time 1.99s (± 0.54%) 1.97s (± 0.44%) -0.02s (- 1.16%) 1.95s 1.99s
Bind Time 0.65s (± 0.90%) 0.65s (± 0.89%) +0.01s (+ 0.93%) 0.64s 0.66s
Check Time 13.42s (± 0.51%) 13.39s (± 0.59%) -0.03s (- 0.23%) 13.24s 13.61s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.06s (± 0.45%) 16.02s (± 0.53%) -0.05s (- 0.29%) 15.84s 16.25s
Angular - node (v12.1.0, x64)
Memory used 326,934k (± 0.02%) 327,464k (± 0.02%) +531k (+ 0.16%) 327,369k 327,618k
Parse Time 2.00s (± 0.53%) 1.99s (± 0.46%) -0.01s (- 0.45%) 1.97s 2.01s
Bind Time 0.81s (± 1.12%) 0.81s (± 0.59%) -0.00s (- 0.25%) 0.80s 0.82s
Check Time 4.83s (± 0.40%) 4.86s (± 0.71%) +0.03s (+ 0.56%) 4.79s 4.97s
Emit Time 5.39s (± 0.84%) 5.42s (± 0.73%) +0.02s (+ 0.44%) 5.35s 5.53s
Total Time 13.04s (± 0.52%) 13.08s (± 0.38%) +0.04s (+ 0.32%) 12.94s 13.18s
Monaco - node (v12.1.0, x64)
Memory used 336,578k (± 0.02%) 336,573k (± 0.01%) -4k (- 0.00%) 336,470k 336,651k
Parse Time 1.54s (± 0.72%) 1.53s (± 0.54%) -0.00s (- 0.13%) 1.51s 1.55s
Bind Time 0.69s (± 0.58%) 0.69s (± 0.49%) +0.00s (+ 0.58%) 0.69s 0.70s
Check Time 4.88s (± 0.50%) 4.90s (± 0.58%) +0.01s (+ 0.29%) 4.84s 4.96s
Emit Time 2.82s (± 0.91%) 2.82s (± 0.63%) -0.00s (- 0.04%) 2.79s 2.87s
Total Time 9.93s (± 0.39%) 9.95s (± 0.41%) +0.02s (+ 0.18%) 9.86s 10.02s
TFS - node (v12.1.0, x64)
Memory used 291,933k (± 0.03%) 291,922k (± 0.02%) -11k (- 0.00%) 291,711k 292,017k
Parse Time 1.23s (± 0.49%) 1.23s (± 0.57%) +0.01s (+ 0.49%) 1.22s 1.25s
Bind Time 0.65s (± 1.38%) 0.64s (± 1.29%) -0.00s (- 0.15%) 0.63s 0.67s
Check Time 4.47s (± 0.30%) 4.50s (± 0.41%) +0.03s (+ 0.67%) 4.46s 4.54s
Emit Time 2.92s (± 0.99%) 2.94s (± 0.74%) +0.02s (+ 0.75%) 2.90s 2.99s
Total Time 9.26s (± 0.36%) 9.31s (± 0.49%) +0.05s (+ 0.57%) 9.22s 9.40s
material-ui - node (v12.1.0, x64)
Memory used 467,034k (± 0.05%) 467,072k (± 0.06%) +38k (+ 0.01%) 465,940k 467,348k
Parse Time 2.01s (± 0.37%) 2.01s (± 0.31%) -0.00s (- 0.10%) 2.00s 2.03s
Bind Time 0.64s (± 1.05%) 0.64s (± 0.96%) +0.00s (+ 0.63%) 0.63s 0.65s
Check Time 12.05s (± 0.94%) 12.02s (± 0.82%) -0.03s (- 0.21%) 11.89s 12.31s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.70s (± 0.81%) 14.68s (± 0.70%) -0.02s (- 0.16%) 14.53s 14.97s
Angular - node (v8.9.0, x64)
Memory used 346,442k (± 0.01%) 346,981k (± 0.02%) +539k (+ 0.16%) 346,811k 347,112k
Parse Time 2.54s (± 0.51%) 2.56s (± 0.55%) +0.01s (+ 0.59%) 2.53s 2.60s
Bind Time 0.85s (± 0.43%) 0.87s (± 0.76%) +0.02s (+ 1.87%) 0.86s 0.89s
Check Time 5.56s (± 0.52%) 5.61s (± 0.79%) +0.05s (+ 0.90%) 5.53s 5.71s
Emit Time 6.15s (± 1.07%) 6.23s (± 1.18%) +0.08s (+ 1.32%) 6.13s 6.49s
Total Time 15.11s (± 0.55%) 15.27s (± 0.75%) +0.16s (+ 1.03%) 15.13s 15.68s
Monaco - node (v8.9.0, x64)
Memory used 355,704k (± 0.02%) 355,831k (± 0.01%) +126k (+ 0.04%) 355,724k 355,897k
Parse Time 1.89s (± 0.77%) 1.89s (± 0.40%) -0.00s (- 0.05%) 1.87s 1.90s
Bind Time 0.89s (± 0.45%) 0.89s (± 0.63%) -0.00s (- 0.34%) 0.88s 0.90s
Check Time 5.62s (± 0.37%) 5.65s (± 0.47%) +0.03s (+ 0.46%) 5.59s 5.70s
Emit Time 3.29s (± 1.17%) 3.26s (± 1.10%) -0.03s (- 0.85%) 3.20s 3.38s
Total Time 11.69s (± 0.28%) 11.68s (± 0.42%) -0.01s (- 0.06%) 11.56s 11.79s
TFS - node (v8.9.0, x64)
Memory used 309,391k (± 0.02%) 309,424k (± 0.01%) +33k (+ 0.01%) 309,328k 309,508k
Parse Time 1.55s (± 0.64%) 1.55s (± 0.34%) -0.00s (- 0.13%) 1.54s 1.56s
Bind Time 0.68s (± 0.73%) 0.67s (± 1.01%) -0.00s (- 0.30%) 0.66s 0.69s
Check Time 5.31s (± 0.58%) 5.31s (± 0.58%) +0.00s (+ 0.08%) 5.26s 5.38s
Emit Time 2.94s (± 0.34%) 2.94s (± 0.71%) +0.00s (+ 0.17%) 2.89s 2.99s
Total Time 10.48s (± 0.34%) 10.48s (± 0.39%) -0.00s (- 0.04%) 10.40s 10.57s
material-ui - node (v8.9.0, x64)
Memory used 493,431k (± 0.01%) 493,563k (± 0.01%) +132k (+ 0.03%) 493,441k 493,667k
Parse Time 2.40s (± 0.46%) 2.40s (± 0.50%) -0.01s (- 0.29%) 2.38s 2.43s
Bind Time 0.81s (± 1.02%) 0.82s (± 1.08%) +0.00s (+ 0.37%) 0.80s 0.84s
Check Time 17.95s (± 0.69%) 18.03s (± 0.41%) +0.07s (+ 0.41%) 17.82s 18.17s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.17s (± 0.56%) 21.24s (± 0.40%) +0.07s (+ 0.34%) 21.02s 21.41s
Angular - node (v8.9.0, x86)
Memory used 198,690k (± 0.01%) 199,021k (± 0.03%) +331k (+ 0.17%) 198,861k 199,145k
Parse Time 2.48s (± 1.02%) 2.47s (± 0.89%) -0.00s (- 0.08%) 2.44s 2.52s
Bind Time 1.00s (± 1.00%) 1.01s (± 1.31%) +0.00s (+ 0.50%) 0.98s 1.05s
Check Time 5.05s (± 0.56%) 5.05s (± 0.60%) -0.00s (- 0.04%) 4.96s 5.11s
Emit Time 5.89s (± 0.83%) 5.99s (± 0.80%) +0.10s (+ 1.68%) 5.87s 6.09s
Total Time 14.42s (± 0.58%) 14.51s (± 0.42%) +0.10s (+ 0.67%) 14.39s 14.64s
Monaco - node (v8.9.0, x86)
Memory used 201,493k (± 0.01%) 201,547k (± 0.01%) +54k (+ 0.03%) 201,463k 201,603k
Parse Time 1.94s (± 1.05%) 1.92s (± 0.77%) -0.02s (- 1.08%) 1.89s 1.96s
Bind Time 0.71s (± 0.47%) 0.70s (± 0.83%) -0.01s (- 0.99%) 0.69s 0.72s
Check Time 5.47s (± 0.38%) 5.50s (± 1.36%) +0.04s (+ 0.66%) 5.39s 5.70s
Emit Time 3.06s (± 0.59%) 3.01s (± 4.08%) -0.05s (- 1.54%) 2.67s 3.17s
Total Time 11.18s (± 0.25%) 11.14s (± 0.80%) -0.04s (- 0.37%) 10.92s 11.37s
TFS - node (v8.9.0, x86)
Memory used 176,867k (± 0.03%) 176,925k (± 0.03%) +57k (+ 0.03%) 176,790k 177,028k
Parse Time 1.60s (± 1.10%) 1.60s (± 1.17%) -0.00s (- 0.31%) 1.57s 1.66s
Bind Time 0.66s (± 2.04%) 0.64s (± 0.46%) -0.01s (- 1.98%) 0.64s 0.65s
Check Time 4.82s (± 0.58%) 4.83s (± 0.64%) +0.01s (+ 0.17%) 4.76s 4.88s
Emit Time 2.80s (± 0.66%) 2.83s (± 1.95%) +0.02s (+ 0.78%) 2.71s 3.01s
Total Time 9.88s (± 0.51%) 9.90s (± 0.62%) +0.02s (+ 0.15%) 9.81s 10.12s
material-ui - node (v8.9.0, x86)
Memory used 277,878k (± 0.02%) 277,895k (± 0.02%) +17k (+ 0.01%) 277,792k 277,977k
Parse Time 2.46s (± 0.43%) 2.48s (± 0.73%) +0.03s (+ 1.06%) 2.44s 2.53s
Bind Time 0.69s (± 1.35%) 0.71s (± 5.06%) +0.03s (+ 3.78%) 0.68s 0.84s
Check Time 16.45s (± 0.73%) 16.47s (± 0.49%) +0.02s (+ 0.11%) 16.34s 16.69s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 19.60s (± 0.63%) 19.67s (± 0.48%) +0.07s (+ 0.36%) 19.50s 19.94s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory3 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 41055 10
Baseline master 10

@Kingwl Kingwl closed this Oct 12, 2020
@Kingwl Kingwl deleted the spread_enum_perf branch October 12, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kingwl @typescript-bot