Switches the bundlePackageName error message to be a suggestion, and not a compiler error #41510
Conversation
…not a compiler error
typescript-bot
added
Author: Team
For Uncommitted Bug
| "The `bundledPackageName` option must be provided when using outFile and node module resolution with declaration emit.": { | ||
| "category": "Error", | ||
| "The `bundledPackageName` option should be provided when using outFile and node module resolution with declaration emit.": { | ||
| "category": "Suggestion", |
There was a problem hiding this comment.
this is currently not desirable i think... because we do not distinguish between suggestion or error and build will fail with corresponding exit code instead.
There was a problem hiding this comment.
Yeah that's fair, we do kinda have a separate suggestionDiagnostics list in the checker.
I don't think we have one in program yet, but we'd need to add one and concatenate it with the checker's suggestions. (Inside getSuggestionDiagnostics in program.ts)
There was a problem hiding this comment.
but that means it would reported only in editor ... and not in build i am not sure thats desirable either... program construction messages should be consistent in my opinion..
There was a problem hiding this comment.
I mean, suggestions are only actionable in the editor at present, no? We don't have a --showSuggestions compiler flag or anything to print them on the command line at present?
There was a problem hiding this comment.
currently suggestions are errors under noUnusedLocals like flags as far as i know so there is way to get those.
There was a problem hiding this comment.
Diagnostics.await_has_no_effect_on_the_type_of_this_expression is unconditionally a suggestion (see its usage in checkAwaitExpression), as is Diagnostics.Numeric_literals_with_absolute_values_equal_to_2_53_or_greater_are_too_large_to_be_represented_accurately_as_integers in checkNumericLiteralValueSize, so we do already have suggestions you can never see on the command line by conversion into an error.
There was a problem hiding this comment.
(And these still have value because we use them to trigger quickfixes!)
|
Unfortunately, we never finished reviewing this PR. It is pretty old now, so I'm going to close it to reduce the number of open PRs. |
Alternative to #41499 where the compiler flag instead recommends using
bundlePackageNameon theoutin your JSON instead of outright removing the feature.