Skip to content

JSDoc declaration emit should reuse input nodes where possible when serializing typedefs #41760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2020
Merged

JSDoc declaration emit should reuse input nodes where possible when serializing typedefs #41760

merged 2 commits into from
Dec 4, 2020

Conversation

weswigham
Copy link
Member

Fixes part of #41672

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 1, 2020
@weswigham weswigham mentioned this pull request Dec 1, 2020
Open
sandersn
sandersn requested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how you knew about the autofill-type-argument case, and didn't see a test for it. How did you know it was needed?

sandersn
sandersn approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once that super-long line is broken up.

@weswigham weswigham merged commit 360958e into microsoft:master Dec 4, 2020
@weswigham weswigham deleted the jsdoc-decls-typedef-preserves-nodes branch December 4, 2020 21:42
scalder27 pushed a commit to scalder27/TypeScript that referenced this pull request Dec 7, 2020
@weswigham @scalder27
JSDoc declaration emit should reuse input nodes where possible when s…
2f6fb09 
…erializing typedefs (microsoft#41760)

* JSDoc declaration emit should reuse input nodes where possible when serializing typedefs

* Style comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@weswigham weswigham

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weswigham @sandersn @typescript-bot