Skip to content

fix(35050): Decorator emit incorrect within try block #41951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2021
Merged

fix(35050): Decorator emit incorrect within try block #41951

merged 3 commits into from
Jul 8, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #35050

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Dec 14, 2020
@rbuckton
Copy link
Contributor

rbuckton commented Jul 8, 2021

Class declarations are block scoped variables, so this could possibly introduce a collision if there is a let declaration in an outer scope. I may amend this PR slightly to only use getInternalName when we know this is being moved to an IIFE for ES5/3.

@a-tarasyuk
Copy link
Contributor Author

@rbuckton Thanks for the help.

@rbuckton rbuckton merged commit a15030f into microsoft:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rbuckton rbuckton rbuckton approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rbuckton rbuckton

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decorator emit incorrect within try block
3 participants
@a-tarasyuk @rbuckton @typescript-bot