-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Fix completions of exports elsewhere in same file #43755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sandersn I realized I couldn’t really fix the primary bug (#43289) without addressing the contextual typing thing head-on, which I think I’ve done now. |
@typescript-bot user test this |
Heya @andrewbranch, I've started to run the parallelized community code test suite on this PR at 61521db. You can monitor the build here. |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
case AssignmentDeclarationKind.ModuleExports: | ||
case AssignmentDeclarationKind.ThisProperty: | ||
return getContextualTypeForThisPropertyAssignment(binaryExpression, kind); | ||
valueDeclaration ||= binaryExpression.symbol?.valueDeclaration; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch
scope rules are boooooooooo
Fixes #43289, along with another bug I found on the way:
and