Skip to content

Revert "typeRelatedToSomeType passes through intersectionState (#43707)" #43983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented May 6, 2021

This reverts commit db09cb5.

As discussed in #43884 (comment):

  • typeRelatedToSomeType passes through intersectionState #43707 breaks mongodb and mongoose types.
  • a complex tweak to the whole-object post-check might be able enable common property checks without enabling excess property checks.
  • a complex tweak to that over-complex code is not a good idea for a niche case.

Even if it were worth it, there's not enough time before 4.3's release to test a complex tweak.

Re-opens #42715

@sandersn sandersn requested a review from weswigham May 6, 2021 17:59
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 6, 2021
@sandersn sandersn merged commit 71f338b into master May 6, 2021
@sandersn sandersn deleted the revert-43707-intersection-state branch May 6, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants