Skip to content

Update the type reference cache with correct project options #44004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

Update the type reference cache with correct project options #44004

merged 1 commit into from
May 7, 2021

Conversation

sheetalkamat
Copy link
Member

No description provided.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 7, 2021
amcasey
amcasey approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this code, but it looks consistent with the other cache.

@sheetalkamat
Copy link
Member Author

And i will add test as a separate PR so that we are not blocked on this for 4.3.1

@sheetalkamat sheetalkamat merged commit e61d812 into master May 7, 2021
@sheetalkamat sheetalkamat deleted the missingUpdate branch May 7, 2021 23:58
sheetalkamat added a commit that referenced this pull request May 8, 2021
@sheetalkamat
Update showing fix in #44004 works
5c1ae7a
@sheetalkamat sheetalkamat mentioned this pull request May 8, 2021
Merged
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 10, 2021
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#44008 into release-4.3
1b986e3 
Component commits:
8da9ed0 Test without change

5c1ae7a Update showing fix in microsoft#44004 works
sheetalkamat added a commit that referenced this pull request May 10, 2021
@sheetalkamat
Test for Update the type reference cache with correct project options (…
182b6c9 
…#44008)

* Test without change

* Update showing fix in #44004 works
sheetalkamat added a commit that referenced this pull request May 10, 2021
@sheetalkamat
Cherry-pick PR #44008 into release-4.3 (#44029)
1d850c0 
Component commits:
8da9ed0 Test without change

5c1ae7a Update showing fix in #44004 works

Co-authored-by: Sheetal Nandi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@amcasey amcasey amcasey approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sheetalkamat @DanielRosenwasser @amcasey @typescript-bot