Expose types for MediaRecorder API #44397
Conversation
|
It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'. |
|
It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TSJS-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed. |
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
|
|
This PR adds type support for the MediaRecorder API available in all major browsers.
This API is a part of the MediaStream Recorder API. The interfaces for the Media Capture API (MediaStream, etc) are supported by TypeScript already.
There was a request some time ago to add these types but it was closed as unactionable: #34728
The spec for this API can be found here: https://w3c.github.io/mediacapture-record/
MDN Docs for it are here: https://developer.mozilla.org/en-US/docs/Web/API/MediaStream_Recording_API
It would be great to be able to use the types for this API without having to bring in an external dependency.
There is no Backlog issue for this request. I wanted to re-open the discussion around this while also providing the code for it to be fixed.
As a side note, it was kind of difficult to add these in such that they would fit into the rest of the
lib.dom.d.tsfile. At first glance, it seems to be ordered alphabetically, but that isn't actually the case. There's some kind of grouping applied to the interfaces, but it isn't clear to me what the intention is. Example: all of the *Options and *EventInit interfaces are grouped together alphabetically. Also, it's not clear to me why use a combination ofinterfacewithdeclare varto specify the constructor arguments instead of usingdeclare class. I'm new to using TS though, so I might just be missing something obvious.