Skip to content

feat(44736): Go-to-def on override should navigate to the overridden method #44740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2021
Merged

feat(44736): Go-to-def on override should navigate to the overridden method #44740

merged 1 commit into from
Jun 28, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #44736

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jun 25, 2021
@a-tarasyuk a-tarasyuk force-pushed the feat/44736 branch 4 times, most recently from e05b1c1 to a0c2637 Compare June 25, 2021 20:38
uniqueiniquity
uniqueiniquity approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@uniqueiniquity uniqueiniquity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great from an intended behavior perspective!
I'll let someone who knows more about the implementation sign off before merging.

@a-tarasyuk a-tarasyuk requested a review from Kingwl June 28, 2021 08:07
@a-tarasyuk a-tarasyuk requested a review from Kingwl June 28, 2021 09:23
@DanielRosenwasser DanielRosenwasser merged commit 066796b into microsoft:main Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@uniqueiniquity uniqueiniquity uniqueiniquity approved these changes

@Kingwl Kingwl Awaiting requested review from Kingwl

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go-to-def on override should navigate to the overridden method
6 participants
@a-tarasyuk @andrewbranch @Kingwl @uniqueiniquity @DanielRosenwasser @typescript-bot