Narrow falsy strings to '' and falsy numbers to 0 #45836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
@typescript-bot test this |
|
Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at 86e00f6. You can monitor the build here. |
|
Heya @andrewbranch, I've started to run the inline community code test suite on this PR at 86e00f6. You can monitor the build here. Update: The results are in! |
|
Heya @andrewbranch, I've started to run the extended test suite on this PR at 86e00f6. You can monitor the build here. |
|
Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 86e00f6. You can monitor the build here. |
|
Heya @andrewbranch, I've started to run the perf test suite on this PR at 86e00f6. You can monitor the build here. Update: The results are in! |
|
@andrewbranch |
|
Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@andrewbranch Here they are:Comparison Report - main..45836
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
The TypeScript team hasn't accepted the linked issue #45329. If you can get it accepted, this PR will have a better chance of being reviewed. |
JoshuaKGoldberg
changed the title
weswigham
reviewed
Mar 5, 2022
There was a problem hiding this comment.
Code-wise this looks mostly fine to me, but @ahejlsberg and @RyanCavanaugh seemed to want to investigate the change more in the original issue and have yet to chime in? The last test results at least seem fine.
| else if (type.flags & TypeFlags.Boolean) { | ||
| return falseType; | ||
| } | ||
| else if (type.flags & TypeFlags.String) { |
There was a problem hiding this comment.
There probably needs to be a TemplateString and StringMapping case now, too, since both type kinds could possibly contain the empty string.
|
👍 I'll switch to draft pending #45329 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
filterTypefunction used bygetTypeWithFacts<-narrowTypeByTruthinessworks as a filter: taking in an existing set of types and returning the ones that are allowed. This PR sets up afilterAndNarrowTypefunction that can also transform the types given to it into more narrow equivalents.truthyTypeFilteris then used bynarrowTypeByTruthinessto turns primitives into their falsy literals (e.g.number->0) when falsy.Sending as a draft as requested so we can try this out on real world code.Opening as a full PR since it's been a bit and none of the typescript-bot commands have shown any major red flags.Fixes #45329