Skip to content

fix(45802): keep children of mismatched jsx element #45839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

hi-ogawa
Copy link
Contributor

Fixes #45802

This PR attempts to fix small regression of the PR #43780. I have to say I still don't see the whole picture of jsx parsing routines, so my fix might not be to the point.
If maintainers have other solutions in mind, please feel free to close my PR.

I added a few tests to verify that the crash is now fixed. There are also baseline changes which shows how mismatched jsx parsing differs after this fix.

Thanks for the code review!

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Sep 12, 2021
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice fix. The comments just need a couple of updates too.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Nathan Shively-Sanders <[email protected]>
@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Sep 17, 2021

Thanks for the review! I updated comments with your suggestion. I just tried Github's commit suggestion button, so git log looks a bit funny but I hope you don't mind.

@hi-ogawa hi-ogawa requested a review from sandersn September 17, 2021 13:33
@sandersn sandersn merged commit 5ef0439 into microsoft:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No auto-closing div tag when nested in li and another div
3 participants