Skip to content

fix(45919): TS2775 when using arrow function for type predicate #45952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2021
Merged

fix(45919): TS2775 when using arrow function for type predicate #45952

merged 1 commit into from
Sep 30, 2021

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #45919

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Sep 18, 2021
sandersn
sandersn requested changes Sep 29, 2021
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I think it can be slightly more general.

sandersn
sandersn approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further changes are needed, and I don't think a test for the excluded JS form is either -- it's very unlikely for somebody to write that form.

@sandersn sandersn merged commit d613748 into microsoft:main Sep 30, 2021
@ssalbdivad ssalbdivad mentioned this pull request Oct 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS2775 when using arrow function for type predicate
3 participants
@a-tarasyuk @sandersn @typescript-bot