Skip to content

In plain JS files, only suggest did-you-mean errors #46151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

sandersn
Copy link
Member

They will have code fixes, and are tuned for high precision. Others are not.

Fixes #46103

They will have code fixes, and are tuned for high precision. Others are
not.
@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 30, 2021
@@ -28412,7 +28412,7 @@ namespace ts {
if (relatedInfo) {
addRelatedInfo(resultDiagnostic, relatedInfo);
}
addErrorOrSuggestion(!isUncheckedJS, resultDiagnostic);
addErrorOrSuggestion(!isUncheckedJS || errorInfo.code !== Diagnostics.Property_0_may_not_exist_on_type_1_Did_you_mean_2.code, resultDiagnostic);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to check if I understand things correctly: considering the unchecked JS scenario, we are now making any diagnostics that are not "did you mean..." become errors instead of suggestions. I'm also assuming errors don't show up intrusively in unchecked JS, whereas suggestions are going to appear as the three grey dots. Is that it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a related question is: how are errors in unchecked JS surfaced?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's completely non-obvious, but checker errors in JS are squelched entirely. Only suggestions are shown.

That needs to change eventually, at which point this code might need to change. But probably we'll still have an explicit allow-list of errors.

Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few questions for my own understanding, but I think this looks good

@sandersn sandersn changed the title In plain JS files, only suggestion did-you-mean errors In plain JS files, only suggest did-you-mean errors Oct 7, 2021
@sandersn sandersn merged commit 8c27075 into main Oct 7, 2021
@sandersn sandersn deleted the only-did-you-mean-in-plain-js branch October 7, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS2339 refactoring warnings (three gray dots) appearing under javascript properties
3 participants