In plain JS files, only suggest did-you-mean errors #46151
Conversation
They will have code fixes, and are tuned for high precision. Others are not.
typescript-bot
added
Author: Team
For Milestone Bug
| @@ -28412,7 +28412,7 @@ namespace ts { | |||
| if (relatedInfo) { | |||
| addRelatedInfo(resultDiagnostic, relatedInfo); | |||
| } | |||
| addErrorOrSuggestion(!isUncheckedJS, resultDiagnostic); | |||
| addErrorOrSuggestion(!isUncheckedJS || errorInfo.code !== Diagnostics.Property_0_may_not_exist_on_type_1_Did_you_mean_2.code, resultDiagnostic); | |||
There was a problem hiding this comment.
to check if I understand things correctly: considering the unchecked JS scenario, we are now making any diagnostics that are not "did you mean..." become errors instead of suggestions. I'm also assuming errors don't show up intrusively in unchecked JS, whereas suggestions are going to appear as the three grey dots. Is that it?
There was a problem hiding this comment.
I guess a related question is: how are errors in unchecked JS surfaced?
There was a problem hiding this comment.
It's completely non-obvious, but checker errors in JS are squelched entirely. Only suggestions are shown.
That needs to change eventually, at which point this code might need to change. But probably we'll still have an explicit allow-list of errors.
sandersn
changed the title
They will have code fixes, and are tuned for high precision. Others are not.
Fixes #46103