Skip to content

Add function names for code fixes. #46728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 27, 2021
Merged

Add function names for code fixes. #46728

merged 4 commits into from
Nov 27, 2021

Conversation

DanielRosenwasser
Copy link
Member

This PR gives code actions a name so we can tell which code fix is causing issues from a glance at a stack trace in telemetry issues.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 8, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@amcasey
Copy link
Member

amcasey commented Nov 10, 2021

I can't say for certain that the stack frame reconstructor will actually pick up these names, but it seems plausible. @armanio123 can probably show you how to test it locally.

amcasey
amcasey approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, but tooling changes might be required (or, less likely, might be impossible).

@DanielRosenwasser DanielRosenwasser mentioned this pull request Nov 15, 2021
Merged
@orta
Copy link
Contributor

orta commented Nov 16, 2021

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 16, 2021 •
edited
Loading

Heya @orta, I've started to run the tarball bundle task on this PR at c9f6b07. You can monitor the build here.

@DanielRosenwasser
Copy link
Member Author

@orta any reason you wanted to pack this?

@orta
Copy link
Contributor

orta commented Nov 17, 2021 •
edited
Loading

I was just testing the pack command, and thought it would be s safe candidate

@DanielRosenwasser
Copy link
Member Author

Would it make sense to cherry-pick this in for 4.5.3? Otherwise we won't start seeing these until March or so.

@DanielRosenwasser
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 27, 2021 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.5 on this PR at e019272. You can monitor the build here.

@DanielRosenwasser DanielRosenwasser merged commit 2e70675 into main Nov 27, 2021
@DanielRosenwasser DanielRosenwasser deleted the codeFixesHaveFunctionNames branch November 27, 2021 20:15
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.5 manually.

mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
@DanielRosenwasser @mprobst
Add function names for code fixes. (microsoft#46728)
4b02617 
* Add function names for code fixes.

* Remove double space.

* Undo CRLF -> LF change.
This was referenced Jan 11, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@amcasey amcasey amcasey approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DanielRosenwasser @typescript-bot @amcasey @orta @RyanCavanaugh