Skip to content

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Nov 8, 2021

bigint is needed to represent all 64-bit ints that these arrays could contain.

Breaks jsdom and jsreport-core on DT, and any package that depends on es2022 and @types/node

bigint is needed to represent all 64-bit ints that these arrays could
contain.
@sandersn sandersn requested review from orta and weswigham November 8, 2021 17:14
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 8, 2021
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍🏻

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types are in fact just wrong, function returns a bigint at runtime.

@sandersn sandersn merged commit 9713cc1 into main Nov 8, 2021
@sandersn sandersn deleted the fix-BigIntArray-at-types branch November 8, 2021 17:50
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
bigint is needed to represent all 64-bit ints that these arrays could
contain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants