Add generic type parameter to startsWith/endsWith #46959
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This wouldn't handle cases where a |
|
@xiBread you are very right, don't know how I missed that 😅 Will push a commit addressing this asap |
LinusU
force-pushed
the
starts-ends-with
branch
from
8225d4c to
515d00d
Compare
|
Amended the commit to account for the Here are some preliminary tests in a playground: link Would still like to add these as proper tests as soon as I know where to put them! |
LinusU
force-pushed
the
starts-ends-with
branch
from
515d00d to
edec1eb
Compare
LinusU
force-pushed
the
starts-ends-with
branch
from
edec1eb to
2ff5d37
Compare
|
I've added tests, but they might be in the wrong place 😅 |
LinusU
force-pushed
the
starts-ends-with
branch
from
2ff5d37 to
830581a
Compare
LinusU
force-pushed
the
starts-ends-with
branch
from
830581a to
3ae38fa
Compare
|
Closing per discussion in #46958 |
|
The TypeScript team hasn't accepted the linked issue #46958. If you can get it accepted, this PR will have a better chance of being reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46958
Sorry for being a bit quick to open this PR, I started by editing the code and then later found out about the proper process. I figured it would be good to open this one anyways a suggestion on how to fix the issue I opened.
I also had a hard time figuring out where to add tests for this. It's not under "Contributing lib.d.ts fixes" and "Adding a Test" seems to be for compiler tests cases. Any help appreciated!