Skip to content

Standardized aka.ms links for tsc and tsconfig #47129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

JoshuaKGoldberg
Copy link
Contributor

Fixes #46919

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Dec 13, 2021
Copy link
Member

@gabritto gabritto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the baseline errors in runWithoutArgs tsc unittests (https://github.com/microsoft/TypeScript/runs/4542578661?check_suite_focus=true). Could you re-run those and regenerate baselines?

@JoshuaKGoldberg
Copy link
Contributor Author

@gabritto please forgive me, I went back (again) on aka.ms/tsconfig vs aka.ms/tsconfig.json ... The extra .json in there just seemed unnecessary. I can change it back to aka.ms/tsconfig.json if you'd prefer (but personally like aka.ms/tsconfig just a bit more). 😅

@gabritto gabritto merged commit 9220498 into microsoft:main Feb 18, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the aka-ms-tsc-tsconfig branch February 18, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use a specific aka.ms/tsc link in tsc --help for tsc CLI options
4 participants