Fix implicit glob detection when ancestor directory contains .
#47418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
lgarron
reviewed
Jan 13, 2022
Comment on lines
+415
to
+423
|
|
||
| it("parses wildcard directories even when parent directories have dots", () => { | ||
| const parsed = parseConfigFileTextToJson("/foo.bar/tsconfig.json", JSON.stringify({ | ||
| include: ["src"] | ||
| })); | ||
|
|
||
| const parsedCommand = parseJsonConfigFileContent(parsed.config, sys, "/foo.bar"); | ||
| assert.deepEqual(parsedCommand.wildcardDirectories, { "/foo.bar/src": WatchDirectoryFlags.Recursive }); | ||
| }); |
There was a problem hiding this comment.
Would it be worth adding a test for /repo/src/example.com as well? (Dot in the include path, but not in the repo path.)
There was a problem hiding this comment.
A dot in the last component of the include path is still going to cause a problem—I’m not sure we’ve settled on what the expected behavior for that is.
RyanCavanaugh
approved these changes
Jan 13, 2022
|
Thanks for the fix! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45721
Big thanks to @lgarron 🌟