Skip to content

fix(47391): JSDoc/TSDoc @link with custom display text incorrectly shows vertical bar #47575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix(47391): JSDoc/TSDoc @link with custom display text incorrectly shows vertical bar #47575

merged 1 commit into from
Feb 17, 2022

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #47391

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 24, 2022
sandersn
sandersn requested changes Feb 7, 2022
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this should be fixed by omitting the | on the display side in services/jsDoc.ts and its callees. I want the parser to capture the whole of the comment text.

@a-tarasyuk
Copy link
Contributor Author

@sandersn Oke

@a-tarasyuk a-tarasyuk requested a review from sandersn February 7, 2022 18:22
sandersn
sandersn requested changes Feb 7, 2022
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd like a couple more test cases.

@a-tarasyuk a-tarasyuk requested a review from sandersn February 7, 2022 19:33
@a-tarasyuk a-tarasyuk requested a review from sandersn February 16, 2022 10:18
@sandersn sandersn merged commit 1c06ef3 into microsoft:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSDoc/TSDoc @link with custom display text incorrectly shows vertical bar
3 participants
@a-tarasyuk @sandersn @typescript-bot