Avoid pulling on setter type when only getter type is needed to break circularity #47818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44906
In the process of instantiating
SerializablePartial<User>
on the setter type, we need to pull the reading type forUser["bestFriend"]
. However, the function that gets the read type for a get accessor prematurely resolved the type of the set accessor, which created a circularity. That circularity is easily broken in this case, since we were only interested in the getter type.