Flag resolution mode assertions in non-nightly builds #49002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
| ); | ||
| } | ||
| // Nothing visible | ||
| } | ||
|
|
||
| function getResolutionModeOverrideForClauseInNightly(assertClause: AssertClause | undefined) { |
There was a problem hiding this comment.
Should this be getting called in the checker? Seems like you'll only get an error in .d.ts generation scenarios
|
Ideally the span would be on the |
DanielRosenwasser
approved these changes
May 6, 2022
|
Looks like this didn't cover |
|
Opened #49354 as a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per offline discussion.
See RyanCavanaugh@898be45 for what happens in non-nightly builds