-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Allow referencing type-only exports as namespace members in ImportTypes and TypeQueries #49056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…es and TypeQueries
}; | ||
//// [button.d.ts] | ||
export declare const c: { | ||
directive: typeof import("./lit.js").ClassMapDirective; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what declaration emit has always done, but was an error until now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. I'm surprised it was that that easy to plumb through.
@@ -28997,7 +28999,7 @@ namespace ts { | |||
} | |||
return isErrorType(apparentType) ? errorType : apparentType;; | |||
} | |||
prop = getPropertyOfType(apparentType, right.escapedText); | |||
prop = getPropertyOfType(apparentType, right.escapedText, /*skipObjectFunctionPropertyAugment*/ false, /*includeTypeOnlyMembers*/ node.kind === SyntaxKind.QualifiedName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: is there a reason why here you used /*skipObjectFunctionPropertyAugment*/ false
but above you use undefined
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to see if you were paying attention
@@ -28997,7 +28999,7 @@ namespace ts { | |||
} | |||
return isErrorType(apparentType) ? errorType : apparentType;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;;
:(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent a quick fix for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t recall seeing this or touching this line. Weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it’s because you did
Fixes #45946