Skip to content

Key validity of import=require in module: node off of module and not target #49222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2022
Merged

Key validity of import=require in module: node off of module and not target #49222

merged 1 commit into from
May 24, 2022

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented May 23, 2022 •
edited
Loading

Since import.meta itself is keyed off module and not target (and thus should always be allowed in esm files in node module targets).

Fixes #48876

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 23, 2022
@weswigham weswigham merged commit 194a2ae into microsoft:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@weswigham weswigham

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import=require emits incorrectly with NodeNext, target<=es2018, when emitting as ESM
3 participants
@weswigham @sandersn @typescript-bot