Fix the implicit glob key so that recursive keys are not differing just directory separator for wildcard directory #49246
+432
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
requested review from
andrewbranch and
weswigham
and removed request for
andrewbranch
weswigham
approved these changes
May 25, 2022
|
@RyanCavanaugh @andrewbranch do we feel alright picking this into 4.7? I'll kick off a cherry-pick in the meantime. @typescript-bot cherry-pick this to release-4.7 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I've opened #49250 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 25, 2022
Component commits: b846905 Add failing test 66d51e5 Fix the implicit glob key so that recursive keys are not differing just by directory seperator Fixes microsoft#49078 f93951f Reset the reload level once program is loaded
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jun 1, 2022
Component commits: b846905 Add failing test 66d51e5 Fix the implicit glob key so that recursive keys are not differing just by directory seperator Fixes #49078 f93951f Reset the reload level once program is loaded Co-authored-by: Sheetal Nandi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49078