Use bidirectional comparability in narrowing

[andrewbranch]

Fixes #50527

[andrewbranch]

@typescript-bot pack this
@typescript-bot perf test this faster

[typescript-bot]

Heya @andrewbranch, I've started to run the abridged perf test suite on this PR at 46ce0b2. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 46ce0b2. You can monitor the build here.

[andrewbranch]

@ahejlsberg I think there must be other possible fixes since this isn’t directly related to #49119 which caused the regression, but this is for one of the bugs you were going to look at today

[typescript-bot]

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50592

Metric	main	50592	Delta	Best	Worst
Angular - node (v14.15.1, x64)
Memory used	338,714k (± 0.00%)	338,736k (± 0.01%)	+22k (+ 0.01%)	338,682k	338,798k
Parse Time	2.08s (± 1.15%)	2.08s (± 1.18%)	-0.00s (- 0.19%)	2.04s	2.15s
Bind Time	0.79s (± 0.66%)	0.79s (± 0.46%)	+0.00s (+ 0.38%)	0.79s	0.80s
Check Time	5.82s (± 0.32%)	5.81s (± 0.44%)	-0.01s (- 0.22%)	5.77s	5.88s
Emit Time	6.19s (± 0.50%)	6.12s (± 0.57%)	-0.07s (- 1.08%)	6.03s	6.19s
Total Time	14.89s (± 0.39%)	14.81s (± 0.34%)	-0.08s (- 0.56%)	14.70s	14.90s
Compiler-Unions - node (v14.15.1, x64)
Memory used	192,940k (± 0.37%)	192,641k (± 0.02%)	-298k (- 0.15%)	192,541k	192,703k
Parse Time	0.86s (± 0.87%)	0.85s (± 0.61%)	-0.01s (- 0.93%)	0.84s	0.86s
Bind Time	0.49s (± 0.96%)	0.49s (± 0.98%)	-0.00s (- 0.61%)	0.48s	0.50s
Check Time	6.71s (± 0.63%)	6.72s (± 0.52%)	+0.02s (+ 0.27%)	6.68s	6.81s
Emit Time	2.43s (± 1.15%)	2.41s (± 0.76%)	-0.02s (- 0.95%)	2.36s	2.44s
Total Time	10.48s (± 0.57%)	10.46s (± 0.37%)	-0.02s (- 0.16%)	10.40s	10.57s
Monaco - node (v14.15.1, x64)
Memory used	326,550k (± 0.01%)	326,530k (± 0.00%)	-20k (- 0.01%)	326,496k	326,564k
Parse Time	1.58s (± 0.80%)	1.57s (± 0.49%)	-0.01s (- 0.63%)	1.55s	1.58s
Bind Time	0.72s (± 1.23%)	0.72s (± 0.41%)	-0.00s (- 0.41%)	0.72s	0.73s
Check Time	5.74s (± 0.39%)	5.71s (± 0.43%)	-0.03s (- 0.47%)	5.65s	5.78s
Emit Time	3.31s (± 0.61%)	3.32s (± 1.00%)	+0.01s (+ 0.27%)	3.27s	3.42s
Total Time	11.36s (± 0.24%)	11.33s (± 0.40%)	-0.03s (- 0.26%)	11.21s	11.42s
TFS - node (v14.15.1, x64)
Memory used	289,655k (± 0.01%)	289,672k (± 0.01%)	+17k (+ 0.01%)	289,633k	289,717k
Parse Time	1.31s (± 0.46%)	1.30s (± 0.71%)	-0.01s (- 0.54%)	1.28s	1.32s
Bind Time	0.79s (± 0.60%)	0.79s (± 0.28%)	-0.00s (- 0.25%)	0.79s	0.80s
Check Time	5.36s (± 0.36%)	5.32s (± 0.27%)	-0.04s (- 0.65%)	5.30s	5.36s
Emit Time	3.60s (± 0.64%)	3.56s (± 1.03%)	-0.04s (- 1.08%)	3.48s	3.68s
Total Time	11.06s (± 0.33%)	10.97s (± 0.40%)	-0.09s (- 0.78%)	10.85s	11.08s
material-ui - node (v14.15.1, x64)
Memory used	435,921k (± 0.00%)	435,855k (± 0.04%)	-66k (- 0.02%)	435,202k	435,965k
Parse Time	1.87s (± 0.50%)	1.87s (± 0.56%)	-0.00s (- 0.16%)	1.85s	1.89s
Bind Time	0.58s (± 0.95%)	0.58s (± 0.69%)	-0.00s (- 0.52%)	0.57s	0.59s
Check Time	12.88s (± 0.55%)	12.86s (± 0.75%)	-0.02s (- 0.16%)	12.70s	13.21s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.33s (± 0.48%)	15.31s (± 0.65%)	-0.02s (- 0.16%)	15.15s	15.67s
xstate - node (v14.15.1, x64)
Memory used	546,728k (± 0.00%)	546,741k (± 0.00%)	+13k (+ 0.00%)	546,723k	546,760k
Parse Time	2.62s (± 0.52%)	2.60s (± 0.55%)	-0.02s (- 0.84%)	2.57s	2.63s
Bind Time	0.97s (± 1.03%)	0.97s (± 0.93%)	-0.00s (- 0.21%)	0.95s	0.99s
Check Time	1.53s (± 0.87%)	1.52s (± 0.39%)	-0.01s (- 0.39%)	1.51s	1.54s
Emit Time	0.07s (± 4.92%)	0.07s (± 0.00%)	🟩-0.00s (- 5.41%)	0.07s	0.07s
Total Time	5.20s (± 0.45%)	5.16s (± 0.38%)	-0.03s (- 0.63%)	5.13s	5.22s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-210-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v14.15.1, x64)

Scenarios

• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	50592	10
Baseline	main	10

Developer Information:

Download Benchmark

[typescript-bot]

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/133333/artifacts?artifactName=tgz&fileId=012F8CA72FE55A3B0A8B9084CA77C4586116616A2C38D34A58A10FC2E786FAF502&fileName=/typescript-4.9.0-insiders.20220901.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

[andrewbranch]

@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot test top100

[typescript-bot]

Heya @andrewbranch, I've started to run the diff-based user code test suite on this PR at 46ce0b2. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at 46ce0b2. You can monitor the build here.

[typescript-bot]

Heya @andrewbranch, I've started to run the diff-based user code test suite on this PR at 46ce0b2. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@andrewbranch Here are the results of running the user test suite comparing main and refs/pull/50592/merge:

Everything looks good!

[typescript-bot]

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/50592/merge:

Everything looks good!

[andrewbranch]

@typescript-bot cherry-pick this to release-4.8

[typescript-bot]

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.8 on this PR at 3e227f7. You can monitor the build here.

[typescript-bot]

Hey @andrewbranch, I've opened #50596 for you.