feat(49962): Disallow comparison against NaN

[a-tarasyuk]

Fixes #49962

[DanielRosenwasser]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test this faster

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at fb44a1d. You can monitor the build here.

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at fb44a1d. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at fb44a1d. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at fb44a1d. You can monitor the build here.

[typescript-bot]

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/50626/merge:

Everything looks good!

[typescript-bot]

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

[typescript-bot]

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/50626/merge:

Everything looks good!

[DanielRosenwasser]

Weird that the perf test failed?

@typescript-bot perf test this faster

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 5ca49bb. You can monitor the build here.

[DanielRosenwasser]

Experimenting with the perf test issues over at #50812

[DanielRosenwasser]

@navya9singh @weswigham can you try to take a quick look? I think this is in a pretty good state, but I'd like to get at least one more pair of eyes by end-of-day before merging.

[a-tarasyuk]

@DanielRosenwasser Could you run perf test? I think @typescript-bot was fixed.

[weswigham]

@typescript-bot perf test this faster

[typescript-bot]

Heya @weswigham, I've started to run the abridged perf test suite on this PR at 89c00e6. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50626

Metric	main	50626	Delta	Best	Worst
Angular - node (v14.15.1, x64)
Memory used	338,972k (± 0.01%)	338,973k (± 0.00%)	+2k (+ 0.00%)	338,950k	338,999k
Parse Time	2.06s (± 0.76%)	2.06s (± 0.64%)	-0.00s (- 0.10%)	2.03s	2.09s
Bind Time	0.80s (± 0.75%)	0.80s (± 0.43%)	+0.00s (+ 0.13%)	0.79s	0.80s
Check Time	5.87s (± 0.25%)	5.89s (± 0.46%)	+0.02s (+ 0.34%)	5.83s	5.93s
Emit Time	6.25s (± 0.34%)	6.26s (± 0.72%)	+0.01s (+ 0.19%)	6.18s	6.39s
Total Time	14.98s (± 0.22%)	15.01s (± 0.46%)	+0.04s (+ 0.23%)	14.89s	15.21s
Compiler-Unions - node (v14.15.1, x64)
Memory used	190,212k (± 0.01%)	190,798k (± 0.67%)	+587k (+ 0.31%)	190,170k	195,996k
Parse Time	0.86s (± 0.40%)	0.85s (± 0.58%)	-0.00s (- 0.35%)	0.84s	0.86s
Bind Time	0.48s (± 0.77%)	0.49s (± 0.70%)	+0.00s (+ 0.41%)	0.48s	0.49s
Check Time	6.76s (± 0.42%)	6.76s (± 0.82%)	+0.00s (+ 0.04%)	6.65s	6.89s
Emit Time	2.43s (± 0.76%)	2.41s (± 0.90%)	-0.01s (- 0.54%)	2.38s	2.48s
Total Time	10.53s (± 0.38%)	10.52s (± 0.68%)	-0.01s (- 0.09%)	10.37s	10.65s
Monaco - node (v14.15.1, x64)
Memory used	326,550k (± 0.01%)	326,567k (± 0.00%)	+17k (+ 0.01%)	326,539k	326,608k
Parse Time	1.59s (± 0.57%)	1.59s (± 0.74%)	+0.00s (+ 0.13%)	1.57s	1.63s
Bind Time	0.72s (± 0.50%)	0.73s (± 0.65%)	+0.00s (+ 0.41%)	0.72s	0.74s
Check Time	5.71s (± 0.29%)	5.73s (± 0.43%)	+0.02s (+ 0.44%)	5.67s	5.78s
Emit Time	3.35s (± 0.66%)	3.40s (± 0.98%)	+0.05s (+ 1.40%)	3.36s	3.52s
Total Time	11.37s (± 0.26%)	11.45s (± 0.44%)	+0.07s (+ 0.66%)	11.37s	11.61s
TFS - node (v14.15.1, x64)
Memory used	289,671k (± 0.00%)	289,673k (± 0.00%)	+2k (+ 0.00%)	289,662k	289,707k
Parse Time	1.30s (± 0.89%)	1.30s (± 0.84%)	-0.00s (- 0.15%)	1.29s	1.34s
Bind Time	0.79s (± 2.33%)	0.80s (± 0.43%)	+0.00s (+ 0.63%)	0.79s	0.80s
Check Time	5.37s (± 0.53%)	5.36s (± 0.45%)	-0.02s (- 0.32%)	5.30s	5.40s
Emit Time	3.62s (± 1.05%)	3.61s (± 0.94%)	-0.01s (- 0.19%)	3.53s	3.69s
Total Time	11.08s (± 0.50%)	11.07s (± 0.44%)	-0.02s (- 0.14%)	10.94s	11.15s
material-ui - node (v14.15.1, x64)
Memory used	436,657k (± 0.00%)	436,669k (± 0.00%)	+12k (+ 0.00%)	436,619k	436,718k
Parse Time	1.88s (± 0.49%)	1.88s (± 1.00%)	-0.01s (- 0.32%)	1.86s	1.94s
Bind Time	0.59s (± 0.81%)	0.58s (± 1.02%)	-0.00s (- 0.34%)	0.57s	0.60s
Check Time	12.96s (± 0.70%)	12.86s (± 0.54%)	-0.10s (- 0.80%)	12.73s	12.98s
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	0.00s ( NaN%)	0.00s	0.00s
Total Time	15.43s (± 0.58%)	15.32s (± 0.50%)	-0.11s (- 0.72%)	15.20s	15.49s
xstate - node (v14.15.1, x64)
Memory used	547,150k (± 0.00%)	547,179k (± 0.00%)	+29k (+ 0.01%)	547,161k	547,209k
Parse Time	2.63s (± 0.69%)	2.64s (± 0.48%)	+0.01s (+ 0.42%)	2.61s	2.67s
Bind Time	0.98s (± 1.23%)	0.98s (± 1.23%)	-0.00s (- 0.00%)	0.96s	1.01s
Check Time	1.52s (± 0.59%)	1.52s (± 0.65%)	-0.01s (- 0.46%)	1.50s	1.54s
Emit Time	0.07s (± 0.00%)	0.07s (± 3.14%)	+0.00s (+ 1.43%)	0.07s	0.08s
Total Time	5.22s (± 0.46%)	5.22s (± 0.26%)	+0.00s (+ 0.02%)	5.20s	5.26s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-210-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v14.15.1, x64)

Scenarios

• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	50626	10
Baseline	main	10

Developer Information:

Download Benchmark

[DanielRosenwasser]

I think the perf test looks fine. I think we're good to merge!