Skip to content

Handle empty string when getting file version #51689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2022
Merged

Handle empty string when getting file version #51689

merged 2 commits into from
Nov 30, 2022

Conversation

sheetalkamat
Copy link
Member

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 29, 2022
DanielRosenwasser
DanielRosenwasser approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn-around!

@sheetalkamat sheetalkamat mentioned this pull request Nov 29, 2022
Merged
@sheetalkamat sheetalkamat merged commit 16edc29 into main Nov 30, 2022
@sheetalkamat sheetalkamat deleted the emptyString branch November 30, 2022 18:30
@cssecautomation cssecautomation mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

@jakebailey jakebailey Awaiting requested review from jakebailey

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @DanielRosenwasser @typescript-bot