Skip to content

Make getSupportedCodeFixes on LS so it can be proxied by plugins #51769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Dec 5, 2022

Fixes #28966

This should also help with #51713 so that getSupportedCodeFixes can be proxied by plugins esp with our module conversion ts.getSupportedCodeFixes cannot be overriden.

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

Copy link
Contributor

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protocol changes look good to me

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, though I am not sure what to do about existing plugins which do this. Do any at all? Or was this solely just VS Code itself hacking the ts object?

@sheetalkamat
Copy link
Member Author

Most plugins use this hack and would need to update their code but i am assuming many were using vscode proxy so it might not impact as many. But if we are anyways going to need plugins to update their code, then its better to get updated to new API than hack.

@jasonwilliams
Copy link

Most plugins use this hack and would need to update their code

Is there a right way we should be doing this? I'm happy to update our code if things have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LanguageService Plugin cannot intercept 'getSupportedCodeFixes'
5 participants