Skip to content

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Dec 15, 2022

Fixes #51617

As of the latest nightly VS Code TypeScript extension, we seem to handle things correctly.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 15, 2022
@jakebailey
Copy link
Member Author

If we also want Organize Imports to work, I can add in the necessary newlines or changes + eslint rule to enforce that, I was just trying to do more of a revert. But, I think people just want their editors to work better, so I can just add that change in here.

@jakebailey
Copy link
Member Author

Ugh, can't even enable declaration sorting in ESLint because it requires you to also be picky about the kinds of imports themselves:

image

Which, organize imports has no idea about. Would really just like to be using dprint to do this and leave eslint out of the picture.

@jakebailey
Copy link
Member Author

eslint-plugin-import can do this, but, it also doesn't match organize imports.

@rbuckton
Copy link
Contributor

rbuckton commented Jan 4, 2023

Maybe we need an eslint-plugin-organize-imports that uses our logic.

@jakebailey
Copy link
Member Author

At this point I am strongly preferring #52090.

@jakebailey jakebailey closed this Jan 20, 2023
@jakebailey jakebailey deleted the import-case-sensitive branch March 18, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Restore case-sensitive import sorting
3 participants