Do not report errors when inference is partially blocked #52728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
Andarist
commented
Feb 12, 2023
src/compiler/checker.ts
Outdated
| @@ -32601,7 +32604,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker { | |||
| const isTaggedTemplate = node.kind === SyntaxKind.TaggedTemplateExpression; | |||
| const isDecorator = node.kind === SyntaxKind.Decorator; | |||
| const isJsxOpeningOrSelfClosingElement = isJsxOpeningLikeElement(node); | |||
| const reportErrors = !candidatesOutArray; | |||
| const reportErrors = !isInferencePartiallyBlocked && !candidatesOutArray; | |||
There was a problem hiding this comment.
alternatively, we could check checkMode but ContextFlags.Completions isn't currently passed down as any kind of checkMode (whereas CheckMode.IsForStringLiteralArgumentCompletions already exists). So this would require some additional plumbing and I'm not sure if that's desired
Andarist
commented
Feb 12, 2023
Comment on lines
+7
to
+9
| goTo.marker("1"); | ||
| verify.completions({ exact: undefined }); | ||
| verify.noErrors(); |
There was a problem hiding this comment.
this was reporting excess property check - I still think that perhaps it shouldn't cause applicability error in this case when requesting completions but that's a separate problem
Andarist
commented
Feb 12, 2023
Comment on lines
+20
to
+25
| goTo.marker("1"); | ||
| const markerPosition = test.markers()[0].position; | ||
| edit.paste(`bar: { fn: (a: string, b) => {}, thing: "asd" },`) | ||
| edit.replace(markerPosition + 4, 1, 'z') | ||
| verify.completions({ isNewIdentifierLocation: true }); | ||
| verify.noErrors(); |
There was a problem hiding this comment.
This was an interesting case because the whole argument got blocked and thus A and B were replaced with their constraints and thus typing the argument Funcs<unknown, Record<string, unknown>>. And then the argument became not assignable to this target type - see the playground here
jakebailey
reviewed
Feb 12, 2023
src/compiler/checker.ts
Outdated
| const result = fn(); | ||
| isInferencePartiallyBlocked = false; |
There was a problem hiding this comment.
Is this reentrant such that you should save the value and restore it, rather than unconditionally setting false?
There was a problem hiding this comment.
I intentionally ignored this to keep the implementation simpler as I dont think it is
|
@typescript-bot pack this |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at dbd8664. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at dbd8664. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at dbd8664. You can monitor the build here. |
|
This looks good to me, but will wait until our extended tests work again to approve 🥲 |
|
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running |
|
The test stuff is working again, but this PR has a conflict now so I don't know if they'd actually give the right results. |
…sts-with-blocked-inference # Conflicts: # src/compiler/checker.ts
|
@jakebailey conflicts resolved |
|
@typescript-bot test this |
|
Heya @jakebailey, I've started to run the perf test suite on this PR at 92ec29e. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the extended test suite on this PR at 92ec29e. You can monitor the build here. |
|
Heya @jakebailey, I've started to run the tarball bundle task on this PR at 92ec29e. You can monitor the build here. |
|
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 92ec29e. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 92ec29e. You can monitor the build here. |
|
Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 92ec29e. You can monitor the build here. Update: The results are in! |
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 92ec29e. You can monitor the build here. Update: The results are in! |
|
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
|
Heya @jakebailey, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
|
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
andrewbranch
approved these changes
Feb 16, 2023
|
Just to check my understanding, this silences the errors, but is it possible that information related to those errors persists in some cache? |
|
This silences error reporting but before |
jakebailey
approved these changes
Feb 16, 2023
|
Ye, if I understand correctly the relationship cache is stable~ since it just caches the results of comparing A and B but that's totally unrelated to where those A and B are coming from. |
|
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
|
@jakebailey Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Detailsangular/angular-cli
|
|
@jakebailey Here are some more interesting changes from running the top-repos suite Detailsionic-team/ionic-framework
|
|
@jakebailey Here are some more interesting changes from running the top-repos suite Detailspnpm/pnpm
|
|
@jakebailey Here are some more interesting changes from running the top-repos suite Detailstrpc/trpc
|
|
@jakebailey Here they are:
CompilerComparison Report - main..52728
System
Hosts
Scenarios
TSServerComparison Report - main..52728
System
Hosts
Scenarios
StartupComparison Report - main..52728
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #50818
sort of supersedes #52393
cc @andrewbranch @weswigham