Update ThirdPartyNoticeText.txt #52800

gforcada · 2023-02-16T09:56:09Z

Fixes #52778

Fixes microsoft#52778

gforcada · 2023-02-16T10:22:14Z

@microsoft-github-policy-service agree

fatcerberus · 2023-02-16T14:20:48Z

What's up with this?

Are we certain the Unicode in the file was actually broken before? Because this seems to have made it worse... 👀

fatcerberus · 2023-02-16T14:23:29Z

ThirdPartyNoticeText.txt

 on ALL copies of the work or portions thereof, including modifications:
 * The full text of this NOTICE in a location viewable to users of the redistributed or derivative work.
 * Any pre-existing intellectual property disclaimers, notices, or terms and conditions. If none exist, the W3C Software and Document Short Notice should be included.
 * Notice of any changes or modifications, through a copyright statement on the new code or document such as "This software or document includes material copied from or derived 
-from [title and URI of the W3C document]. Copyright � [YEAR] W3C� (MIT, ERCIM, Keio, Beihang)." 
+from [title and URI of the W3C document]. Copyright (C) [YEAR] W3C(C) (MIT, ERCIM, Keio, Beihang)."


That second one is an (R) (restricted trademark), not a (C) (copyright).

Oh right, as I was replacing it for the third time I was not seeing it properly, thanks, for spotting it out 🔍

What's the problem with these being Unicode symbols?

gforcada · 2023-02-16T15:10:39Z

What's up with this?

Are we certain the Unicode in the file was actually broken before? Because this seems to have made it worse... eyes

That's interesting, indeed, seems it is now worse than before somehow, I copied these lines from the actual website, and my editor was showing them fine, but when I copied the text from my editor to GitHub to create this PR something might have gone wrong 😕

RyanCavanaugh

Please make this valid UTF-8 rather than trying to turn it all into ASCII

DanielRosenwasser · 2023-02-16T21:43:42Z

ThirdPartyNoticeText.txt

@@ -136,22 +136,22 @@ Any other capitalized terms not specifically defined herein have the same meanin
 7.2.1. Licensing Obligations to Resulting Specification. If I do not join the Corresponding Working Group, I agree to offer patent licenses according to the W3C Royalty-Free licensing requirements described in Section 5 of the W3C Patent Policy for the portions of the Specification included in the resulting Recommendation. This licensing commitment does not extend to any portion of an implementation of the Recommendation that was not included in the Specification. This licensing commitment may not be revoked but may be modified through the exclusion process defined in Section 4 of the W3C Patent Policy. I am not required to join the Corresponding Working Group to exclude patents from the W3C Royalty-Free licensing commitment, but must otherwise follow the normal exclusion procedures defined by the W3C Patent Policy. The W3C Team will notify me of any Call for Exclusion in the Corresponding Working Group as set forth in Section 4.5 of the W3C Patent Policy.
 7.2.2. No Disclosure Obligation. If I do not join the Corresponding Working Group, I have no patent disclosure obligations outside of those set forth in Section 6 of the W3C Patent Policy.
 8. Conflict of Interest. I will disclose significant relationships when those relationships might reasonably be perceived as creating a conflict of interest with my role. I will notify W3C of any change in my affiliation using W3C-provided mechanisms.
-9. Representations, Warranties and Disclaimers. I represent and warrant that I am legally entitled to grant the rights and promises set forth in this Agreement. IN ALL OTHER RESPECTS THE SPECIFICATION IS PROVIDED �AS IS.� The entire risk as to implementing or otherwise using the Specification is assumed by the implementer and user. Except as stated herein, I expressly disclaim any warranties (express, implied, or otherwise), including implied warranties of merchantability, non-infringement, fitness for a particular purpose, or title, related to the Specification. IN NO EVENT WILL ANY PARTY BE LIABLE TO ANY OTHER PARTY FOR LOST PROFITS OR ANY FORM OF INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES OF ANY CHARACTER FROM ANY CAUSES OF ACTION OF ANY KIND WITH RESPECT TO THIS AGREEMENT, WHETHER BASED ON BREACH OF CONTRACT, TORT (INCLUDING NEGLIGENCE), OR OTHERWISE, AND WHETHER OR NOT THE OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. All of my obligations under Section 3 regarding the transfer, successors in interest, or assignment of Granted Claims will be satisfied if I notify the transferee or assignee of any patent that I know contains Granted Claims of the obligations under Section 3. Nothing in this Agreement requires me to undertake a patent search.
+9. Representations, Warranties and Disclaimers. I represent and warrant that I am legally entitled to grant the rights and promises set forth in this Agreement. IN ALL OTHER RESPECTS THE SPECIFICATION IS PROVIDED “AS IS.” The entire risk as to implementing or otherwise using the Specification is assumed by the implementer and user. Except as stated herein, I expressly disclaim any warranties (express, implied, or otherwise), including implied warranties of merchantability, non-infringement, fitness for a particular purpose, or title, related to the Specification. IN NO EVENT WILL ANY PARTY BE LIABLE TO ANY OTHER PARTY FOR LOST PROFITS OR ANY FORM OF INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES OF ANY CHARACTER FROM ANY CAUSES OF ACTION OF ANY KIND WITH RESPECT TO THIS AGREEMENT, WHETHER BASED ON BREACH OF CONTRACT, TORT (INCLUDING NEGLIGENCE), OR OTHERWISE, AND WHETHER OR NOT THE OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. All of my obligations under Section 3 regarding the transfer, successors in interest, or assignment of Granted Claims will be satisfied if I notify the transferee or assignee of any patent that I know contains Granted Claims of the obligations under Section 3. Nothing in this Agreement requires me to undertake a patent search.


â€œAS IS.â€�

This is worse, right?

DanielRosenwasser

the file is now UTF-8, but the characters are wrong. Seems like you need to fix up the invalid characters with their UTF-8 equivalents.

DanielRosenwasser · 2023-02-16T21:49:23Z

Sorry - I didn't see the previous comments from Ryan.

DanielRosenwasser · 2023-02-16T21:59:42Z

I think what happened is that each of these special characters is UTF16 - but the rest of the file is actually UTF8/ASCII.

gforcada · 2023-02-18T22:51:00Z

Indeed, that's the point:

$ file -i ThirdPartyNoticeText.txt 
ThirdPartyNoticeText.txt: text/plain; charset=unknown-8bit

Due to these few characters that are in UTF-16 the encoding of the file is not consistent, iconv fails to convert it to UTF-8 as well 😕

I will try to extract the characters alone, convert them and add them back 🤞🏾 🍀

jakebailey · 2023-02-18T23:04:17Z

Here are some steps that work to fix the file for me:

Open the file in VS Code.
At the bottom right, click "UTF-8".
Select "reopen with encoding", then choose the detected encoding, which is "Western (Windows 1252)". (It's not UTF-16! 😄)
At the bottom right, click "Windows 1252".
Save as "UTF-8".

Then, you'll see a diff like:

And:

$ file -i ThirdPartyNoticeText.txt 
ThirdPartyNoticeText.txt: text/plain; charset=utf-8

RyanCavanaugh · 2023-03-09T18:43:12Z

Closing since it's been a couple weeks since changes were requested. New PR meeting the previously-given criteria are welcome.

Update ThirdPartyNoticeText.txt

b841b42

Fixes microsoft#52778

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 16, 2023

fatcerberus reviewed Feb 16, 2023

View reviewed changes

RyanCavanaugh requested changes Feb 16, 2023

View reviewed changes

DanielRosenwasser reviewed Feb 16, 2023

View reviewed changes

DanielRosenwasser requested changes Feb 16, 2023

View reviewed changes

sandersn assigned RyanCavanaugh Mar 9, 2023

RyanCavanaugh closed this Mar 9, 2023

jakebailey mentioned this pull request Mar 9, 2023

Fix ThirdPartyNoticeText.txt encoding #53184

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update ThirdPartyNoticeText.txt #52800

Update ThirdPartyNoticeText.txt #52800

Uh oh!

gforcada commented Feb 16, 2023

Uh oh!

gforcada commented Feb 16, 2023

Uh oh!

fatcerberus commented Feb 16, 2023 •

edited

Loading

Uh oh!

fatcerberus Feb 16, 2023

Uh oh!

gforcada Feb 16, 2023

Uh oh!

DanielRosenwasser Feb 16, 2023

Uh oh!

gforcada commented Feb 16, 2023

Uh oh!

RyanCavanaugh left a comment

Uh oh!

DanielRosenwasser Feb 16, 2023

Uh oh!

DanielRosenwasser left a comment •

edited

Loading

Uh oh!

DanielRosenwasser commented Feb 16, 2023

Uh oh!

DanielRosenwasser commented Feb 16, 2023

Uh oh!

gforcada commented Feb 18, 2023

Uh oh!

jakebailey commented Feb 18, 2023 •

edited

Loading

Uh oh!

RyanCavanaugh commented Mar 9, 2023

Uh oh!

Uh oh!

Update ThirdPartyNoticeText.txt #52800

Update ThirdPartyNoticeText.txt #52800

Uh oh!

Conversation

gforcada commented Feb 16, 2023

Uh oh!

gforcada commented Feb 16, 2023

Uh oh!

fatcerberus commented Feb 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fatcerberus Feb 16, 2023

Choose a reason for hiding this comment

Uh oh!

gforcada Feb 16, 2023

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser Feb 16, 2023

Choose a reason for hiding this comment

Uh oh!

gforcada commented Feb 16, 2023

Uh oh!

RyanCavanaugh left a comment

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser Feb 16, 2023

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser commented Feb 16, 2023

Uh oh!

DanielRosenwasser commented Feb 16, 2023

Uh oh!

gforcada commented Feb 18, 2023

Uh oh!

jakebailey commented Feb 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RyanCavanaugh commented Mar 9, 2023

Uh oh!

Uh oh!

fatcerberus commented Feb 16, 2023 •

edited

Loading

DanielRosenwasser left a comment •

edited

Loading

jakebailey commented Feb 18, 2023 •

edited

Loading