Skip to content

Fix overloadTag2 test #52814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Fix overloadTag2 test #52814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08171aa
Fix overloadTag2 test
jakebailey Feb 16, 2023
9d689a8
Revert and accept
jakebailey Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/baselines/reference/overloadTag2.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
tests/cases/conformance/jsdoc/overloadTag2.js(14,9): error TS2394: This overload signature is not compatible with its implementation signature.
tests/cases/conformance/jsdoc/overloadTag2.js(25,20): error TS7006: Parameter 'b' implicitly has an 'any' type.
tests/cases/conformance/jsdoc/overloadTag2.js(30,9): error TS2554: Expected 1-2 arguments, but got 0.


==== tests/cases/conformance/jsdoc/overloadTag2.js (2 errors) ====
==== tests/cases/conformance/jsdoc/overloadTag2.js (3 errors) ====
export class Foo {
#a = true ? 1 : "1"
#b
Expand All @@ -17,6 +18,9 @@ tests/cases/conformance/jsdoc/overloadTag2.js(30,9): error TS2554: Expected 1-2
/**
* @constructor
* @overload
~~~~~~~~
!!! error TS2394: This overload signature is not compatible with its implementation signature.
!!! related TS2750 tests/cases/conformance/jsdoc/overloadTag2.js:25:5: The implementation signature is declared here.
* @param {number} a
*/
/**
Expand Down