Defer the initializations in TI which results in many fileExistancy checks for existing packages and reading type registry to at use time #52817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecks for existing packages and reading type registry to at use time Fixes #52705
typescript-bot
added
Author: Team
For Uncommitted Bug
jakebailey
reviewed
Feb 17, 2023
| @@ -106,7 +106,7 @@ type ExecSync = (command: string, options: ExecSyncOptions) => string; | |||
| export class NodeTypingsInstaller extends TypingsInstaller { | |||
| private readonly nodeExecSync: ExecSync; | |||
| private readonly npmPath: string; | |||
| readonly typesRegistry: Map<string, MapLike<string>>; | |||
| typesRegistry: Map<string, MapLike<string>> = undefined!; | |||
There was a problem hiding this comment.
This variable is only referenced once; can we just make it potentially undefined and then assertDefined at its one usage, rather than adding undefined!?
sandersn
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52705