Skip to content

Omit intersection property check when source includes target #53012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

Omit intersection property check when source includes target #53012

merged 2 commits into from
Feb 28, 2023

Conversation

ahejlsberg
Copy link
Member

Fixes #53009.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Feb 28, 2023
@ahejlsberg
Copy link
Member Author

No regression test included, but I have manually verified that this causes material-ui to successfully compile.

@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f8eea3a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at f8eea3a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at f8eea3a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at f8eea3a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at f8eea3a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53012/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53012

Metric main 53012 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 359,064k (± 0.00%) 359,071k (± 0.01%) ~ 359,042k 359,095k p=0.575 n=6
Parse Time 3.73s (± 0.46%) 3.75s (± 0.66%) ~ 3.72s 3.79s p=0.256 n=6
Bind Time 1.19s (± 0.75%) 1.19s (± 0.63%) ~ 1.18s 1.20s p=0.798 n=6
Check Time 9.42s (± 0.98%) 9.47s (± 0.75%) ~ 9.38s 9.59s p=0.226 n=6
Emit Time 7.95s (± 0.67%) 7.94s (± 0.36%) ~ 7.92s 8.00s p=0.688 n=6
Total Time 22.29s (± 0.59%) 22.35s (± 0.43%) ~ 22.27s 22.51s p=0.468 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,466k (± 0.87%) 191,263k (± 0.02%) -1,203k (- 0.63%) 191,207k 191,295k p=0.005 n=6
Parse Time 1.56s (± 0.99%) 1.57s (± 0.35%) ~ 1.56s 1.57s p=0.675 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.63%) ~ 0.82s 0.83s p=0.595 n=6
Check Time 10.12s (± 0.60%) 10.11s (± 0.36%) ~ 10.07s 10.17s p=0.747 n=6
Emit Time 3.01s (± 0.35%) 2.99s (± 1.03%) ~ 2.96s 3.04s p=0.375 n=6
Total Time 15.50s (± 0.35%) 15.49s (± 0.37%) ~ 15.43s 15.59s p=0.936 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,118k (± 0.01%) 343,124k (± 0.00%) ~ 343,109k 343,141k p=0.630 n=6
Parse Time 2.80s (± 0.57%) 2.79s (± 0.59%) ~ 2.78s 2.82s p=0.461 n=6
Bind Time 1.08s (± 1.23%) 1.08s (± 0.48%) ~ 1.08s 1.09s p=0.928 n=6
Check Time 7.70s (± 0.48%) 7.66s (± 0.39%) ~ 7.62s 7.70s p=0.170 n=6
Emit Time 4.43s (± 0.65%) 4.42s (± 0.25%) ~ 4.40s 4.43s p=0.329 n=6
Total Time 16.01s (± 0.31%) 15.96s (± 0.23%) ~ 15.91s 16.01s p=0.126 n=6
TFS - node (v16.17.1, x64)
Memory used 299,254k (± 0.01%) 299,249k (± 0.01%) ~ 299,220k 299,282k p=0.575 n=6
Parse Time 2.16s (± 0.63%) 2.17s (± 1.18%) ~ 2.14s 2.20s p=0.680 n=6
Bind Time 1.25s (± 1.40%) 1.24s (± 0.67%) ~ 1.23s 1.25s p=0.933 n=6
Check Time 7.15s (± 0.33%) 7.20s (± 0.40%) +0.05s (+ 0.75%) 7.16s 7.24s p=0.012 n=6
Emit Time 4.33s (± 0.40%) 4.34s (± 0.75%) ~ 4.31s 4.38s p=0.739 n=6
Total Time 14.88s (± 0.29%) 14.96s (± 0.29%) +0.07s (+ 0.50%) 14.91s 15.03s p=0.029 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,670k (± 0.01%) 475,650k (± 0.00%) ~ 475,622k 475,670k p=0.810 n=6
Parse Time 3.31s (± 0.37%) 3.30s (± 0.52%) ~ 3.28s 3.33s p=0.357 n=6
Bind Time 0.96s (± 0.54%) 0.96s (± 1.09%) ~ 0.95s 0.98s p=0.794 n=6
Check Time 18.05s (± 0.39%) 18.25s (± 0.76%) +0.20s (+ 1.11%) 18.03s 18.38s p=0.037 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.31s (± 0.34%) 22.51s (± 0.65%) +0.20s (+ 0.90%) 22.27s 22.64s p=0.045 n=6
xstate - node (v16.17.1, x64)
Memory used 545,785k (± 0.03%) 545,710k (± 0.03%) ~ 545,551k 546,059k p=0.378 n=6
Parse Time 4.29s (± 0.52%) 4.30s (± 0.48%) ~ 4.27s 4.33s p=0.518 n=6
Bind Time 1.77s (± 0.62%) 1.77s (± 0.58%) ~ 1.75s 1.78s p=0.863 n=6
Check Time 2.99s (± 0.50%) 2.98s (± 0.51%) ~ 2.97s 3.01s p=0.871 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.14s (± 0.34%) 9.13s (± 0.34%) ~ 9.09s 9.18s p=1.000 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53012 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member

Just rechecking in case those two regressions are just noise. I'm pretty sure they are.

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at f8eea3a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53012/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53012
Metric main 53012 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,744k (± 0.01%) 359,767k (± 0.01%) ~ 359,691k 359,828k p=0.471 n=6
Parse Time 3.51s (± 1.13%) 3.49s (± 0.79%) ~ 3.46s 3.53s p=0.514 n=6
Bind Time 1.13s (± 1.03%) 1.13s (± 0.92%) ~ 1.11s 1.14s p=0.615 n=6
Check Time 8.69s (± 0.78%) 8.64s (± 0.40%) ~ 8.60s 8.69s p=0.294 n=6
Emit Time 7.47s (± 0.70%) 7.41s (± 0.50%) ~ 7.37s 7.47s p=0.054 n=6
Total Time 20.80s (± 0.70%) 20.67s (± 0.47%) ~ 20.54s 20.83s p=0.199 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 192,561k (± 1.60%) 190,542k (± 1.24%) -2,019k (- 1.05%) 189,481k 195,354k p=0.045 n=6
Parse Time 1.49s (± 0.66%) 1.48s (± 0.92%) ~ 1.46s 1.50s p=0.111 n=6
Bind Time 0.77s (± 1.27%) 0.77s (± 0.67%) ~ 0.76s 0.77s p=0.386 n=6
Check Time 9.34s (± 0.61%) 9.38s (± 0.69%) ~ 9.29s 9.45s p=0.376 n=6
Emit Time 2.73s (± 0.57%) 2.72s (± 0.71%) ~ 2.70s 2.75s p=0.413 n=6
Total Time 14.33s (± 0.50%) 14.34s (± 0.44%) ~ 14.25s 14.40s p=0.936 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,859k (± 0.02%) 343,856k (± 0.01%) ~ 343,831k 343,921k p=0.810 n=6
Parse Time 2.63s (± 0.61%) 2.63s (± 1.16%) ~ 2.59s 2.67s p=0.618 n=6
Bind Time 1.01s (± 0.40%) 1.01s (± 0.51%) ~ 1.00s 1.01s p=0.114 n=6
Check Time 6.99s (± 0.31%) 7.02s (± 0.42%) ~ 6.98s 7.05s p=0.147 n=6
Emit Time 4.20s (± 1.03%) 4.21s (± 0.92%) ~ 4.16s 4.26s p=0.574 n=6
Total Time 14.83s (± 0.33%) 14.87s (± 0.39%) ~ 14.81s 14.93s p=0.293 n=6
TFS - node (v18.10.0, x64)
Memory used 299,865k (± 0.01%) 299,897k (± 0.01%) +33k (+ 0.01%) 299,870k 299,928k p=0.031 n=6
Parse Time 2.02s (± 0.94%) 2.04s (± 0.91%) ~ 2.01s 2.06s p=0.195 n=6
Bind Time 1.14s (± 0.48%) 1.11s (± 6.18%) ~ 0.97s 1.14s p=0.855 n=6
Check Time 6.50s (± 0.79%) 6.51s (± 0.44%) ~ 6.48s 6.55s p=0.571 n=6
Emit Time 3.85s (± 0.63%) 3.85s (± 0.93%) ~ 3.80s 3.90s p=0.872 n=6
Total Time 13.51s (± 0.43%) 13.51s (± 0.49%) ~ 13.42s 13.60s p=1.000 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,387k (± 0.00%) 476,407k (± 0.00%) ~ 476,375k 476,431k p=0.173 n=6
Parse Time 3.13s (± 0.83%) 3.13s (± 0.44%) ~ 3.12s 3.16s p=0.292 n=6
Bind Time 0.92s (± 0.60%) 0.91s (± 1.08%) ~ 0.90s 0.93s p=0.322 n=6
Check Time 17.22s (± 0.99%) 17.02s (± 0.41%) -0.20s (- 1.19%) 16.93s 17.11s p=0.030 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.26s (± 0.88%) 21.06s (± 0.36%) -0.20s (- 0.96%) 20.97s 21.17s p=0.045 n=6
xstate - node (v18.10.0, x64)
Memory used 548,192k (± 0.02%) 548,062k (± 0.03%) ~ 547,918k 548,288k p=0.230 n=6
Parse Time 4.08s (± 0.48%) 4.08s (± 0.81%) ~ 4.03s 4.12s p=0.683 n=6
Bind Time 1.68s (± 0.49%) 1.67s (± 0.31%) -0.01s (- 0.60%) 1.66s 1.67s p=0.039 n=6
Check Time 2.77s (± 0.87%) 2.75s (± 0.82%) ~ 2.73s 2.79s p=0.147 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.61s (± 0.40%) 8.59s (± 0.55%) ~ 8.52s 8.66s p=0.334 n=6
Angular - node (v16.17.1, x64)
Memory used 359,064k (± 0.00%) 359,068k (± 0.01%) ~ 359,032k 359,087k p=0.423 n=6
Parse Time 3.73s (± 0.46%) 3.73s (± 0.26%) ~ 3.72s 3.74s p=0.869 n=6
Bind Time 1.19s (± 0.75%) 1.19s (± 0.00%) ~ 1.19s 1.19s p=1.000 n=6
Check Time 9.42s (± 0.98%) 9.45s (± 0.42%) ~ 9.39s 9.51s p=0.196 n=6
Emit Time 7.95s (± 0.67%) 7.92s (± 0.65%) ~ 7.88s 8.02s p=0.518 n=6
Total Time 22.29s (± 0.59%) 22.29s (± 0.38%) ~ 22.20s 22.44s p=0.936 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,466k (± 0.87%) 191,834k (± 0.70%) ~ 191,219k 194,561k p=0.128 n=6
Parse Time 1.56s (± 0.99%) 1.56s (± 0.91%) ~ 1.54s 1.58s p=1.000 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.50%) ~ 0.82s 0.83s p=1.000 n=6
Check Time 10.12s (± 0.60%) 10.07s (± 0.50%) ~ 10.01s 10.13s p=0.470 n=6
Emit Time 3.01s (± 0.35%) 2.99s (± 0.88%) ~ 2.95s 3.02s p=0.370 n=6
Total Time 15.50s (± 0.35%) 15.45s (± 0.40%) ~ 15.36s 15.52s p=0.334 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,118k (± 0.01%) 343,130k (± 0.01%) ~ 343,098k 343,147k p=0.298 n=6
Parse Time 2.80s (± 0.57%) 2.79s (± 0.87%) ~ 2.76s 2.83s p=0.517 n=6
Bind Time 1.08s (± 1.23%) 1.08s (± 0.75%) ~ 1.07s 1.09s p=0.866 n=6
Check Time 7.70s (± 0.48%) 7.68s (± 0.27%) ~ 7.64s 7.70s p=0.468 n=6
Emit Time 4.43s (± 0.65%) 4.42s (± 0.42%) ~ 4.39s 4.44s p=0.570 n=6
Total Time 16.01s (± 0.31%) 15.98s (± 0.16%) ~ 15.96s 16.02s p=0.250 n=6
TFS - node (v16.17.1, x64)
Memory used 299,254k (± 0.01%) 299,240k (± 0.01%) ~ 299,197k 299,276k p=0.471 n=6
Parse Time 2.16s (± 0.63%) 2.16s (± 1.12%) ~ 2.12s 2.18s p=0.289 n=6
Bind Time 1.25s (± 1.40%) 1.24s (± 1.07%) ~ 1.22s 1.25s p=0.461 n=6
Check Time 7.15s (± 0.33%) 7.17s (± 0.31%) ~ 7.13s 7.19s p=0.195 n=6
Emit Time 4.33s (± 0.40%) 4.33s (± 0.48%) ~ 4.29s 4.34s p=0.802 n=6
Total Time 14.88s (± 0.29%) 14.90s (± 0.36%) ~ 14.82s 14.96s p=0.567 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,670k (± 0.01%) 475,652k (± 0.00%) ~ 475,637k 475,663k p=0.575 n=6
Parse Time 3.31s (± 0.37%) 3.29s (± 0.19%) -0.02s (- 0.45%) 3.28s 3.30s p=0.027 n=6
Bind Time 0.96s (± 0.54%) 0.96s (± 0.78%) ~ 0.95s 0.97s p=0.241 n=6
Check Time 18.05s (± 0.39%) 18.15s (± 0.88%) ~ 18.01s 18.42s p=0.336 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.31s (± 0.34%) 22.40s (± 0.73%) ~ 22.25s 22.67s p=0.471 n=6
xstate - node (v16.17.1, x64)
Memory used 545,785k (± 0.03%) 545,658k (± 0.02%) ~ 545,545k 545,753k p=0.378 n=6
Parse Time 4.29s (± 0.52%) 4.30s (± 0.32%) ~ 4.27s 4.31s p=0.686 n=6
Bind Time 1.77s (± 0.62%) 1.77s (± 0.46%) ~ 1.76s 1.78s p=0.666 n=6
Check Time 2.99s (± 0.50%) 2.98s (± 0.63%) ~ 2.97s 3.02s p=0.569 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.14s (± 0.34%) 9.13s (± 0.26%) ~ 9.10s 9.16s p=1.000 n=6
Angular - node (v14.15.1, x64)
Memory used 352,813k (± 0.01%) 352,815k (± 0.00%) ~ 352,800k 352,835k p=0.873 n=6
Parse Time 3.71s (± 1.03%) 3.69s (± 0.40%) ~ 3.67s 3.71s p=0.226 n=6
Bind Time 1.24s (± 0.44%) 1.24s (± 0.33%) ~ 1.24s 1.25s p=0.282 n=6
Check Time 9.73s (± 0.37%) 9.68s (± 0.36%) ~ 9.63s 9.73s p=0.107 n=6
Emit Time 8.38s (± 0.55%) 8.35s (± 0.68%) ~ 8.26s 8.42s p=0.628 n=6
Total Time 23.06s (± 0.26%) 22.97s (± 0.33%) ~ 22.84s 23.03s p=0.108 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 186,589k (± 0.01%) 186,544k (± 0.01%) -45k (- 0.02%) 186,502k 186,569k p=0.008 n=6
Parse Time 1.58s (± 0.74%) 1.57s (± 0.52%) ~ 1.56s 1.58s p=0.401 n=6
Bind Time 0.84s (± 0.48%) 0.84s (± 0.49%) ~ 0.83s 0.84s p=0.218 n=6
Check Time 10.19s (± 0.58%) 10.18s (± 0.41%) ~ 10.10s 10.22s p=0.871 n=6
Emit Time 3.13s (± 0.81%) 3.14s (± 1.48%) ~ 3.10s 3.23s p=0.935 n=6
Total Time 15.73s (± 0.42%) 15.73s (± 0.43%) ~ 15.62s 15.82s p=0.936 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,118k (± 0.00%) 338,115k (± 0.01%) ~ 338,080k 338,149k p=1.000 n=6
Parse Time 2.88s (± 0.68%) 2.88s (± 0.52%) ~ 2.86s 2.89s p=0.493 n=6
Bind Time 1.10s (± 0.37%) 1.11s (± 1.05%) ~ 1.09s 1.12s p=0.102 n=6
Check Time 8.10s (± 0.35%) 8.05s (± 0.33%) -0.05s (- 0.68%) 8.01s 8.09s p=0.015 n=6
Emit Time 4.69s (± 0.93%) 4.69s (± 1.12%) ~ 4.66s 4.80s p=1.000 n=6
Total Time 16.78s (± 0.33%) 16.73s (± 0.41%) ~ 16.66s 16.85s p=0.170 n=6
TFS - node (v14.15.1, x64)
Memory used 294,291k (± 0.00%) 294,292k (± 0.00%) ~ 294,284k 294,302k p=0.748 n=6
Parse Time 2.38s (± 0.94%) 2.37s (± 0.60%) ~ 2.35s 2.39s p=0.371 n=6
Bind Time 1.07s (± 0.48%) 1.06s (± 0.38%) ~ 1.06s 1.07s p=0.112 n=6
Check Time 7.50s (± 0.57%) 7.47s (± 0.62%) ~ 7.42s 7.55s p=0.199 n=6
Emit Time 4.29s (± 1.43%) 4.29s (± 0.12%) ~ 4.28s 4.29s p=0.082 n=6
Total Time 15.24s (± 0.64%) 15.19s (± 0.28%) ~ 15.13s 15.25s p=0.336 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,301k (± 0.01%) 471,338k (± 0.01%) ~ 471,308k 471,376k p=0.066 n=6
Parse Time 3.45s (± 0.45%) 3.46s (± 0.51%) ~ 3.44s 3.48s p=0.615 n=6
Bind Time 1.01s (± 0.88%) 1.00s (± 0.54%) ~ 1.00s 1.01s p=0.341 n=6
Check Time 19.04s (± 0.81%) 19.04s (± 0.80%) ~ 18.83s 19.23s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.50s (± 0.67%) 23.50s (± 0.69%) ~ 23.29s 23.70s p=1.000 n=6
xstate - node (v14.15.1, x64)
Memory used 534,520k (± 0.00%) 534,383k (± 0.00%) -138k (- 0.03%) 534,359k 534,421k p=0.005 n=6
Parse Time 4.51s (± 1.80%) 4.52s (± 1.52%) ~ 4.43s 4.58s p=1.000 n=6
Bind Time 1.74s (± 4.13%) 1.70s (± 3.05%) ~ 1.66s 1.79s p=0.254 n=6
Check Time 3.17s (± 0.26%) 3.12s (± 0.74%) -0.04s (- 1.37%) 3.09s 3.16s p=0.004 n=6
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) ~ 0.10s 0.10s p=1.000 n=6
Total Time 9.52s (± 0.19%) 9.44s (± 0.40%) -0.08s (- 0.84%) 9.38s 9.49s p=0.006 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53012 6
Baseline main 6

TSServer

Comparison Report - main..53012
Metric main 53012 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,361ms (± 0.44%) 2,371ms (± 1.17%) ~ 2,352ms 2,425ms p=0.810 n=6
Req 2 - geterr 5,318ms (± 1.02%) 5,310ms (± 0.80%) ~ 5,240ms 5,362ms p=1.000 n=6
Req 3 - references 338ms (± 1.37%) 339ms (± 2.12%) ~ 334ms 353ms p=1.000 n=6
Req 4 - navto 285ms (± 1.12%) 284ms (± 0.88%) ~ 281ms 288ms p=0.625 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 73ms (± 5.07%) 74ms (± 5.83%) ~ 69ms 79ms p=0.935 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,519ms (± 1.15%) 2,516ms (± 1.03%) ~ 2,468ms 2,546ms p=0.873 n=6
Req 2 - geterr 3,978ms (± 0.77%) 3,985ms (± 0.64%) ~ 3,948ms 4,018ms p=0.575 n=6
Req 3 - references 351ms (± 0.50%) 354ms (± 0.44%) +3ms (+ 0.76%) 352ms 356ms p=0.029 n=6
Req 4 - navto 292ms (± 0.31%) 293ms (± 0.19%) ~ 292ms 293ms p=0.341 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 70ms (± 8.42%) 69ms (± 1.22%) ~ 68ms 70ms p=0.325 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,167ms (± 0.65%) 3,165ms (± 0.24%) ~ 3,156ms 3,173ms p=0.630 n=6
Req 2 - geterr 1,616ms (± 0.82%) 1,603ms (± 0.51%) -14ms (- 0.84%) 1,589ms 1,613ms p=0.045 n=6
Req 3 - references 105ms (± 3.83%) 105ms (± 1.94%) ~ 103ms 108ms p=0.677 n=6
Req 4 - navto 361ms (± 0.38%) 359ms (± 0.51%) -2ms (- 0.60%) 356ms 361ms p=0.046 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 430ms (± 1.25%) 429ms (± 0.85%) ~ 425ms 436ms p=0.421 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,528ms (± 1.52%) 2,473ms (± 1.20%) -55ms (- 2.16%) 2,448ms 2,532ms p=0.045 n=6
Req 2 - geterr 5,690ms (± 0.50%) 5,697ms (± 0.60%) ~ 5,653ms 5,748ms p=0.810 n=6
Req 3 - references 348ms (± 0.35%) 350ms (± 0.94%) ~ 346ms 355ms p=0.373 n=6
Req 4 - navto 280ms (± 0.37%) 280ms (± 1.04%) ~ 276ms 285ms p=0.803 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 84ms (± 1.06%) 87ms (± 4.99%) ~ 84ms 95ms p=0.084 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,675ms (± 0.41%) 2,665ms (± 0.96%) ~ 2,624ms 2,693ms p=0.748 n=6
Req 2 - geterr 4,343ms (± 0.59%) 4,337ms (± 0.51%) ~ 4,302ms 4,359ms p=0.936 n=6
Req 3 - references 364ms (± 1.14%) 365ms (± 1.21%) ~ 357ms 369ms p=0.290 n=6
Req 4 - navto 289ms (± 1.06%) 287ms (± 1.23%) ~ 283ms 292ms p=0.333 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 73ms (± 0.71%) 74ms (± 3.34%) ~ 72ms 79ms p=0.142 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,331ms (± 0.40%) 3,328ms (± 0.31%) ~ 3,313ms 3,340ms p=0.748 n=6
Req 2 - geterr 1,776ms (± 0.92%) 1,769ms (± 1.14%) ~ 1,749ms 1,797ms p=0.423 n=6
Req 3 - references 112ms (± 2.26%) 111ms (± 2.39%) ~ 109ms 115ms p=0.737 n=6
Req 4 - navto 346ms (± 0.99%) 342ms (± 0.91%) ~ 339ms 347ms p=0.107 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 436ms (± 0.93%) 437ms (± 0.51%) ~ 434ms 440ms p=0.517 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,583ms (± 0.59%) 2,570ms (± 0.96%) ~ 2,525ms 2,591ms p=0.423 n=6
Req 2 - geterr 6,002ms (± 0.38%) 6,023ms (± 0.54%) ~ 5,990ms 6,074ms p=0.298 n=6
Req 3 - references 365ms (± 0.62%) 365ms (± 0.55%) ~ 362ms 368ms p=1.000 n=6
Req 4 - navto 278ms (± 1.94%) 275ms (± 1.04%) ~ 273ms 281ms p=0.558 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 96ms (± 8.13%) 100ms (± 1.77%) ~ 96ms 101ms p=0.931 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,811ms (± 0.32%) 2,818ms (± 0.63%) ~ 2,791ms 2,832ms p=0.335 n=6
Req 2 - geterr 4,474ms (± 2.36%) 4,435ms (± 1.60%) ~ 4,393ms 4,579ms p=0.575 n=6
Req 3 - references 403ms (± 6.23%) 388ms (± 5.56%) ~ 377ms 432ms p=0.469 n=6
Req 4 - navto 290ms (± 1.47%) 293ms (± 1.59%) ~ 286ms 297ms p=0.376 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 90ms (± 8.24%) 92ms (±10.03%) ~ 83ms 102ms p=0.570 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,651ms (± 0.72%) 3,635ms (± 0.59%) ~ 3,595ms 3,651ms p=0.521 n=6
Req 2 - geterr 1,846ms (± 0.69%) 1,838ms (± 1.33%) ~ 1,817ms 1,881ms p=0.378 n=6
Req 3 - references 128ms (± 3.02%) 129ms (± 2.50%) ~ 125ms 133ms p=0.871 n=6
Req 4 - navto 372ms (± 0.88%) 377ms (± 1.76%) ~ 372ms 390ms p=0.122 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 450ms (± 1.39%) 461ms (± 2.80%) ~ 444ms 475ms p=0.226 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53012 6
Baseline main 6

Startup

Comparison Report - main..53012
Metric main 53012 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 143.01ms (± 0.22%) 142.76ms (± 0.21%) -0.25ms (- 0.17%) 142.11ms 146.54ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 228.46ms (± 0.26%) 227.89ms (± 0.17%) -0.57ms (- 0.25%) 226.68ms 232.20ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 230.34ms (± 0.30%) 229.35ms (± 0.15%) -0.99ms (- 0.43%) 228.43ms 234.34ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 211.91ms (± 0.34%) 210.19ms (± 0.16%) -1.72ms (- 0.81%) 209.23ms 214.75ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53012 6
Baseline main 6

Developer Information:

Download Benchmark

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Feb 28, 2023 •
edited
Loading

Is the affected test case in this PR representative of the 5.0 regression we saw in the latest material-ui? I just saw #53012 (comment). If we can figure out a minimal test case, seems like we should add one and then cherry-pick this to release-5.0.

I don't know if it's worth holding up the RC since it accidentally got published to NuGet yesterday anyway - but we can talk about it tomorrow.

@ahejlsberg
Copy link
Member Author

Tests and performance all look good. Merging.

@ahejlsberg ahejlsberg merged commit 7481434 into main Feb 28, 2023
@ahejlsberg ahejlsberg deleted the fix53009 branch February 28, 2023 14:57
@jakebailey
Copy link
Member

@typescript-bot cherry-pick this to release-5.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the task to cherry-pick this into release-5.0 on this PR at f8eea3a. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Feb 28, 2023
Merged
@typescript-bot
Copy link
Collaborator

Hey @jakebailey, I've opened #53024 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Feb 28, 2023
@ahejlsberg @typescript-bot
Cherry-pick PR microsoft#53012 into release-5.0
25829eb 
Component commits:
2983c85 Omit intersection property check when source includes target

f8eea3a Accept new baselines
DanielRosenwasser pushed a commit that referenced this pull request Mar 2, 2023
@ahejlsberg
🤖 Pick PR #53012 (Omit intersection property check wh...) into releas…
3ede924 
…e-5.0 (#53024)

Co-authored-by: Anders Hejlsberg <[email protected]>
@jakebailey jakebailey mentioned this pull request Mar 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

material-ui docs OOM after intersectionState propagation in relations
4 participants
@ahejlsberg @typescript-bot @jakebailey @DanielRosenwasser