Skip to content

Add NullKeyword to isPartOfTypeNode, mirroring UndefinedKeyword #53025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 7, 2023
Merged

Add NullKeyword to isPartOfTypeNode, mirroring UndefinedKeyword #53025

merged 8 commits into from
Mar 7, 2023

Conversation

jakebailey
Copy link
Member

While reviewing #52960, I noticed that we have a bunch of lines like >null : null, and yet, none like >undefined : undefined.

It turns out that we forgot to add NullKeyword to isPartOfTypeNode. Oops.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 28, 2023
@jakebailey
Copy link
Member Author

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 48286a0. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 48286a0. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at 48286a0. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 28, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 48286a0. You can monitor the build here.

Update: The results are in!

@jakebailey
Copy link
Member Author

jakebailey commented Feb 28, 2023 •
edited
Loading

Of course, I am now confused about this function in general. We use it like it always traverses parents, but, it short circuits at keywords?

In any case, there's no reason for this function to be inconsistent between undefined and null.

@jakebailey jakebailey changed the title Add null to isPartOfTypeNode Add NullKeywrod to isPartOfTypeNode, mirroring UndefinedKeyword Feb 28, 2023
@jakebailey jakebailey changed the title Add NullKeywrod to isPartOfTypeNode, mirroring UndefinedKeyword Add NullKeyword to isPartOfTypeNode, mirroring UndefinedKeyword Feb 28, 2023
@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53025/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53025
Metric main 53025 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,793k (± 0.01%) 359,793k (± 0.01%) ~ 359,742k 359,846k p=1.000 n=6
Parse Time 3.48s (± 0.71%) 3.50s (± 1.21%) ~ 3.46s 3.55s p=0.467 n=6
Bind Time 1.13s (± 0.36%) 1.13s (± 0.92%) ~ 1.11s 1.14s p=0.924 n=6
Check Time 8.67s (± 0.77%) 8.65s (± 0.39%) ~ 8.61s 8.70s p=0.630 n=6
Emit Time 7.43s (± 0.96%) 7.44s (± 0.55%) ~ 7.39s 7.49s p=1.000 n=6
Total Time 20.71s (± 0.45%) 20.72s (± 0.24%) ~ 20.65s 20.78s p=0.518 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 193,372k (± 1.52%) 191,454k (± 1.50%) ~ 189,491k 195,182k p=0.298 n=6
Parse Time 1.48s (± 0.82%) 1.48s (± 0.66%) ~ 1.47s 1.49s p=0.498 n=6
Bind Time 0.77s (± 0.53%) 0.77s (± 1.52%) ~ 0.76s 0.79s p=0.584 n=6
Check Time 9.33s (± 0.78%) 9.37s (± 1.17%) ~ 9.22s 9.56s p=0.260 n=6
Emit Time 2.73s (± 0.92%) 2.73s (± 0.23%) ~ 2.72s 2.74s p=0.507 n=6
Total Time 14.30s (± 0.60%) 14.35s (± 0.86%) ~ 14.19s 14.57s p=0.336 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,858k (± 0.02%) 343,867k (± 0.01%) ~ 343,837k 343,956k p=0.936 n=6
Parse Time 2.62s (± 0.51%) 2.63s (± 0.71%) ~ 2.60s 2.65s p=0.402 n=6
Bind Time 1.01s (± 0.51%) 1.01s (± 0.80%) ~ 1.00s 1.02s p=0.140 n=6
Check Time 7.02s (± 0.88%) 7.03s (± 0.61%) ~ 6.98s 7.08s p=0.809 n=6
Emit Time 4.21s (± 0.55%) 4.21s (± 0.32%) ~ 4.19s 4.23s p=0.935 n=6
Total Time 14.86s (± 0.48%) 14.88s (± 0.35%) ~ 14.79s 14.93s p=0.688 n=6
TFS - node (v18.10.0, x64)
Memory used 299,886k (± 0.01%) 299,897k (± 0.01%) ~ 299,855k 299,924k p=0.378 n=6
Parse Time 2.05s (± 0.73%) 2.05s (± 0.67%) ~ 2.03s 2.07s p=1.000 n=6
Bind Time 1.14s (± 0.66%) 1.14s (± 0.55%) ~ 1.13s 1.15s p=0.718 n=6
Check Time 6.50s (± 0.73%) 6.50s (± 0.38%) ~ 6.47s 6.54s p=0.627 n=6
Emit Time 3.85s (± 1.09%) 3.84s (± 1.01%) ~ 3.80s 3.91s p=0.686 n=6
Total Time 13.54s (± 0.59%) 13.52s (± 0.51%) ~ 13.46s 13.65s p=0.810 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,413k (± 0.00%) 476,422k (± 0.01%) ~ 476,384k 476,473k p=0.810 n=6
Parse Time 3.13s (± 0.72%) 3.13s (± 0.91%) ~ 3.08s 3.16s p=0.745 n=6
Bind Time 0.91s (± 0.45%) 0.92s (± 0.91%) ~ 0.91s 0.93s p=0.115 n=6
Check Time 17.07s (± 0.62%) 17.15s (± 0.56%) ~ 17.03s 17.27s p=0.230 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.11s (± 0.59%) 21.19s (± 0.52%) ~ 21.04s 21.31s p=0.229 n=6
xstate - node (v18.10.0, x64)
Memory used 548,046k (± 0.02%) 548,054k (± 0.02%) ~ 547,958k 548,215k p=0.689 n=6
Parse Time 4.07s (± 0.56%) 4.07s (± 0.49%) ~ 4.05s 4.10s p=1.000 n=6
Bind Time 1.66s (± 0.45%) 1.67s (± 1.48%) ~ 1.63s 1.70s p=0.250 n=6
Check Time 2.75s (± 0.68%) 2.78s (± 0.78%) +0.03s (+ 1.09%) 2.75s 2.81s p=0.042 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.57s (± 0.30%) 8.60s (± 0.53%) ~ 8.55s 8.66s p=0.228 n=6
Angular - node (v16.17.1, x64)
Memory used 359,078k (± 0.01%) 359,074k (± 0.00%) ~ 359,054k 359,101k p=0.689 n=6
Parse Time 3.72s (± 0.36%) 3.72s (± 0.44%) ~ 3.69s 3.74s p=0.737 n=6
Bind Time 1.20s (± 0.46%) 1.20s (± 1.01%) ~ 1.19s 1.22s p=0.855 n=6
Check Time 9.42s (± 0.41%) 9.43s (± 0.49%) ~ 9.37s 9.49s p=0.517 n=6
Emit Time 7.90s (± 0.33%) 7.91s (± 0.46%) ~ 7.88s 7.97s p=1.000 n=6
Total Time 22.23s (± 0.26%) 22.25s (± 0.31%) ~ 22.16s 22.37s p=0.571 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 191,818k (± 0.72%) 192,368k (± 0.88%) ~ 191,259k 194,635k p=0.471 n=6
Parse Time 1.55s (± 0.88%) 1.57s (± 0.53%) ~ 1.55s 1.57s p=0.109 n=6
Bind Time 0.82s (± 0.92%) 0.82s (± 0.50%) ~ 0.81s 0.82s p=1.000 n=6
Check Time 10.08s (± 0.57%) 10.15s (± 0.57%) ~ 10.05s 10.21s p=0.092 n=6
Emit Time 3.00s (± 1.00%) 2.99s (± 1.12%) ~ 2.95s 3.04s p=0.573 n=6
Total Time 15.45s (± 0.38%) 15.53s (± 0.36%) +0.08s (+ 0.50%) 15.42s 15.58s p=0.029 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,121k (± 0.01%) 343,126k (± 0.01%) ~ 343,101k 343,188k p=1.000 n=6
Parse Time 2.78s (± 0.45%) 2.80s (± 0.73%) ~ 2.77s 2.83s p=0.096 n=6
Bind Time 1.08s (± 0.78%) 1.08s (± 0.70%) ~ 1.07s 1.09s p=0.209 n=6
Check Time 7.65s (± 0.28%) 7.69s (± 0.27%) +0.04s (+ 0.52%) 7.66s 7.71s p=0.016 n=6
Emit Time 4.42s (± 0.55%) 4.43s (± 1.03%) ~ 4.37s 4.49s p=1.000 n=6
Total Time 15.93s (± 0.24%) 15.99s (± 0.44%) ~ 15.91s 16.08s p=0.108 n=6
TFS - node (v16.17.1, x64)
Memory used 299,236k (± 0.01%) 299,245k (± 0.01%) ~ 299,202k 299,280k p=0.630 n=6
Parse Time 2.15s (± 0.96%) 2.17s (± 0.38%) ~ 2.16s 2.18s p=0.220 n=6
Bind Time 1.24s (± 1.19%) 1.24s (± 0.41%) ~ 1.24s 1.25s p=0.451 n=6
Check Time 7.14s (± 0.31%) 7.19s (± 0.44%) +0.05s (+ 0.70%) 7.16s 7.25s p=0.006 n=6
Emit Time 4.34s (± 0.91%) 4.35s (± 0.58%) ~ 4.32s 4.38s p=0.469 n=6
Total Time 14.87s (± 0.36%) 14.95s (± 0.31%) +0.07s (+ 0.50%) 14.89s 15.03s p=0.045 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,660k (± 0.00%) 475,661k (± 0.00%) ~ 475,644k 475,676k p=0.936 n=6
Parse Time 3.29s (± 0.37%) 3.29s (± 0.43%) ~ 3.27s 3.31s p=0.615 n=6
Bind Time 0.96s (± 0.78%) 0.96s (± 0.54%) ~ 0.95s 0.96s p=0.241 n=6
Check Time 18.06s (± 0.22%) 18.06s (± 0.27%) ~ 17.97s 18.10s p=0.747 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.30s (± 0.24%) 22.31s (± 0.26%) ~ 22.20s 22.36s p=0.521 n=6
xstate - node (v16.17.1, x64)
Memory used 545,706k (± 0.02%) 545,635k (± 0.01%) ~ 545,581k 545,740k p=0.471 n=6
Parse Time 4.28s (± 0.21%) 4.31s (± 0.46%) +0.03s (+ 0.62%) 4.27s 4.32s p=0.042 n=6
Bind Time 1.76s (± 0.36%) 1.76s (± 0.66%) ~ 1.74s 1.77s p=1.000 n=6
Check Time 2.98s (± 0.35%) 2.99s (± 0.25%) ~ 2.98s 3.00s p=0.251 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.12s (± 0.13%) 9.14s (± 0.24%) ~ 9.11s 9.17s p=0.052 n=6
Angular - node (v14.15.1, x64)
Memory used 352,825k (± 0.00%) 352,826k (± 0.00%) ~ 352,819k 352,833k p=1.000 n=6
Parse Time 3.69s (± 0.72%) 3.70s (± 0.32%) ~ 3.69s 3.72s p=0.452 n=6
Bind Time 1.25s (± 0.44%) 1.25s (± 0.44%) ~ 1.24s 1.25s p=1.000 n=6
Check Time 9.71s (± 0.57%) 9.72s (± 0.34%) ~ 9.68s 9.78s p=0.808 n=6
Emit Time 8.34s (± 0.75%) 8.34s (± 0.54%) ~ 8.27s 8.41s p=1.000 n=6
Total Time 22.98s (± 0.51%) 23.01s (± 0.28%) ~ 22.93s 23.09s p=0.810 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 186,543k (± 0.01%) 186,535k (± 0.01%) ~ 186,497k 186,561k p=0.936 n=6
Parse Time 1.57s (± 0.48%) 1.58s (± 0.89%) ~ 1.56s 1.60s p=0.137 n=6
Bind Time 0.85s (± 1.45%) 0.84s (± 0.97%) ~ 0.84s 0.86s p=1.000 n=6
Check Time 10.19s (± 0.39%) 10.17s (± 0.36%) ~ 10.13s 10.23s p=0.332 n=6
Emit Time 3.12s (± 0.89%) 3.12s (± 0.24%) ~ 3.11s 3.13s p=0.558 n=6
Total Time 15.72s (± 0.18%) 15.71s (± 0.31%) ~ 15.66s 15.79s p=0.628 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,114k (± 0.00%) 338,095k (± 0.01%) ~ 338,076k 338,131k p=0.078 n=6
Parse Time 2.87s (± 0.36%) 2.88s (± 0.64%) ~ 2.87s 2.91s p=0.803 n=6
Bind Time 1.10s (± 0.37%) 1.10s (± 0.68%) ~ 1.09s 1.11s p=1.000 n=6
Check Time 8.06s (± 0.53%) 8.05s (± 0.54%) ~ 7.98s 8.09s p=1.000 n=6
Emit Time 4.67s (± 0.60%) 4.68s (± 0.69%) ~ 4.66s 4.74s p=0.678 n=6
Total Time 16.71s (± 0.34%) 16.72s (± 0.30%) ~ 16.66s 16.77s p=0.628 n=6
TFS - node (v14.15.1, x64)
Memory used 294,288k (± 0.00%) 294,285k (± 0.00%) ~ 294,263k 294,298k p=0.873 n=6
Parse Time 2.37s (± 0.82%) 2.40s (± 1.23%) ~ 2.37s 2.45s p=0.106 n=6
Bind Time 1.07s (± 0.78%) 1.06s (± 0.71%) ~ 1.05s 1.07s p=0.652 n=6
Check Time 7.46s (± 0.35%) 7.47s (± 0.59%) ~ 7.39s 7.52s p=0.572 n=6
Emit Time 4.29s (± 0.18%) 4.26s (± 0.57%) ~ 4.24s 4.30s p=0.164 n=6
Total Time 15.19s (± 0.14%) 15.19s (± 0.33%) ~ 15.12s 15.26s p=0.686 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,336k (± 0.00%) 471,338k (± 0.01%) ~ 471,295k 471,378k p=1.000 n=6
Parse Time 3.46s (± 0.65%) 3.45s (± 0.54%) ~ 3.43s 3.48s p=0.164 n=6
Bind Time 1.00s (± 0.83%) 1.00s (± 0.75%) ~ 0.99s 1.01s p=0.432 n=6
Check Time 18.91s (± 0.64%) 18.92s (± 0.71%) ~ 18.81s 19.16s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.38s (± 0.54%) 23.38s (± 0.57%) ~ 23.28s 23.61s p=0.936 n=6
xstate - node (v14.15.1, x64)
Memory used 534,380k (± 0.00%) 534,381k (± 0.00%) ~ 534,359k 534,406k p=1.000 n=6
Parse Time 4.47s (± 1.48%) 4.46s (± 1.51%) ~ 4.40s 4.59s p=0.936 n=6
Bind Time 1.75s (± 3.57%) 1.77s (± 3.02%) ~ 1.66s 1.80s p=0.738 n=6
Check Time 3.11s (± 0.49%) 3.14s (± 0.26%) +0.02s (+ 0.70%) 3.13s 3.15s p=0.015 n=6
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) ~ 0.10s 0.10s p=1.000 n=6
Total Time 9.44s (± 0.26%) 9.47s (± 0.36%) ~ 9.42s 9.51s p=0.107 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53025 6
Baseline main 6

TSServer

Comparison Report - main..53025
Metric main 53025 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,357ms (± 0.64%) 2,372ms (± 0.57%) ~ 2,356ms 2,388ms p=0.109 n=6
Req 2 - geterr 5,308ms (± 0.58%) 5,306ms (± 0.65%) ~ 5,244ms 5,339ms p=1.000 n=6
Req 3 - references 337ms (± 1.06%) 337ms (± 0.35%) ~ 335ms 338ms p=0.935 n=6
Req 4 - navto 285ms (± 0.37%) 285ms (± 0.74%) ~ 283ms 288ms p=0.935 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 77ms (± 3.72%) 75ms (± 5.16%) ~ 71ms 79ms p=0.652 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,506ms (± 1.08%) 2,530ms (± 0.59%) ~ 2,516ms 2,553ms p=0.093 n=6
Req 2 - geterr 3,996ms (± 0.81%) 3,988ms (± 0.45%) ~ 3,956ms 4,008ms p=0.630 n=6
Req 3 - references 352ms (± 0.95%) 352ms (± 0.44%) ~ 349ms 353ms p=0.797 n=6
Req 4 - navto 293ms (± 0.41%) 292ms (± 0.74%) ~ 290ms 296ms p=0.568 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 67ms (± 1.21%) 68ms (± 1.21%) ~ 67ms 69ms p=0.666 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,151ms (± 0.65%) 3,168ms (± 0.66%) ~ 3,140ms 3,196ms p=0.298 n=6
Req 2 - geterr 1,611ms (± 0.36%) 1,614ms (± 0.82%) ~ 1,603ms 1,639ms p=0.936 n=6
Req 3 - references 104ms (± 1.96%) 105ms (± 1.90%) ~ 103ms 108ms p=0.564 n=6
Req 4 - navto 358ms (± 0.66%) 359ms (± 0.53%) ~ 357ms 362ms p=0.371 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 428ms (± 1.38%) 428ms (± 1.67%) ~ 419ms 437ms p=0.936 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,529ms (± 1.42%) 2,500ms (± 1.49%) ~ 2,446ms 2,536ms p=0.199 n=6
Req 2 - geterr 5,703ms (± 0.43%) 5,700ms (± 0.63%) ~ 5,636ms 5,734ms p=0.810 n=6
Req 3 - references 350ms (± 0.78%) 350ms (± 0.98%) ~ 347ms 355ms p=0.686 n=6
Req 4 - navto 281ms (± 1.28%) 280ms (± 0.90%) ~ 276ms 282ms p=0.561 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 87ms (± 5.72%) 87ms (± 4.57%) ~ 84ms 94ms p=0.413 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,682ms (± 0.29%) 2,676ms (± 0.68%) ~ 2,657ms 2,699ms p=0.630 n=6
Req 2 - geterr 4,337ms (± 0.49%) 4,357ms (± 0.30%) ~ 4,342ms 4,372ms p=0.109 n=6
Req 3 - references 362ms (± 1.09%) 362ms (± 1.05%) ~ 357ms 367ms p=0.872 n=6
Req 4 - navto 289ms (± 1.06%) 288ms (± 1.33%) ~ 284ms 293ms p=0.936 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 73ms (± 0.70%) 75ms (± 2.01%) ~ 73ms 77ms p=0.070 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,330ms (± 0.29%) 3,344ms (± 0.50%) ~ 3,314ms 3,361ms p=0.173 n=6
Req 2 - geterr 1,773ms (± 0.66%) 1,778ms (± 0.63%) ~ 1,760ms 1,792ms p=0.518 n=6
Req 3 - references 111ms (± 2.87%) 112ms (± 1.66%) ~ 109ms 114ms p=0.685 n=6
Req 4 - navto 341ms (± 0.84%) 342ms (± 1.16%) ~ 339ms 350ms p=0.622 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 435ms (± 1.05%) 436ms (± 0.67%) ~ 432ms 440ms p=0.685 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,553ms (± 0.68%) 2,575ms (± 0.56%) +22ms (+ 0.87%) 2,559ms 2,594ms p=0.020 n=6
Req 2 - geterr 6,023ms (± 0.27%) 6,039ms (± 0.58%) ~ 5,988ms 6,080ms p=0.230 n=6
Req 3 - references 367ms (± 1.10%) 367ms (± 1.39%) ~ 360ms 375ms p=0.871 n=6
Req 4 - navto 280ms (± 1.59%) 278ms (± 1.87%) ~ 274ms 285ms p=0.744 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 98ms (± 2.79%) 97ms (± 8.03%) ~ 81ms 101ms p=0.462 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,807ms (± 0.81%) 2,816ms (± 0.17%) ~ 2,810ms 2,823ms p=0.378 n=6
Req 2 - geterr 4,397ms (± 0.34%) 4,439ms (± 2.20%) ~ 4,392ms 4,638ms p=0.172 n=6
Req 3 - references 385ms (± 4.85%) 379ms (± 0.36%) ~ 377ms 380ms p=0.745 n=6
Req 4 - navto 294ms (± 1.36%) 295ms (± 0.48%) ~ 293ms 297ms p=0.870 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 93ms (± 9.51%) 96ms (±10.25%) ~ 82ms 103ms p=0.464 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,643ms (± 0.57%) 3,657ms (± 0.36%) ~ 3,633ms 3,668ms p=0.297 n=6
Req 2 - geterr 1,834ms (± 0.91%) 1,846ms (± 0.84%) ~ 1,826ms 1,863ms p=0.336 n=6
Req 3 - references 129ms (± 3.66%) 129ms (± 3.86%) ~ 124ms 137ms p=1.000 n=6
Req 4 - navto 370ms (± 1.65%) 374ms (± 0.92%) ~ 369ms 378ms p=0.107 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 452ms (± 2.91%) 449ms (± 2.32%) ~ 433ms 461ms p=0.689 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53025 6
Baseline main 6

Startup

Comparison Report - main..53025
Metric main 53025 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.69ms (± 0.20%) 142.83ms (± 0.22%) +0.14ms (+ 0.10%) 142.08ms 146.26ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 227.52ms (± 0.16%) 228.18ms (± 0.21%) +0.66ms (+ 0.29%) 226.83ms 233.04ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 229.91ms (± 0.23%) 230.19ms (± 0.31%) +0.28ms (+ 0.12%) 228.33ms 239.88ms p=0.003 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 210.31ms (± 0.21%) 210.77ms (± 0.27%) +0.46ms (+ 0.22%) 209.23ms 216.27ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53025 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53025/merge:

Everything looks good!

@jakebailey
Copy link
Member Author

I'll wait for #52960 before I merge this just to avoid it immediately breaking. Not sure any other outstanding PRs really deal with null, but that one sure does.

@jakebailey
Copy link
Member Author

#52984 also has null : null in a baseline, I guess we'll see if that gets merged post-design meeting or what.

@jakebailey jakebailey merged commit 3236ac9 into microsoft:main Mar 7, 2023
@jakebailey jakebailey deleted the remove-null-in-baselines branch March 7, 2023 20:03
@jakebailey jakebailey mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakebailey @typescript-bot @DanielRosenwasser