Skip to content

Remove docker and user tests, related infra #53118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Mar 6, 2023

These tests are currently failing because we haven't maintained these baselines.

After microsoft/typescript-error-deltas#101, the error-deltas repo and tasks will contain the full set of user/docker tests, wrapped up in a form that we actually do run and maintain.

Given the above, I think it's time to delete these runners.

Note that this is not RWC. We've already effectively committed to getting rid of RWC for more error deltas as well, but this is a different set of things.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 6, 2023
@weswigham
Copy link
Member

FWIW, you can also remove the DT and test262 runners, since they're even crustier - they've both only ever been invoked by hand, without persistent baseline capture. The DT runner isn't even useful on modern DT because it can't handle // $ExpectError stuff. The test262 runner only ever parsed a test262 folder in the internal repo that's not been run for 8 years. (Which we can then remove, and then maybe we can add the test262 repo to the error deltas repo, so we actually cover parsing it)

@jakebailey
Copy link
Member Author

Great, I'll look into that. For DT, there are also some tasks which involve copying things around, which I assume don't work either for that reason.

I'll try in a follow-up PR if this one looks good.

@jakebailey
Copy link
Member Author

Reading the test262 repo, all of the files are .case, so testing them directly is probably less than trivial. Given we haven't needed them in 8 years... maybe we skip it?

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.case? I think that's the exception, not the rule - I think most of the test inputs of test262 are .js, like this and all we want our test to do is basically ensure we don't crash on parsing them, right? Right.

@jakebailey
Copy link
Member Author

Ah, I was in https://github.com/tc39/test262/tree/main/src. I'll take a look.

@jakebailey jakebailey merged commit 6a39f91 into microsoft:main Mar 7, 2023
@jakebailey jakebailey deleted the remove-user-docker branch March 18, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants