[experiment] Naively make normalizeSlashes a no-op outside of Windows

[jakebailey]

For #44174.

[jakebailey]

@typescript-bot perf test this

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at 5597a9a. You can monitor the build here.

Update: The results are in!

[jakebailey]

@typescript-bot perf test this

[typescript-bot]

Heya @jakebailey, I've started to run the perf test suite on this PR at 8973242. You can monitor the build here.

Update: The results are in!

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 8973242. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 8973242. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 8973242. You can monitor the build here.

Update: The results are in!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53173

Metric	main	53173	Delta	Best	Worst	p-value
Angular - node (v18.10.0, x64)
Memory used	362,608k (± 0.01%)	362,615k (± 0.00%)	~	362,592k	362,631k	p=1.000 n=6
Parse Time	3.39s (± 1.03%)	3.39s (± 0.41%)	~	3.37s	3.40s	p=0.935 n=6
Bind Time	1.13s (± 0.79%)	1.13s (± 0.36%)	~	1.12s	1.13s	p=0.787 n=6
Check Time	8.71s (± 0.70%)	8.68s (± 0.46%)	~	8.62s	8.72s	p=0.469 n=6
Emit Time	7.52s (± 0.96%)	7.44s (± 0.74%)	~	7.38s	7.53s	p=0.107 n=6
Total Time	20.76s (± 0.74%)	20.64s (± 0.39%)	~	20.55s	20.77s	p=0.228 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used	190,936k (± 0.01%)	191,892k (± 1.23%)	~	190,850k	196,695k	p=0.575 n=6
Parse Time	1.50s (± 0.69%)	1.50s (± 0.78%)	~	1.48s	1.51s	p=0.801 n=6
Bind Time	0.77s (± 0.97%)	0.77s (± 0.82%)	~	0.76s	0.78s	p=0.718 n=6
Check Time	9.38s (± 0.78%)	9.41s (± 0.39%)	~	9.36s	9.45s	p=0.687 n=6
Emit Time	2.72s (± 1.22%)	2.73s (± 1.49%)	~	2.70s	2.81s	p=0.935 n=6
Total Time	14.38s (± 0.37%)	14.40s (± 0.26%)	~	14.35s	14.44s	p=0.376 n=6
Monaco - node (v18.10.0, x64)
Memory used	347,460k (± 0.01%)	46,495k (± 0.23%)	🟩-300,965k (-86.62%)	46,358k	46,586k	p=0.005 n=6
Parse Time	2.58s (± 1.09%)	0.46s (± 1.11%)	🟩-2.12s (-82.08%)	0.46s	0.47s	p=0.004 n=6
Bind Time	1.01s (± 0.63%)	0.12s (± 0.00%)	🟩-0.89s (-88.12%)	0.12s	0.12s	p=0.002 n=6
Check Time	7.08s (± 0.46%)	0.66s (± 0.62%)	🟩-6.42s (-90.71%)	0.65s	0.66s	p=0.004 n=6
Emit Time	4.25s (± 0.75%)	0.02s (± 0.00%)	🟩-4.23s (-99.53%)	0.02s	0.02s	p=0.003 n=6
Total Time	14.92s (± 0.52%)	1.27s (± 0.59%)	🟩-13.66s (-91.50%)	1.26s	1.28s	p=0.005 n=6
TFS - node (v18.10.0, x64)
Memory used	300,767k (± 0.01%)	45,993k (± 0.07%)	🟩-254,774k (-84.71%)	45,943k	46,026k	p=0.005 n=6
Parse Time	2.06s (± 1.09%)	0.38s (± 0.00%)	🟩-1.69s (-81.60%)	0.38s	0.38s	p=0.003 n=6
Bind Time	1.14s (± 0.66%)	0.13s (± 0.00%)	🟩-1.01s (-88.61%)	0.13s	0.13s	p=0.003 n=6
Check Time	6.54s (± 0.25%)	0.70s (± 0.58%)	🟩-5.83s (-89.27%)	0.70s	0.71s	p=0.003 n=6
Emit Time	3.88s (± 0.78%)	0.01s (± 0.00%)	🟩-3.87s (-99.74%)	0.01s	0.01s	p=0.003 n=6
Total Time	13.62s (± 0.46%)	1.22s (± 0.33%)	🟩-12.40s (-91.05%)	1.21s	1.22s	p=0.004 n=6
material-ui - node (v18.10.0, x64)
Memory used	477,551k (± 0.02%)	477,497k (± 0.01%)	~	477,411k	477,556k	p=0.261 n=6
Parse Time	2.97s (± 2.01%)	3.00s (± 2.54%)	~	2.92s	3.09s	p=0.571 n=6
Bind Time	1.01s (± 8.06%)	1.00s (±10.10%)	~	0.90s	1.09s	p=0.871 n=6
Check Time	17.22s (± 0.98%)	17.09s (± 1.01%)	~	16.95s	17.38s	p=0.227 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.21s (± 0.81%)	21.08s (± 0.88%)	~	20.94s	21.41s	p=0.296 n=6
xstate - node (v18.10.0, x64)
Memory used	550,416k (± 0.03%)	550,431k (± 0.01%)	~	550,324k	550,549k	p=0.298 n=6
Parse Time	3.79s (± 0.73%)	3.78s (± 0.46%)	~	3.75s	3.80s	p=0.686 n=6
Bind Time	1.69s (± 0.71%)	1.68s (± 0.70%)	~	1.66s	1.69s	p=0.084 n=6
Check Time	2.79s (± 0.63%)	2.77s (± 0.56%)	-0.02s (- 0.84%)	2.75s	2.79s	p=0.036 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=1.000 n=6
Total Time	8.36s (± 0.44%)	8.31s (± 0.29%)	-0.04s (- 0.52%)	8.29s	8.36s	p=0.029 n=6
Angular - node (v16.17.1, x64)
Memory used	361,934k (± 0.01%)	361,952k (± 0.01%)	~	361,930k	361,978k	p=0.128 n=6
Parse Time	3.52s (± 0.34%)	3.53s (± 0.59%)	~	3.50s	3.56s	p=0.933 n=6
Bind Time	1.19s (± 0.69%)	1.18s (± 0.35%)	~	1.17s	1.18s	p=0.056 n=6
Check Time	9.49s (± 0.39%)	9.47s (± 0.39%)	~	9.43s	9.52s	p=0.257 n=6
Emit Time	7.91s (± 0.30%)	7.89s (± 0.70%)	~	7.85s	8.00s	p=0.076 n=6
Total Time	22.12s (± 0.12%)	22.06s (± 0.39%)	~	21.99s	22.21s	p=0.127 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	194,284k (± 0.87%)	192,758k (± 0.03%)	~	192,670k	192,818k	p=0.261 n=6
Parse Time	1.58s (± 1.01%)	1.57s (± 1.42%)	~	1.54s	1.60s	p=0.683 n=6
Bind Time	0.82s (± 0.92%)	0.83s (± 1.25%)	~	0.81s	0.84s	p=0.155 n=6
Check Time	10.14s (± 0.41%)	10.13s (± 0.37%)	~	10.08s	10.17s	p=0.628 n=6
Emit Time	2.99s (± 1.03%)	2.98s (± 0.66%)	~	2.96s	3.01s	p=0.745 n=6
Total Time	15.53s (± 0.26%)	15.51s (± 0.38%)	~	15.43s	15.59s	p=0.518 n=6
Monaco - node (v16.17.1, x64)
Memory used	346,681k (± 0.00%)	45,630k (± 0.11%)	🟩-301,051k (-86.84%)	45,599k	45,730k	p=0.005 n=6
Parse Time	2.73s (± 0.38%)	0.46s (± 1.11%)	🟩-2.27s (-83.05%)	0.46s	0.47s	p=0.004 n=6
Bind Time	1.09s (± 0.47%)	0.14s (± 0.00%)	🟩-0.95s (-87.20%)	0.14s	0.14s	p=0.002 n=6
Check Time	7.74s (± 0.34%)	0.73s (± 0.56%)	🟩-7.01s (-90.55%)	0.73s	0.74s	p=0.004 n=6
Emit Time	4.45s (± 0.70%)	0.02s (±22.11%)	🟩-4.42s (-99.48%)	0.02s	0.03s	p=0.004 n=6
Total Time	16.02s (± 0.20%)	1.36s (± 0.55%)	🟩-14.66s (-91.52%)	1.35s	1.37s	p=0.005 n=6
TFS - node (v16.17.1, x64)
Memory used	300,133k (± 0.01%)	45,196k (± 0.22%)	🟩-254,937k (-84.94%)	45,143k	45,390k	p=0.005 n=6
Parse Time	2.17s (± 0.63%)	0.40s (± 0.00%)	🟩-1.77s (-81.61%)	0.40s	0.40s	p=0.003 n=6
Bind Time	1.24s (± 1.14%)	0.14s (± 4.05%)	🟩-1.10s (-89.11%)	0.13s	0.14s	p=0.004 n=6
Check Time	7.19s (± 0.33%)	0.78s (± 0.52%)	🟩-6.41s (-89.13%)	0.78s	0.79s	p=0.004 n=6
Emit Time	4.35s (± 0.84%)	0.01s (± 0.00%)	🟩-4.34s (-99.77%)	0.01s	0.01s	p=0.003 n=6
Total Time	14.96s (± 0.32%)	1.33s (± 0.61%)	🟩-13.64s (-91.13%)	1.32s	1.34s	p=0.004 n=6
material-ui - node (v16.17.1, x64)
Memory used	476,810k (± 0.01%)	476,824k (± 0.00%)	~	476,805k	476,847k	p=0.077 n=6
Parse Time	3.20s (± 1.36%)	3.23s (± 0.55%)	~	3.20s	3.24s	p=0.511 n=6
Bind Time	0.97s (± 1.65%)	0.97s (± 0.53%)	~	0.96s	0.97s	p=0.931 n=6
Check Time	18.21s (± 1.61%)	18.10s (± 0.31%)	~	18.02s	18.19s	p=0.936 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.39s (± 1.37%)	22.29s (± 0.33%)	~	22.18s	22.40s	p=1.000 n=6
xstate - node (v16.17.1, x64)
Memory used	547,961k (± 0.01%)	548,136k (± 0.03%)	+175k (+ 0.03%)	547,950k	548,339k	p=0.045 n=6
Parse Time	3.95s (± 0.51%)	3.96s (± 0.52%)	~	3.93s	3.99s	p=0.628 n=6
Bind Time	1.79s (± 0.47%)	1.79s (± 0.69%)	~	1.77s	1.80s	p=0.127 n=6
Check Time	3.00s (± 0.60%)	2.98s (± 0.59%)	~	2.97s	3.02s	p=0.142 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	8.83s (± 0.46%)	8.82s (± 0.33%)	~	8.78s	8.85s	p=0.630 n=6
Angular - node (v14.15.1, x64)
Memory used	355,748k (± 0.00%)	355,765k (± 0.01%)	~	355,735k	355,811k	p=0.199 n=6
Parse Time	3.60s (± 0.69%)	3.59s (± 0.59%)	~	3.57s	3.63s	p=0.466 n=6
Bind Time	1.23s (± 0.42%)	1.23s (± 0.84%)	~	1.22s	1.25s	p=0.242 n=6
Check Time	9.79s (± 0.22%)	9.74s (± 0.23%)	-0.05s (- 0.48%)	9.71s	9.78s	p=0.012 n=6
Emit Time	8.37s (± 0.52%)	8.32s (± 0.52%)	~	8.26s	8.38s	p=0.092 n=6
Total Time	22.98s (± 0.26%)	22.89s (± 0.24%)	-0.09s (- 0.41%)	22.79s	22.96s	p=0.020 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used	187,937k (± 0.02%)	187,941k (± 0.02%)	~	187,905k	187,982k	p=0.810 n=6
Parse Time	1.61s (± 0.39%)	1.60s (± 0.65%)	~	1.59s	1.62s	p=0.388 n=6
Bind Time	0.85s (± 0.48%)	0.85s (± 0.61%)	~	0.84s	0.85s	p=0.595 n=6
Check Time	10.21s (± 0.21%)	10.24s (± 0.52%)	~	10.16s	10.29s	p=0.294 n=6
Emit Time	3.13s (± 0.79%)	3.12s (± 0.65%)	~	3.09s	3.15s	p=0.808 n=6
Total Time	15.79s (± 0.15%)	15.81s (± 0.40%)	~	15.71s	15.86s	p=0.376 n=6
Monaco - node (v14.15.1, x64)
Memory used	341,702k (± 0.01%)	43,372k (± 0.00%)	🟩-298,331k (-87.31%)	43,370k	43,373k	p=0.005 n=6
Parse Time	2.84s (± 0.65%)	0.49s (± 1.05%)	🟩-2.35s (-82.64%)	0.49s	0.50s	p=0.004 n=6
Bind Time	1.10s (± 0.68%)	0.17s (± 0.00%)	🟩-0.93s (-84.52%)	0.17s	0.17s	p=0.003 n=6
Check Time	8.12s (± 0.68%)	0.78s (± 0.00%)	🟩-7.34s (-90.39%)	0.78s	0.78s	p=0.003 n=6
Emit Time	4.71s (± 0.94%)	0.03s (± 0.00%)	🟩-4.68s (-99.36%)	0.03s	0.03s	p=0.003 n=6
Total Time	16.78s (± 0.50%)	1.48s (± 0.37%)	🟩-15.30s (-91.21%)	1.47s	1.48s	p=0.004 n=6
TFS - node (v14.15.1, x64)
Memory used	295,226k (± 0.00%)	42,924k (± 0.01%)	🟩-252,302k (-85.46%)	42,919k	42,929k	p=0.005 n=6
Parse Time	2.41s (± 1.41%)	0.44s (± 1.44%)	🟩-1.97s (-81.72%)	0.43s	0.45s	p=0.004 n=6
Bind Time	1.07s (± 0.59%)	0.14s (± 0.00%)	🟩-0.93s (-86.92%)	0.14s	0.14s	p=0.002 n=6
Check Time	7.49s (± 0.40%)	0.82s (± 1.03%)	🟩-6.67s (-89.11%)	0.81s	0.83s	p=0.004 n=6
Emit Time	4.29s (± 0.64%)	0.01s (± 0.00%)	🟩-4.28s (-99.77%)	0.01s	0.01s	p=0.003 n=6
Total Time	15.26s (± 0.42%)	1.41s (± 0.58%)	🟩-13.85s (-90.78%)	1.40s	1.42s	p=0.005 n=6
material-ui - node (v14.15.1, x64)
Memory used	472,427k (± 0.01%)	472,457k (± 0.01%)	~	472,422k	472,487k	p=0.230 n=6
Parse Time	3.35s (± 0.51%)	3.35s (± 0.38%)	~	3.33s	3.36s	p=0.730 n=6
Bind Time	1.00s (± 0.41%)	1.00s (± 0.63%)	~	0.99s	1.01s	p=0.673 n=6
Check Time	19.10s (± 0.80%)	18.94s (± 0.37%)	~	18.85s	19.03s	p=0.077 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	23.46s (± 0.67%)	23.28s (± 0.29%)	~	23.20s	23.35s	p=0.092 n=6
xstate - node (v14.15.1, x64)
Memory used	536,721k (± 0.00%)	536,727k (± 0.00%)	~	536,699k	536,767k	p=0.873 n=6
Parse Time	4.24s (± 1.11%)	4.20s (± 1.54%)	~	4.10s	4.25s	p=0.517 n=6
Bind Time	1.69s (± 2.23%)	1.69s (± 2.60%)	~	1.66s	1.75s	p=0.284 n=6
Check Time	3.19s (± 0.76%)	3.17s (± 0.73%)	~	3.15s	3.20s	p=0.520 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	9.21s (± 0.23%)	9.16s (± 0.39%)	-0.05s (- 0.56%)	9.11s	9.21s	p=0.020 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	53173	6
Baseline	main	6

TSServer

Comparison Report - main..53173

Metric	main	53173	Delta	Best	Worst	p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,390ms (± 0.67%)	2,381ms (± 0.71%)	~	2,355ms	2,408ms	p=0.468 n=6
Req 2 - geterr	5,366ms (± 0.35%)	5,356ms (± 0.76%)	~	5,296ms	5,408ms	p=0.936 n=6
Req 3 - references	336ms (± 0.64%)	339ms (± 1.44%)	~	334ms	347ms	p=0.227 n=6
Req 4 - navto	280ms (± 0.73%)	280ms (± 0.59%)	~	277ms	282ms	p=0.514 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	81ms (± 2.63%)	82ms (± 2.73%)	~	78ms	84ms	p=0.316 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,514ms (± 1.38%)	2,519ms (± 0.42%)	~	2,507ms	2,535ms	p=0.689 n=6
Req 2 - geterr	4,006ms (± 0.82%)	4,007ms (± 0.64%)	~	3,983ms	4,046ms	p=0.936 n=6
Req 3 - references	350ms (± 1.72%)	350ms (± 1.15%)	~	344ms	355ms	p=0.687 n=6
Req 4 - navto	293ms (± 0.90%)	291ms (± 0.93%)	~	288ms	294ms	p=0.252 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	78ms (±12.38%)	78ms (± 8.41%)	~	70ms	85ms	p=0.683 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,041ms (± 0.98%)	3,043ms (± 0.36%)	~	3,026ms	3,057ms	p=1.000 n=6
Req 2 - geterr	1,593ms (± 1.27%)	1,586ms (± 0.99%)	~	1,576ms	1,618ms	p=0.470 n=6
Req 3 - references	106ms (± 1.95%)	107ms (± 1.93%)	~	103ms	109ms	p=0.466 n=6
Req 4 - navto	359ms (± 0.72%)	357ms (± 0.53%)	~	355ms	360ms	p=0.145 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	423ms (± 0.98%)	426ms (± 1.95%)	~	410ms	431ms	p=0.147 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,515ms (± 0.80%)	2,510ms (± 0.66%)	~	2,479ms	2,528ms	p=0.575 n=6
Req 2 - geterr	5,741ms (± 0.47%)	5,758ms (± 0.54%)	~	5,722ms	5,809ms	p=0.630 n=6
Req 3 - references	347ms (± 0.54%)	346ms (± 1.20%)	~	342ms	354ms	p=0.366 n=6
Req 4 - navto	278ms (± 0.96%)	279ms (± 1.34%)	~	272ms	283ms	p=0.460 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	73ms (± 0.70%)	74ms (± 0.74%)	~	73ms	74ms	p=0.640 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,699ms (± 0.71%)	2,691ms (± 0.85%)	~	2,673ms	2,731ms	p=0.575 n=6
Req 2 - geterr	4,365ms (± 0.49%)	4,361ms (± 0.21%)	~	4,351ms	4,377ms	p=0.688 n=6
Req 3 - references	358ms (± 0.58%)	362ms (± 1.41%)	~	355ms	368ms	p=0.126 n=6
Req 4 - navto	290ms (± 0.89%)	289ms (± 0.84%)	~	285ms	291ms	p=0.867 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	75ms (± 5.05%)	75ms (± 3.42%)	~	72ms	80ms	p=0.933 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,178ms (± 0.64%)	3,175ms (± 0.46%)	~	3,156ms	3,194ms	p=0.936 n=6
Req 2 - geterr	1,745ms (± 1.12%)	1,738ms (± 0.47%)	~	1,723ms	1,747ms	p=0.575 n=6
Req 3 - references	115ms (± 1.35%)	115ms (± 1.02%)	~	114ms	117ms	p=1.000 n=6
Req 4 - navto	344ms (± 0.66%)	345ms (± 1.10%)	~	340ms	350ms	p=1.000 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	434ms (± 1.21%)	433ms (± 0.84%)	~	426ms	436ms	p=0.685 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,593ms (± 0.77%)	2,605ms (± 0.55%)	~	2,593ms	2,631ms	p=0.422 n=6
Req 2 - geterr	6,134ms (± 0.52%)	6,169ms (± 0.81%)	~	6,117ms	6,252ms	p=0.230 n=6
Req 3 - references	367ms (± 0.90%)	365ms (± 0.79%)	~	361ms	368ms	p=0.625 n=6
Req 4 - navto	278ms (± 0.55%)	282ms (± 1.20%)	+5ms (+ 1.74%)	279ms	287ms	p=0.008 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	102ms (± 1.19%)	96ms (± 5.82%)	🟩-6ms (- 5.90%)	89ms	101ms	p=0.018 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,816ms (± 0.39%)	2,820ms (± 0.75%)	~	2,797ms	2,858ms	p=0.936 n=6
Req 2 - geterr	4,625ms (± 2.64%)	4,622ms (± 2.58%)	~	4,467ms	4,714ms	p=0.936 n=6
Req 3 - references	392ms (± 7.55%)	392ms (± 7.41%)	~	372ms	430ms	p=1.000 n=6
Req 4 - navto	291ms (± 0.67%)	289ms (± 0.75%)	~	286ms	292ms	p=0.193 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	86ms (± 8.41%)	87ms (±10.40%)	~	80ms	100ms	p=0.617 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,506ms (± 0.64%)	3,513ms (± 0.63%)	~	3,485ms	3,539ms	p=0.575 n=6
Req 2 - geterr	1,859ms (± 0.44%)	1,851ms (± 0.75%)	~	1,830ms	1,867ms	p=0.336 n=6
Req 3 - references	125ms (± 1.18%)	126ms (± 0.83%)	~	124ms	127ms	p=0.413 n=6
Req 4 - navto	374ms (± 0.47%)	375ms (± 0.53%)	~	372ms	377ms	p=0.625 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	452ms (± 1.11%)	446ms (± 1.53%)	~	435ms	454ms	p=0.126 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	53173	6
Baseline	main	6

Startup

Comparison Report - main..53173

Metric	main	53173	Delta	Best	Worst	p-value
tsc-startup - node (v16.17.1, x64)
Execution time	141.42ms (± 0.22%)	141.79ms (± 0.24%)	+0.37ms (+ 0.26%)	140.99ms	145.50ms	p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time	226.79ms (± 0.33%)	228.20ms (± 0.37%)	+1.40ms (+ 0.62%)	225.89ms	234.35ms	p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	229.76ms (± 0.34%)	229.71ms (± 0.28%)	~	227.85ms	235.17ms	p=0.867 n=600
typescript-startup - node (v16.17.1, x64)
Execution time	210.64ms (± 0.33%)	209.99ms (± 0.27%)	-0.64ms (- 0.30%)	208.68ms	216.57ms	p=0.000 n=600

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	53173	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53173/merge:

Everything looks good!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53173

Metric	main	53173	Delta	Best	Worst	p-value
Angular - node (v18.10.0, x64)
Memory used	362,608k (± 0.01%)	362,595k (± 0.01%)	~	362,526k	362,630k	p=0.748 n=6
Parse Time	3.39s (± 1.03%)	3.38s (± 1.18%)	~	3.34s	3.44s	p=0.334 n=6
Bind Time	1.13s (± 0.79%)	1.12s (± 0.92%)	~	1.11s	1.14s	p=0.273 n=6
Check Time	8.71s (± 0.70%)	8.66s (± 0.25%)	~	8.63s	8.69s	p=0.107 n=6
Emit Time	7.52s (± 0.96%)	7.42s (± 0.49%)	~	7.38s	7.47s	p=0.053 n=6
Total Time	20.76s (± 0.74%)	20.57s (± 0.23%)	-0.18s (- 0.88%)	20.52s	20.62s	p=0.030 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used	190,936k (± 0.01%)	191,860k (± 1.19%)	~	190,909k	196,513k	p=1.000 n=6
Parse Time	1.50s (± 0.69%)	1.49s (± 1.56%)	~	1.45s	1.52s	p=1.000 n=6
Bind Time	0.77s (± 0.97%)	0.77s (± 1.42%)	~	0.76s	0.79s	p=0.604 n=6
Check Time	9.38s (± 0.78%)	9.37s (± 0.55%)	~	9.28s	9.43s	p=0.624 n=6
Emit Time	2.72s (± 1.22%)	2.73s (± 1.36%)	~	2.69s	2.80s	p=0.566 n=6
Total Time	14.38s (± 0.37%)	14.36s (± 0.50%)	~	14.27s	14.48s	p=0.872 n=6
Monaco - node (v18.10.0, x64)
Memory used	347,460k (± 0.01%)	46,473k (± 0.26%)	🟩-300,987k (-86.62%)	46,348k	46,607k	p=0.005 n=6
Parse Time	2.58s (± 1.09%)	0.46s (± 1.11%)	🟩-2.12s (-82.08%)	0.46s	0.47s	p=0.004 n=6
Bind Time	1.01s (± 0.63%)	0.12s (± 0.00%)	🟩-0.89s (-88.12%)	0.12s	0.12s	p=0.002 n=6
Check Time	7.08s (± 0.46%)	0.66s (± 0.79%)	🟩-6.43s (-90.73%)	0.65s	0.66s	p=0.004 n=6
Emit Time	4.25s (± 0.75%)	0.02s (± 0.00%)	🟩-4.23s (-99.53%)	0.02s	0.02s	p=0.003 n=6
Total Time	14.92s (± 0.52%)	1.27s (± 0.41%)	🟩-13.66s (-91.51%)	1.26s	1.27s	p=0.004 n=6
TFS - node (v18.10.0, x64)
Memory used	300,767k (± 0.01%)	45,973k (± 0.10%)	🟩-254,794k (-84.71%)	45,906k	46,030k	p=0.005 n=6
Parse Time	2.06s (± 1.09%)	0.38s (± 0.00%)	🟩-1.69s (-81.60%)	0.38s	0.38s	p=0.003 n=6
Bind Time	1.14s (± 0.66%)	0.13s (± 0.00%)	🟩-1.01s (-88.61%)	0.13s	0.13s	p=0.003 n=6
Check Time	6.54s (± 0.25%)	0.71s (± 0.78%)	🟩-5.83s (-89.21%)	0.70s	0.71s	p=0.004 n=6
Emit Time	3.88s (± 0.78%)	0.01s (± 0.00%)	🟩-3.87s (-99.74%)	0.01s	0.01s	p=0.003 n=6
Total Time	13.62s (± 0.46%)	1.22s (± 0.62%)	🟩-12.40s (-91.05%)	1.21s	1.23s	p=0.005 n=6
material-ui - node (v18.10.0, x64)
Memory used	477,551k (± 0.02%)	477,595k (± 0.01%)	~	477,562k	477,639k	p=0.066 n=6
Parse Time	2.97s (± 2.01%)	3.06s (± 0.49%)	+0.09s (+ 3.20%)	3.05s	3.09s	p=0.016 n=6
Bind Time	1.01s (± 8.06%)	0.91s (± 0.69%)	🟩-0.10s (-10.05%)	0.90s	0.92s	p=0.049 n=6
Check Time	17.22s (± 0.98%)	17.05s (± 0.58%)	~	16.92s	17.19s	p=0.078 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	21.21s (± 0.81%)	21.03s (± 0.49%)	~	20.88s	21.18s	p=0.078 n=6
xstate - node (v18.10.0, x64)
Memory used	550,416k (± 0.03%)	550,338k (± 0.01%)	~	550,275k	550,434k	p=0.298 n=6
Parse Time	3.79s (± 0.73%)	3.76s (± 0.60%)	-0.03s (- 0.88%)	3.74s	3.80s	p=0.043 n=6
Bind Time	1.69s (± 0.71%)	1.68s (± 0.63%)	-0.02s (- 1.08%)	1.66s	1.69s	p=0.033 n=6
Check Time	2.79s (± 0.63%)	2.77s (± 0.30%)	~	2.77s	2.79s	p=0.055 n=6
Emit Time	0.08s (± 0.00%)	0.08s (± 0.00%)	~	0.08s	0.08s	p=1.000 n=6
Total Time	8.36s (± 0.44%)	8.30s (± 0.24%)	-0.06s (- 0.74%)	8.27s	8.32s	p=0.008 n=6
Angular - node (v16.17.1, x64)
Memory used	361,934k (± 0.01%)	361,929k (± 0.01%)	~	361,907k	361,967k	p=0.689 n=6
Parse Time	3.52s (± 0.34%)	3.50s (± 0.43%)	~	3.49s	3.52s	p=0.059 n=6
Bind Time	1.19s (± 0.69%)	1.18s (± 0.44%)	~	1.18s	1.19s	p=0.523 n=6
Check Time	9.49s (± 0.39%)	9.48s (± 0.45%)	~	9.43s	9.54s	p=0.520 n=6
Emit Time	7.91s (± 0.30%)	7.89s (± 0.28%)	~	7.87s	7.93s	p=0.167 n=6
Total Time	22.12s (± 0.12%)	22.06s (± 0.21%)	~	22.00s	22.11s	p=0.054 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	194,284k (± 0.87%)	193,282k (± 0.70%)	~	192,616k	196,049k	p=0.229 n=6
Parse Time	1.58s (± 1.01%)	1.58s (± 1.04%)	~	1.55s	1.59s	p=0.737 n=6
Bind Time	0.82s (± 0.92%)	0.82s (± 0.77%)	~	0.81s	0.83s	p=0.718 n=6
Check Time	10.14s (± 0.41%)	10.10s (± 0.52%)	~	10.03s	10.16s	p=0.196 n=6
Emit Time	2.99s (± 1.03%)	2.99s (± 0.35%)	~	2.98s	3.01s	p=1.000 n=6
Total Time	15.53s (± 0.26%)	15.49s (± 0.39%)	~	15.39s	15.55s	p=0.148 n=6
Monaco - node (v16.17.1, x64)
Memory used	346,681k (± 0.00%)	45,718k (± 0.23%)	🟩-300,963k (-86.81%)	45,597k	45,840k	p=0.005 n=6
Parse Time	2.73s (± 0.38%)	0.46s (± 0.00%)	🟩-2.27s (-83.17%)	0.46s	0.46s	p=0.003 n=6
Bind Time	1.09s (± 0.47%)	0.14s (± 0.00%)	🟩-0.95s (-87.20%)	0.14s	0.14s	p=0.002 n=6
Check Time	7.74s (± 0.34%)	0.73s (± 0.00%)	🟩-7.01s (-90.57%)	0.73s	0.73s	p=0.003 n=6
Emit Time	4.45s (± 0.70%)	0.02s (±21.89%)	🟩-4.42s (-99.44%)	0.02s	0.03s	p=0.004 n=6
Total Time	16.02s (± 0.20%)	1.35s (± 0.38%)	🟩-14.67s (-91.59%)	1.34s	1.35s	p=0.004 n=6
TFS - node (v16.17.1, x64)
Memory used	300,133k (± 0.01%)	45,184k (± 0.20%)	🟩-254,949k (-84.95%)	45,142k	45,370k	p=0.005 n=6
Parse Time	2.17s (± 0.63%)	0.40s (± 1.30%)	🟩-1.78s (-81.76%)	0.39s	0.40s	p=0.004 n=6
Bind Time	1.24s (± 1.14%)	0.14s (± 4.05%)	🟩-1.10s (-89.11%)	0.13s	0.14s	p=0.004 n=6
Check Time	7.19s (± 0.33%)	0.78s (± 0.52%)	🟩-6.41s (-89.13%)	0.78s	0.79s	p=0.004 n=6
Emit Time	4.35s (± 0.84%)	0.01s (± 0.00%)	🟩-4.34s (-99.77%)	0.01s	0.01s	p=0.003 n=6
Total Time	14.96s (± 0.32%)	1.33s (± 0.41%)	🟩-13.64s (-91.15%)	1.32s	1.33s	p=0.004 n=6
material-ui - node (v16.17.1, x64)
Memory used	476,810k (± 0.01%)	476,854k (± 0.01%)	+45k (+ 0.01%)	476,822k	476,896k	p=0.045 n=6
Parse Time	3.20s (± 1.36%)	3.23s (± 0.47%)	~	3.21s	3.25s	p=0.413 n=6
Bind Time	0.97s (± 1.65%)	0.96s (± 0.42%)	~	0.96s	0.97s	p=0.214 n=6
Check Time	18.21s (± 1.61%)	18.09s (± 0.36%)	~	17.98s	18.15s	p=0.810 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.39s (± 1.37%)	22.28s (± 0.23%)	~	22.19s	22.33s	p=1.000 n=6
xstate - node (v16.17.1, x64)
Memory used	547,961k (± 0.01%)	547,999k (± 0.02%)	~	547,932k	548,200k	p=0.575 n=6
Parse Time	3.95s (± 0.51%)	3.94s (± 0.26%)	~	3.93s	3.96s	p=0.519 n=6
Bind Time	1.79s (± 0.47%)	1.79s (± 0.23%)	~	1.79s	1.80s	p=0.285 n=6
Check Time	3.00s (± 0.60%)	2.98s (± 0.46%)	-0.02s (- 0.78%)	2.96s	3.00s	p=0.039 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	8.83s (± 0.46%)	8.80s (± 0.23%)	~	8.77s	8.82s	p=0.226 n=6
Angular - node (v14.15.1, x64)
Memory used	355,748k (± 0.00%)	355,756k (± 0.01%)	~	355,734k	355,788k	p=0.748 n=6
Parse Time	3.60s (± 0.69%)	3.57s (± 0.28%)	-0.03s (- 0.93%)	3.56s	3.58s	p=0.015 n=6
Bind Time	1.23s (± 0.42%)	1.22s (± 0.45%)	~	1.22s	1.23s	p=0.640 n=6
Check Time	9.79s (± 0.22%)	9.75s (± 0.63%)	~	9.67s	9.84s	p=0.199 n=6
Emit Time	8.37s (± 0.52%)	8.31s (± 0.71%)	~	8.24s	8.39s	p=0.227 n=6
Total Time	22.98s (± 0.26%)	22.85s (± 0.46%)	~	22.75s	23.01s	p=0.077 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used	187,937k (± 0.02%)	187,947k (± 0.02%)	~	187,911k	187,996k	p=0.575 n=6
Parse Time	1.61s (± 0.39%)	1.60s (± 0.61%)	~	1.59s	1.61s	p=0.058 n=6
Bind Time	0.85s (± 0.48%)	0.85s (± 0.61%)	~	0.84s	0.85s	p=0.595 n=6
Check Time	10.21s (± 0.21%)	10.18s (± 0.58%)	~	10.10s	10.25s	p=0.572 n=6
Emit Time	3.13s (± 0.79%)	3.10s (± 0.64%)	~	3.07s	3.12s	p=0.086 n=6
Total Time	15.79s (± 0.15%)	15.73s (± 0.41%)	~	15.65s	15.82s	p=0.063 n=6
Monaco - node (v14.15.1, x64)
Memory used	341,702k (± 0.01%)	43,369k (± 0.00%)	🟩-298,333k (-87.31%)	43,367k	43,371k	p=0.005 n=6
Parse Time	2.84s (± 0.65%)	0.49s (± 1.05%)	🟩-2.35s (-82.64%)	0.49s	0.50s	p=0.004 n=6
Bind Time	1.10s (± 0.68%)	0.17s (± 0.00%)	🟩-0.93s (-84.52%)	0.17s	0.17s	p=0.003 n=6
Check Time	8.12s (± 0.68%)	0.78s (± 0.52%)	🟩-7.34s (-90.37%)	0.78s	0.79s	p=0.004 n=6
Emit Time	4.71s (± 0.94%)	0.03s (± 0.00%)	🟩-4.68s (-99.36%)	0.03s	0.03s	p=0.003 n=6
Total Time	16.78s (± 0.50%)	1.48s (± 0.35%)	🟩-15.30s (-91.20%)	1.47s	1.48s	p=0.004 n=6
TFS - node (v14.15.1, x64)
Memory used	295,226k (± 0.00%)	42,923k (± 0.00%)	🟩-252,303k (-85.46%)	42,922k	42,924k	p=0.004 n=6
Parse Time	2.41s (± 1.41%)	0.44s (± 0.00%)	🟩-1.97s (-81.72%)	0.44s	0.44s	p=0.003 n=6
Bind Time	1.07s (± 0.59%)	0.14s (± 0.00%)	🟩-0.93s (-86.92%)	0.14s	0.14s	p=0.002 n=6
Check Time	7.49s (± 0.40%)	0.82s (± 1.03%)	🟩-6.67s (-89.11%)	0.81s	0.83s	p=0.004 n=6
Emit Time	4.29s (± 0.64%)	0.01s (± 0.00%)	🟩-4.28s (-99.77%)	0.01s	0.01s	p=0.003 n=6
Total Time	15.26s (± 0.42%)	1.41s (± 0.59%)	🟩-13.85s (-90.79%)	1.40s	1.42s	p=0.004 n=6
material-ui - node (v14.15.1, x64)
Memory used	472,427k (± 0.01%)	472,452k (± 0.01%)	~	472,408k	472,487k	p=0.298 n=6
Parse Time	3.35s (± 0.51%)	3.34s (± 0.58%)	~	3.32s	3.37s	p=0.454 n=6
Bind Time	1.00s (± 0.41%)	1.00s (± 1.03%)	~	0.99s	1.02s	p=0.924 n=6
Check Time	19.10s (± 0.80%)	19.04s (± 0.87%)	~	18.91s	19.37s	p=0.630 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	23.46s (± 0.67%)	23.38s (± 0.78%)	~	23.23s	23.74s	p=0.471 n=6
xstate - node (v14.15.1, x64)
Memory used	536,721k (± 0.00%)	536,729k (± 0.01%)	~	536,673k	536,767k	p=0.471 n=6
Parse Time	4.24s (± 1.11%)	4.24s (± 0.67%)	~	4.21s	4.27s	p=0.808 n=6
Bind Time	1.69s (± 2.23%)	1.67s (± 0.50%)	-0.03s (- 1.67%)	1.65s	1.67s	p=0.009 n=6
Check Time	3.19s (± 0.76%)	3.17s (± 0.96%)	~	3.13s	3.21s	p=0.469 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	9.21s (± 0.23%)	9.17s (± 0.39%)	~	9.13s	9.23s	p=0.054 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Angular - node (v18.10.0, x64)
• Angular - node (v16.17.1, x64)
• Angular - node (v14.15.1, x64)
• Compiler-Unions - node (v18.10.0, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Compiler-Unions - node (v14.15.1, x64)
• Monaco - node (v18.10.0, x64)
• Monaco - node (v16.17.1, x64)
• Monaco - node (v14.15.1, x64)
• TFS - node (v18.10.0, x64)
• TFS - node (v16.17.1, x64)
• TFS - node (v14.15.1, x64)
• material-ui - node (v18.10.0, x64)
• material-ui - node (v16.17.1, x64)
• material-ui - node (v14.15.1, x64)
• xstate - node (v18.10.0, x64)
• xstate - node (v16.17.1, x64)
• xstate - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	53173	6
Baseline	main	6

TSServer

Comparison Report - main..53173

Metric	main	53173	Delta	Best	Worst	p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,390ms (± 0.67%)	2,388ms (± 0.48%)	~	2,374ms	2,403ms	p=0.748 n=6
Req 2 - geterr	5,366ms (± 0.35%)	5,358ms (± 0.48%)	~	5,319ms	5,386ms	p=1.000 n=6
Req 3 - references	336ms (± 0.64%)	339ms (± 1.24%)	~	335ms	345ms	p=0.169 n=6
Req 4 - navto	280ms (± 0.73%)	280ms (± 0.39%)	~	279ms	282ms	p=0.742 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	81ms (± 2.63%)	81ms (± 4.38%)	~	77ms	85ms	p=1.000 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	2,514ms (± 1.38%)	2,511ms (± 0.85%)	~	2,474ms	2,532ms	p=1.000 n=6
Req 2 - geterr	4,006ms (± 0.82%)	4,006ms (± 0.60%)	~	3,969ms	4,030ms	p=1.000 n=6
Req 3 - references	350ms (± 1.72%)	353ms (± 0.61%)	~	350ms	356ms	p=0.686 n=6
Req 4 - navto	293ms (± 0.90%)	292ms (± 0.60%)	~	290ms	295ms	p=0.517 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	78ms (±12.38%)	81ms (± 2.74%)	~	79ms	84ms	p=1.000 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen	3,041ms (± 0.98%)	3,038ms (± 0.77%)	~	3,014ms	3,074ms	p=1.000 n=6
Req 2 - geterr	1,593ms (± 1.27%)	1,589ms (± 0.79%)	~	1,576ms	1,603ms	p=0.574 n=6
Req 3 - references	106ms (± 1.95%)	107ms (± 1.45%)	~	106ms	109ms	p=0.211 n=6
Req 4 - navto	359ms (± 0.72%)	358ms (± 0.52%)	~	355ms	360ms	p=0.226 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	423ms (± 0.98%)	424ms (± 0.71%)	~	420ms	429ms	p=0.519 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,515ms (± 0.80%)	2,526ms (± 0.89%)	~	2,496ms	2,542ms	p=0.296 n=6
Req 2 - geterr	5,741ms (± 0.47%)	5,740ms (± 0.53%)	~	5,702ms	5,780ms	p=0.936 n=6
Req 3 - references	347ms (± 0.54%)	347ms (± 0.51%)	~	343ms	348ms	p=0.669 n=6
Req 4 - navto	278ms (± 0.96%)	280ms (± 0.54%)	~	278ms	282ms	p=0.459 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	73ms (± 0.70%)	74ms (± 1.02%)	~	73ms	75ms	p=0.247 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	2,699ms (± 0.71%)	2,692ms (± 1.22%)	~	2,639ms	2,731ms	p=0.688 n=6
Req 2 - geterr	4,365ms (± 0.49%)	4,369ms (± 0.51%)	~	4,344ms	4,399ms	p=0.688 n=6
Req 3 - references	358ms (± 0.58%)	359ms (± 0.55%)	~	357ms	361ms	p=0.617 n=6
Req 4 - navto	290ms (± 0.89%)	292ms (± 0.36%)	~	290ms	293ms	p=0.139 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	75ms (± 5.05%)	74ms (± 3.99%)	~	68ms	76ms	p=0.511 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen	3,178ms (± 0.64%)	3,172ms (± 0.45%)	~	3,155ms	3,194ms	p=0.810 n=6
Req 2 - geterr	1,745ms (± 1.12%)	1,748ms (± 0.52%)	~	1,734ms	1,758ms	p=0.521 n=6
Req 3 - references	115ms (± 1.35%)	115ms (± 1.95%)	~	112ms	117ms	p=0.680 n=6
Req 4 - navto	344ms (± 0.66%)	342ms (± 0.41%)	~	340ms	344ms	p=0.120 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	434ms (± 1.21%)	431ms (± 0.93%)	~	427ms	437ms	p=0.466 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,593ms (± 0.77%)	2,598ms (± 0.49%)	~	2,574ms	2,612ms	p=0.574 n=6
Req 2 - geterr	6,134ms (± 0.52%)	6,161ms (± 0.26%)	~	6,136ms	6,183ms	p=0.128 n=6
Req 3 - references	367ms (± 0.90%)	362ms (± 0.46%)	-5ms (- 1.32%)	360ms	364ms	p=0.016 n=6
Req 4 - navto	278ms (± 0.55%)	282ms (± 1.66%)	~	276ms	287ms	p=0.224 n=6
Req 5 - completionInfo count	1,356 (± 0.00%)	1,356 (± 0.00%)	~	1,356	1,356	p=1.000 n=6
Req 5 - completionInfo	102ms (± 1.19%)	96ms (± 7.12%)	~	89ms	103ms	p=0.162 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	2,816ms (± 0.39%)	2,817ms (± 0.40%)	~	2,795ms	2,826ms	p=1.000 n=6
Req 2 - geterr	4,625ms (± 2.64%)	4,539ms (± 2.51%)	~	4,455ms	4,700ms	p=0.230 n=6
Req 3 - references	392ms (± 7.55%)	390ms (± 7.49%)	~	369ms	428ms	p=0.418 n=6
Req 4 - navto	291ms (± 0.67%)	291ms (± 1.28%)	~	285ms	295ms	p=0.871 n=6
Req 5 - completionInfo count	1,518 (± 0.00%)	1,518 (± 0.00%)	~	1,518	1,518	p=1.000 n=6
Req 5 - completionInfo	86ms (± 8.41%)	91ms (±10.72%)	~	81ms	101ms	p=0.413 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen	3,506ms (± 0.64%)	3,492ms (± 0.45%)	~	3,467ms	3,510ms	p=0.261 n=6
Req 2 - geterr	1,859ms (± 0.44%)	1,830ms (± 0.83%)	-29ms (- 1.58%)	1,820ms	1,860ms	p=0.020 n=6
Req 3 - references	125ms (± 1.18%)	124ms (± 1.29%)	~	122ms	126ms	p=0.511 n=6
Req 4 - navto	374ms (± 0.47%)	375ms (± 0.90%)	~	371ms	381ms	p=0.366 n=6
Req 5 - completionInfo count	3,136 (± 0.00%)	3,136 (± 0.00%)	~	3,136	3,136	p=1.000 n=6
Req 5 - completionInfo	452ms (± 1.11%)	442ms (± 2.18%)	~	431ms	457ms	p=0.126 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v18.10.0, x64)
• node (v16.17.1, x64)
• node (v14.15.1, x64)

Scenarios

• Compiler-UnionsTSServer - node (v18.10.0, x64)
• Compiler-UnionsTSServer - node (v16.17.1, x64)
• Compiler-UnionsTSServer - node (v14.15.1, x64)
• CompilerTSServer - node (v18.10.0, x64)
• CompilerTSServer - node (v16.17.1, x64)
• CompilerTSServer - node (v14.15.1, x64)
• xstateTSServer - node (v18.10.0, x64)
• xstateTSServer - node (v16.17.1, x64)
• xstateTSServer - node (v14.15.1, x64)

Benchmark	Name	Iterations
Current	53173	6
Baseline	main	6

Startup

Comparison Report - main..53173

Metric	main	53173	Delta	Best	Worst	p-value
tsc-startup - node (v16.17.1, x64)
Execution time	141.42ms (± 0.22%)	141.60ms (± 0.18%)	+0.18ms (+ 0.13%)	140.94ms	144.95ms	p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time	226.79ms (± 0.33%)	227.01ms (± 0.19%)	+0.22ms (+ 0.10%)	225.88ms	231.93ms	p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time	229.76ms (± 0.34%)	229.70ms (± 0.30%)	~	227.93ms	237.52ms	p=0.895 n=600
typescript-startup - node (v16.17.1, x64)
Execution time	210.64ms (± 0.33%)	210.54ms (± 0.30%)	~	208.66ms	215.87ms	p=0.119 n=600

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• tsc-startup - node (v16.17.1, x64)
• tsserver-startup - node (v16.17.1, x64)
• tsserverlibrary-startup - node (v16.17.1, x64)
• typescript-startup - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	53173	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53173/merge:

Everything looks good!

[jakebailey]

@typescript-bot test this

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 8973242. You can monitor the build here.

[jakebailey]

Potentially less noisy --predictable run:

Details

Loading benchmark and comparing to baseline.
Comparison Report - main..HEAD

Metric	main	HEAD	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	293,658k (± 0.00%)	293,661k (± 0.00%)	+3k (+ 0.00%)	293,661k	293,662k	p=0.003 n=6
Parse Time	3.27s (± 2.57%)	3.20s (± 0.28%)	-0.07s (- 2.09%)	3.19s	3.21s	p=0.004 n=6
Bind Time	1.36s (± 0.30%)	1.33s (± 0.00%)	-0.03s (- 2.09%)	1.33s	1.33s	p=0.002 n=6
Check Time	10.25s (± 0.07%)	10.21s (± 0.07%)	-0.04s (- 0.36%)	10.20s	10.22s	p=0.004 n=6
Emit Time	8.82s (± 0.35%)	8.82s (± 0.25%)	~	8.80s	8.86s	p=1.000 n=6
Total Time	23.70s (± 0.38%)	23.56s (± 0.10%)	-0.14s (- 0.58%)	23.54s	23.59s	p=0.005 n=6
Compiler - node (v16.17.1, x64)
Memory used	174,124k (± 0.00%)	173,891k (± 0.00%)	-233k (- 0.13%)	173,888k	173,908k	p=0.003 n=6
Parse Time	2.03s (± 1.18%)	2.00s (± 0.27%)	-0.03s (- 1.31%)	2.00s	2.01s	p=0.004 n=6
Bind Time	0.94s (± 0.00%)	0.93s (± 0.44%)	-0.01s (- 0.89%)	0.93s	0.94s	p=0.007 n=6
Check Time	9.02s (± 0.09%)	9.01s (± 0.11%)	~	9.00s	9.03s	p=0.065 n=6
Emit Time	3.81s (± 0.14%)	3.78s (± 0.62%)	~	3.77s	3.83s	p=0.059 n=6
Total Time	15.80s (± 0.13%)	15.74s (± 0.15%)	-0.07s (- 0.43%)	15.71s	15.78s	p=0.006 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,626k (± 0.01%)	192,568k (± 0.03%)	-58k (- 0.03%)	192,543k	192,693k	p=0.047 n=6
Parse Time	1.81s (± 0.75%)	1.79s (± 0.23%)	-0.02s (- 1.19%)	1.79s	1.80s	p=0.004 n=6
Bind Time	0.91s (± 0.45%)	0.91s (± 0.00%)	~	0.91s	0.91s	p=0.405 n=6
Check Time	10.98s (± 0.09%)	10.95s (± 0.05%)	-0.04s (- 0.35%)	10.94s	10.95s	p=0.004 n=6
Emit Time	3.77s (± 0.35%)	3.75s (± 0.55%)	~	3.73s	3.78s	p=0.073 n=6
Total Time	17.48s (± 0.09%)	17.39s (± 0.13%)	-0.10s (- 0.55%)	17.36s	17.42s	p=0.005 n=6
Monaco - node (v16.17.1, x64)
Memory used	346,608k (± 0.00%)	45,548k (± 0.00%)	🟩-301,061k (-86.86%)	45,545k	45,548k	p=0.002 n=6
Parse Time	2.97s (± 3.40%)	0.53s (± 1.04%)	🟩-2.45s (-82.34%)	0.52s	0.53s	p=0.004 n=6
Bind Time	1.47s (± 0.00%)	0.18s (± 0.00%)	🟩-1.29s (-87.76%)	0.18s	0.18s	p=0.001 n=6
Check Time	8.82s (± 0.09%)	0.88s (± 0.00%)	🟩-7.94s (-90.02%)	0.88s	0.88s	p=0.003 n=6
Emit Time	5.05s (± 0.10%)	0.03s (± 0.00%)	🟩-5.02s (-99.41%)	0.03s	0.03s	p=0.002 n=6
Total Time	18.31s (± 0.58%)	1.61s (± 0.32%)	🟩-16.70s (-91.19%)	1.61s	1.62s	p=0.004 n=6
TFS - node (v16.17.1, x64)
Memory used	299,674k (± 0.00%)	45,136k (± 0.00%)	🟩-254,538k (-84.94%)	45,133k	45,136k	p=0.003 n=6
Parse Time	2.60s (± 1.60%)	0.46s (± 1.11%)	🟩-2.13s (-82.17%)	0.46s	0.47s	p=0.004 n=6
Bind Time	1.12s (± 0.88%)	0.16s (± 0.00%)	🟩-0.96s (-85.69%)	0.16s	0.16s	p=0.003 n=6
Check Time	8.57s (± 0.20%)	0.93s (± 0.00%)	🟩-7.64s (-89.15%)	0.93s	0.93s	p=0.003 n=6
Emit Time	5.46s (± 0.27%)	0.01s (± 0.00%)	🟩-5.45s (-99.82%)	0.01s	0.01s	p=0.003 n=6
Total Time	17.75s (± 0.29%)	1.57s (± 0.35%)	🟩-16.18s (-91.18%)	1.56s	1.57s	p=0.004 n=6
material-ui - node (v16.17.1, x64)
Memory used	473,229k (± 0.00%)	473,260k (± 0.00%)	+31k (+ 0.01%)	473,260k	473,260k	p=0.001 n=6
Parse Time	3.39s (± 2.53%)	3.36s (± 0.00%)	-0.03s (- 0.74%)	3.36s	3.36s	p=0.040 n=6
Bind Time	1.11s (± 0.00%)	1.10s (± 0.47%)	-0.01s (- 0.60%)	1.10s	1.11s	p=0.025 n=6
Check Time	20.84s (± 0.21%)	20.81s (± 0.07%)	~	20.79s	20.83s	p=0.372 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	25.34s (± 0.47%)	25.27s (± 0.06%)	~	25.25s	25.29s	p=0.513 n=6
xstate - node (v16.17.1, x64)
Memory used	528,112k (± 0.00%)	528,093k (± 0.00%)	-19k (- 0.00%)	528,093k	528,093k	p=0.001 n=6
Parse Time	4.32s (± 0.68%)	4.29s (± 0.10%)	-0.02s (- 0.58%)	4.29s	4.30s	p=0.025 n=6
Bind Time	1.58s (± 0.40%)	1.58s (± 0.00%)	~	1.58s	1.58s	p=1.000 n=6
Check Time	3.64s (± 0.14%)	3.65s (± 0.11%)	~	3.64s	3.65s	p=0.112 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	9.63s (± 0.33%)	9.61s (± 0.07%)	~	9.60s	9.62s	p=0.180 n=6

System

Machine Name	elcheapo
Platform	linux 6.2.2-arch1-1
Architecture	x64
Available Memory	8 GB
Available Memory	7 GB
CPUs	6 × Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	HEAD	6
Baseline	main	6

It's maybe 1-2 percent at parse time? Given the regular runner sees no change, maybe there's no benefit to this anymore now that this function is optimized via #44100 and #50154?

[jakebailey]

@typescript-bot test this

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 8973242. You can monitor the build here.

[jakebailey]

@typescript-bot test this

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 8973242. You can monitor the build here.

[jakebailey]

@typescript-bot test this

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 8973242. You can monitor the build here.

[jakebailey]

@typescript-bot test this

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 8973242. You can monitor the build here.

[dmichon-msft]

What OS does the perf suite run on?
Also, do you know what's causing that implausibly large impact on the Monaco and TFS test suites?

[jakebailey]

OS is Linux, a recent version of Ubuntu, which is the OS we'd want to test for this kind of change.

The implausible perf change is from those projects using the wrong kinds of slashes, e.g. monaco has a file like this:

/// <reference path="lib.d.ts" />
/// <reference path="client\extlib.d.ts" />
/// <reference path="client\vs\base\arrays.ts" />
/// <reference path="client\vs\base\assert.ts" />
/// <reference path="client\vs\base\async.ts" />
/// <reference path="client\vs\base\cookiesUtil.ts" />
/// <reference path="client\vs\base\diagnostics.ts" />
/// <reference path="client\vs\base\env.ts" />
// ...

So it's not actually type checking these files because it didn't find them. And, this is also the sort of thing we probably don't want to be breaking.

[ehoogeveen-medweb]

I'm a bit surprised that works at all. For example, I'd expect client\vs\base\arrays.ts to be interpreted as client\u000bs\u0008asearrays.ts or similar.

[jakebailey]

I'm not super surprised given those comments are effectively XML which has different escape rules.

But, I also doubt anyone is using these slashes in real codebases these days either.