Don't mention all the possible return types that permit no return statements #53560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
jakebailey
reviewed
Mar 28, 2023
| @@ -3619,7 +3615,7 @@ | |||
| "category": "Error", | |||
| "code": 2846 | |||
| }, | |||
| "A function whose declared type is neither 'undefined', 'void', nor 'any' must return a value.": { | |||
| "A function with this return type needs to explicitly return a value.": { | |||
There was a problem hiding this comment.
"must explicitly"? (Not sure what form we use most often)
There was a problem hiding this comment.
Let's pretend we're starting from scratch. What would you prefer to see as a user?
There was a problem hiding this comment.
I like this diagnostic, but I might be a bit confused when the return type is inferred. That's unrelated to the message per se though.
There was a problem hiding this comment.
Can we do something like A function with return type 'X' needs to explicitly return a value.? I think this would help with Maria's point about when the return type is inferred.
MariaSolOs
approved these changes
Mar 28, 2023
|
Do we still want to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53559.