Skip to content

resolve path to fileDir before traversing it searching node_modules #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

uwinkelvos
Copy link

fixes: #5102

@msftclas
Copy link

Hi @uwinkelvos, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@uwinkelvos
Copy link
Author

i'll take a look at the test errors later.

@mhegazy
Copy link
Contributor

mhegazy commented Oct 27, 2015

@vladima had a fix for this that takes care of the failing tests. @vladima is this ready?

@mhegazy
Copy link
Contributor

mhegazy commented Oct 27, 2015

Thanks for the PR. #5275 should handle this case.

@mhegazy mhegazy closed this Oct 27, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js-like module resolution doesn't follow parent paths
3 participants