Display write type for property accesses in write locations #54777

Andarist · 2023-06-26T10:31:32Z

jakebailey · 2023-06-28T17:48:09Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-06-28T17:48:11Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 7a755d2. You can monitor the build here.

typescript-bot · 2023-06-28T17:48:11Z

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-28T17:48:11Z

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-28T17:48:11Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-28T17:48:11Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-28T17:48:11Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 7a755d2. You can monitor the build here.

typescript-bot · 2023-06-28T17:48:11Z

Heya @jakebailey, I've started to run the perf test suite on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-28T17:48:11Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 7a755d2. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-28T17:50:07Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155726/artifacts?artifactName=tgz&fileId=A69E37B9212D62DCD67B1D2B07773EE71184B62F0341BD915A86B2842E31D65B02&fileName=/typescript-5.2.0-insiders.20230628.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2023-06-28T18:08:28Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/54777/merge:

Everything looks good!

typescript-bot · 2023-06-28T18:22:59Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/54777/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-54777/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-06-28T19:11:53Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54777

_Metric	_main	₅₄₇₇₇	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{366,753k (± 0.01%)}	_{366,716k (± 0.01%)}	_~	_366,691k	_366,756k	_{p=0.199 n=6}
_{Parse Time}	_{3.46s (± 0.60%)}	_{3.41s (± 1.10%)}	_~	_3.37s	_3.47s	_{p=0.054 n=6}
_{Bind Time}	_{1.12s (± 0.67%)}	_{1.12s (± 0.49%)}	_~	_1.11s	_1.12s	_{p=0.137 n=6}
_{Check Time}	_{8.88s (± 0.44%)}	_{8.88s (± 0.51%)}	_~	_8.82s	_8.93s	_{p=0.809 n=6}
_{Emit Time}	_{7.54s (± 0.90%)}	_{7.56s (± 0.79%)}	_~	_7.44s	_7.60s	_{p=0.936 n=6}
_{Total Time}	_{21.00s (± 0.52%)}	_{20.96s (± 0.52%)}	_~	_20.79s	_21.07s	_{p=0.688 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{193,823k (± 1.63%)}	_{190,978k (± 0.01%)}	_~	_190,952k	_191,020k	_{p=0.575 n=6}
_{Parse Time}	_{1.50s (± 0.91%)}	_{1.51s (± 0.70%)}	_~	_1.49s	_1.52s	_{p=1.000 n=6}
_{Bind Time}	_{0.77s (± 0.00%)}	_{0.77s (± 1.28%)}	_~	_0.76s	_0.78s	_{p=0.652 n=6}
_{Check Time}	_{9.49s (± 0.82%)}	_{9.43s (± 0.37%)}	_~	_9.39s	_9.48s	_{p=0.065 n=6}
_{Emit Time}	_{2.76s (± 0.68%)}	_{2.76s (± 0.72%)}	_~	_2.72s	_2.78s	_{p=1.000 n=6}
_{Total Time}	_{14.52s (± 0.45%)}	_{14.46s (± 0.32%)}	_~	_14.40s	_14.54s	_{p=0.108 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,806k (± 0.01%)}	_{346,810k (± 0.01%)}	_~	_346,776k	_346,830k	_{p=0.936 n=6}
_{Parse Time}	_{2.60s (± 0.97%)}	_{2.60s (± 1.22%)}	_~	_2.55s	_2.65s	_{p=0.935 n=6}
_{Bind Time}	_{1.01s (± 1.25%)}	_{1.01s (± 1.46%)}	_~	_0.99s	_1.03s	_{p=0.802 n=6}
_{Check Time}	_{7.22s (± 0.48%)}	_{7.18s (± 0.53%)}	_~	_7.13s	_7.23s	_{p=0.064 n=6}
_{Emit Time}	_{4.26s (± 1.01%)}	_{4.26s (± 0.41%)}	_~	_4.23s	_4.27s	_{p=0.685 n=6}
_{Total Time}	_{15.10s (± 0.64%)}	_{15.04s (± 0.20%)}	_~	_15.00s	_15.08s	_{p=0.230 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,881k (± 0.01%)}	_{300,861k (± 0.00%)}	_~	_300,840k	_300,874k	_{p=0.065 n=6}
_{Parse Time}	_{2.09s (± 1.16%)}	_{2.06s (± 0.94%)}	_~	_2.03s	_2.08s	_{p=0.062 n=6}
_{Bind Time}	_{1.14s (± 0.73%)}	_{1.14s (± 0.72%)}	_~	_1.13s	_1.15s	_{p=0.120 n=6}
_{Check Time}	_{6.68s (± 0.21%)}	_{6.61s (± 0.46%)}	_{-0.07s (- 1.05%)}	_6.58s	_6.65s	_{p=0.005 n=6}
_{Emit Time}	_{3.86s (± 0.69%)}	_{3.86s (± 1.00%)}	_~	_3.83s	_3.93s	_{p=0.625 n=6}
_{Total Time}	_{13.78s (± 0.20%)}	_{13.67s (± 0.37%)}	_{-0.11s (- 0.82%)}	_13.59s	_13.74s	_{p=0.005 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{482,455k (± 0.01%)}	_{482,428k (± 0.01%)}	_~	_482,394k	_482,499k	_{p=0.173 n=6}
_{Parse Time}	_{3.13s (± 0.44%)}	_{3.11s (± 0.56%)}	_{-0.03s (- 0.90%)}	_3.09s	_3.14s	_{p=0.034 n=6}
_{Bind Time}	_{0.92s (± 1.44%)}	_{0.92s (± 1.31%)}	_~	_0.91s	_0.94s	_{p=0.931 n=6}
_{Check Time}	_{17.44s (± 0.43%)}	_{17.26s (± 0.47%)}	_{-0.18s (- 1.03%)}	_17.17s	_17.36s	_{p=0.008 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.50s (± 0.38%)}	_{21.29s (± 0.43%)}	_{-0.21s (- 0.95%)}	_21.20s	_21.42s	_{p=0.006 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{563,567k (± 0.02%)}	_{563,504k (± 0.01%)}	_~	_563,448k	_563,639k	_{p=0.173 n=6}
_{Parse Time}	_{3.85s (± 0.75%)}	_{3.85s (± 0.54%)}	_~	_3.82s	_3.87s	_{p=0.936 n=6}
_{Bind Time}	_{1.64s (± 0.50%)}	_{1.64s (± 0.64%)}	_~	_1.63s	_1.66s	_{p=1.000 n=6}
_{Check Time}	_{2.80s (± 0.93%)}	_{2.79s (± 0.74%)}	_~	_2.76s	_2.81s	_{p=0.935 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.37s (± 0.42%)}	_{8.37s (± 0.46%)}	_~	_8.32s	_8.40s	_{p=1.000 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{366,124k (± 0.01%)}	_{366,124k (± 0.00%)}	_~	_366,109k	_366,151k	_{p=1.000 n=6}
_{Parse Time}	_{3.58s (± 0.23%)}	_{3.59s (± 1.05%)}	_~	_3.55s	_3.66s	_{p=0.607 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.44%)}	_~	_1.17s	_1.18s	_{p=0.069 n=6}
_{Check Time}	_{9.65s (± 0.57%)}	_{9.77s (± 2.09%)}	_~	_9.59s	_10.16s	_{p=0.293 n=6}
_{Emit Time}	_{8.01s (± 0.83%)}	_{8.04s (± 0.68%)}	_~	_7.97s	_8.11s	_{p=0.295 n=6}
_{Total Time}	_{22.42s (± 0.55%)}	_{22.57s (± 1.29%)}	_~	_22.29s	_23.12s	_{p=0.336 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,825k (± 0.02%)}	_{192,771k (± 0.05%)}	_~	_192,655k	_192,872k	_{p=0.470 n=6}
_{Parse Time}	_{1.60s (± 1.07%)}	_{1.59s (± 1.24%)}	_~	_1.58s	_1.63s	_{p=0.454 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.82s (± 0.92%)}	_~	_0.81s	_0.83s	_{p=0.069 n=6}
_{Check Time}	_{10.17s (± 0.56%)}	_{10.08s (± 0.57%)}	_{-0.09s (- 0.84%)}	_10.01s	_10.18s	_{p=0.044 n=6}
_{Emit Time}	_{3.04s (± 1.18%)}	_{3.03s (± 1.10%)}	_~	_2.98s	_3.08s	_{p=0.333 n=6}
_{Total Time}	_{15.63s (± 0.54%)}	_{15.52s (± 0.28%)}	_{-0.11s (- 0.72%)}	_15.47s	_15.59s	_{p=0.010 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{346,064k (± 0.01%)}	_{346,064k (± 0.00%)}	_~	_346,049k	_346,085k	_{p=0.574 n=6}
_{Parse Time}	_{2.74s (± 0.45%)}	_{2.73s (± 0.73%)}	_~	_2.70s	_2.75s	_{p=0.157 n=6}
_{Bind Time}	_{1.09s (± 0.00%)}	_{1.08s (± 0.50%)}	_~	_1.08s	_1.09s	_{p=0.071 n=6}
_{Check Time}	_{7.89s (± 0.38%)}	_{7.88s (± 0.29%)}	_~	_7.85s	_7.90s	_{p=0.220 n=6}
_{Emit Time}	_{4.48s (± 0.61%)}	_{4.48s (± 0.75%)}	_~	_4.45s	_4.53s	_{p=0.935 n=6}
_{Total Time}	_{16.21s (± 0.27%)}	_{16.17s (± 0.32%)}	_~	_16.10s	_16.25s	_{p=0.335 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,215k (± 0.01%)}	_{300,216k (± 0.01%)}	_~	_300,192k	_300,234k	_{p=0.936 n=6}
_{Parse Time}	_{2.19s (± 0.75%)}	_{2.17s (± 0.68%)}	_{-0.03s (- 1.21%)}	_2.15s	_2.19s	_{p=0.028 n=6}
_{Bind Time}	_{1.24s (± 0.83%)}	_{1.24s (± 0.88%)}	_~	_1.23s	_1.25s	_{p=0.676 n=6}
_{Check Time}	_{7.35s (± 0.61%)}	_{7.34s (± 0.28%)}	_~	_7.30s	_7.35s	_{p=0.744 n=6}
_{Emit Time}	_{4.35s (± 0.51%)}	_{4.35s (± 0.53%)}	_~	_4.32s	_4.38s	_{p=1.000 n=6}
_{Total Time}	_{15.14s (± 0.59%)}	_{15.10s (± 0.28%)}	_~	_15.03s	_15.15s	_{p=0.521 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,706k (± 0.01%)}	_{481,710k (± 0.01%)}	_~	_481,663k	_481,792k	_{p=0.810 n=6}
_{Parse Time}	_{3.27s (± 0.27%)}	_{3.26s (± 0.55%)}	_~	_3.24s	_3.29s	_{p=0.222 n=6}
_{Bind Time}	_{0.96s (± 0.54%)}	_{0.95s (± 0.67%)}	_~	_0.94s	_0.96s	_{p=0.091 n=6}
_{Check Time}	_{18.34s (± 0.65%)}	_{18.31s (± 0.61%)}	_~	_18.17s	_18.51s	_{p=0.873 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.56s (± 0.56%)}	_{22.53s (± 0.49%)}	_~	_22.39s	_22.72s	_{p=0.748 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,181k (± 0.02%)}	_{561,237k (± 0.04%)}	_~	_561,059k	_561,540k	_{p=0.748 n=6}
_{Parse Time}	_{4.03s (± 0.44%)}	_{4.00s (± 0.31%)}	_{-0.03s (- 0.62%)}	_3.99s	_4.02s	_{p=0.035 n=6}
_{Bind Time}	_{1.75s (± 0.60%)}	_{1.73s (± 0.57%)}	_{-0.02s (- 0.96%)}	_1.72s	_1.74s	_{p=0.032 n=6}
_{Check Time}	_{3.06s (± 0.48%)}	_{3.06s (± 0.53%)}	_~	_3.03s	_3.08s	_{p=1.000 n=6}
_{Emit Time}	_{0.09s (± 4.45%)}	_{0.09s (± 5.53%)}	_~	_0.09s	_0.10s	_{p=0.595 n=6}
_{Total Time}	_{8.93s (± 0.15%)}	_{8.88s (± 0.29%)}	_{-0.05s (- 0.52%)}	_8.84s	_8.92s	_{p=0.012 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{360,100k (± 0.01%)}	_{360,114k (± 0.01%)}	_~	_360,066k	_360,174k	_{p=0.689 n=6}
_{Parse Time}	_{3.68s (± 0.53%)}	_{3.66s (± 0.56%)}	_~	_3.64s	_3.70s	_{p=0.104 n=6}
_{Bind Time}	_{1.23s (± 0.98%)}	_{1.21s (± 0.43%)}	_{-0.02s (- 1.62%)}	_1.21s	_1.22s	_{p=0.010 n=6}
_{Check Time}	_{10.11s (± 0.38%)}	_{10.08s (± 0.60%)}	_~	_10.01s	_10.17s	_{p=0.466 n=6}
_{Emit Time}	_{8.42s (± 0.68%)}	_{8.40s (± 0.88%)}	_~	_8.33s	_8.54s	_{p=0.374 n=6}
_{Total Time}	_{23.43s (± 0.33%)}	_{23.36s (± 0.42%)}	_~	_23.27s	_23.50s	_{p=0.127 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{188,155k (± 0.01%)}	_{188,145k (± 0.01%)}	_~	_188,128k	_188,166k	_{p=0.336 n=6}
_{Parse Time}	_{1.63s (± 0.50%)}	_{1.63s (± 0.75%)}	_~	_1.61s	_1.64s	_{p=0.730 n=6}
_{Bind Time}	_{0.85s (± 0.00%)}	_{0.85s (± 0.96%)}	_~	_0.84s	_0.86s	_{p=0.290 n=6}
_{Check Time}	_{10.34s (± 0.45%)}	_{10.25s (± 0.69%)}	_~	_10.17s	_10.36s	_{p=0.066 n=6}
_{Emit Time}	_{3.14s (± 0.81%)}	_{3.14s (± 0.55%)}	_~	_3.11s	_3.16s	_{p=0.806 n=6}
_{Total Time}	_{15.95s (± 0.33%)}	_{15.87s (± 0.51%)}	_~	_15.77s	_15.97s	_{p=0.076 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{341,191k (± 0.01%)}	_{341,201k (± 0.01%)}	_~	_341,173k	_341,238k	_{p=0.471 n=6}
_{Parse Time}	_{2.83s (± 0.55%)}	_{2.81s (± 0.69%)}	_~	_2.79s	_2.84s	_{p=0.085 n=6}
_{Bind Time}	_{1.11s (± 0.73%)}	_{1.11s (± 0.68%)}	_~	_1.10s	_1.12s	_{p=1.000 n=6}
_{Check Time}	_{8.25s (± 0.37%)}	_{8.21s (± 0.37%)}	_~	_8.16s	_8.25s	_{p=0.053 n=6}
_{Emit Time}	_{4.71s (± 0.78%)}	_{4.66s (± 0.36%)}	_{-0.05s (- 1.03%)}	_4.63s	_4.67s	_{p=0.034 n=6}
_{Total Time}	_{16.90s (± 0.34%)}	_{16.79s (± 0.27%)}	_{-0.11s (- 0.68%)}	_16.73s	_16.84s	_{p=0.010 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,306k (± 0.00%)}	_{295,303k (± 0.00%)}	_~	_295,290k	_295,314k	_{p=0.419 n=6}
_{Parse Time}	_{2.41s (± 0.93%)}	_{2.40s (± 0.90%)}	_~	_2.38s	_2.44s	_{p=0.870 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.06s (± 0.77%)}	_~	_1.06s	_1.08s	_{p=0.235 n=6}
_{Check Time}	_{7.65s (± 0.36%)}	_{7.65s (± 0.32%)}	_~	_7.62s	_7.68s	_{p=0.936 n=6}
_{Emit Time}	_{4.31s (± 0.78%)}	_{4.29s (± 0.63%)}	_~	_4.25s	_4.33s	_{p=0.373 n=6}
_{Total Time}	_{15.43s (± 0.46%)}	_{15.41s (± 0.30%)}	_~	_15.35s	_15.48s	_{p=0.422 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{477,166k (± 0.00%)}	_{477,170k (± 0.00%)}	_~	_477,145k	_477,197k	_{p=0.810 n=6}
_{Parse Time}	_{3.36s (± 0.42%)}	_{3.34s (± 0.42%)}	_~	_3.32s	_3.36s	_{p=0.051 n=6}
_{Bind Time}	_{1.01s (± 0.00%)}	_{1.00s (± 0.41%)}	_{-0.01s (- 0.83%)}	_1.00s	_1.01s	_{p=0.007 n=6}
_{Check Time}	_{19.40s (± 0.72%)}	_{19.20s (± 0.27%)}	_{-0.20s (- 1.03%)}	_19.15s	_19.30s	_{p=0.013 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.77s (± 0.60%)}	_{23.54s (± 0.22%)}	_{-0.23s (- 0.97%)}	_23.50s	_23.64s	_{p=0.013 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{550,174k (± 0.01%)}	_{550,177k (± 0.00%)}	_~	_550,147k	_550,193k	_{p=0.423 n=6}
_{Parse Time}	_{4.25s (± 0.18%)}	_{4.24s (± 0.21%)}	_~	_4.23s	_4.25s	_{p=0.149 n=6}
_{Bind Time}	_{1.68s (± 1.15%)}	_{1.66s (± 0.93%)}	_~	_1.64s	_1.68s	_{p=0.073 n=6}
_{Check Time}	_{3.14s (± 0.66%)}	_{3.13s (± 0.75%)}	_~	_3.10s	_3.16s	_{p=0.936 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.15s (± 0.32%)}	_{9.13s (± 0.26%)}	_~	_9.09s	_9.15s	_{p=0.332 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₇₇₇	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..54777

_Metric	_main	₅₄₇₇₇	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,575ms (± 0.93%)}	_{2,562ms (± 0.83%)}	_~	_2,540ms	_2,595ms	_{p=0.298 n=6}
_{Req 2 - geterr}	_{5,373ms (± 0.79%)}	_{5,344ms (± 0.61%)}	_~	_5,301ms	_5,400ms	_{p=0.230 n=6}
_{Req 3 - references}	_{342ms (± 1.15%)}	_{340ms (± 0.47%)}	_~	_339ms	_343ms	_{p=0.744 n=6}
_{Req 4 - navto}	_{288ms (± 0.42%)}	_{287ms (± 0.36%)}	_~	_286ms	_289ms	_{p=0.675 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 3.73%)}	_{83ms (± 2.70%)}	_~	_79ms	_85ms	_{p=0.680 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,655ms (± 1.15%)}	_{2,651ms (± 0.96%)}	_~	_2,611ms	_2,685ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{4,136ms (± 1.98%)}	_{4,091ms (± 0.28%)}	_~	_4,078ms	_4,105ms	_{p=0.199 n=6}
_{Req 3 - references}	_{349ms (± 0.97%)}	_{346ms (± 0.57%)}	_~	_344ms	_349ms	_{p=0.222 n=6}
_{Req 4 - navto}	_{287ms (± 0.41%)}	_{288ms (± 0.66%)}	_~	_286ms	_290ms	_{p=0.314 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{71ms (± 1.26%)}	_{76ms (± 9.08%)}	_~	_71ms	_89ms	_{p=0.084 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,112ms (± 0.40%)}	_{3,096ms (± 0.42%)}	_~	_3,082ms	_3,117ms	_{p=0.092 n=6}
_{Req 2 - geterr}	_{1,604ms (± 0.64%)}	_{1,587ms (± 0.56%)}	_{-17ms (- 1.03%)}	_1,573ms	_1,599ms	_{p=0.020 n=6}
_{Req 3 - references}	_{112ms (± 0.92%)}	_{113ms (± 1.09%)}	_~	_111ms	_114ms	_{p=0.804 n=6}
_{Req 4 - navto}	_{370ms (± 0.44%)}	_{370ms (± 1.34%)}	_~	_366ms	_379ms	_{p=0.332 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{378ms (± 1.50%)}	_{375ms (± 1.44%)}	_~	_368ms	_383ms	_{p=0.419 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,669ms (± 1.42%)}	_{2,639ms (± 0.77%)}	_~	_2,616ms	_2,667ms	_{p=0.199 n=6}
_{Req 2 - geterr}	_{5,988ms (± 1.75%)}	_{6,000ms (± 0.35%)}	_~	_5,964ms	_6,023ms	_{p=0.296 n=6}
_{Req 3 - references}	_{354ms (± 0.43%)}	_{353ms (± 0.69%)}	_~	_349ms	_356ms	_{p=0.413 n=6}
_{Req 4 - navto}	_{285ms (± 0.69%)}	_{285ms (± 0.31%)}	_~	_284ms	_286ms	_{p=0.934 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{89ms (± 8.89%)}	_{89ms (± 8.92%)}	_~	_73ms	_94ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,853ms (± 0.69%)}	_{2,835ms (± 0.67%)}	_~	_2,819ms	_2,861ms	_{p=0.297 n=6}
_{Req 2 - geterr}	_{4,680ms (± 0.37%)}	_{4,675ms (± 0.41%)}	_~	_4,648ms	_4,697ms	_{p=0.872 n=6}
_{Req 3 - references}	_{365ms (± 0.48%)}	_{364ms (± 0.80%)}	_~	_359ms	_367ms	_{p=0.466 n=6}
_{Req 4 - navto}	_{285ms (± 0.52%)}	_{283ms (± 0.91%)}	_~	_279ms	_286ms	_{p=0.184 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{75ms (± 1.19%)}	_{75ms (± 0.54%)}	_~	_75ms	_76ms	_{p=0.787 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,266ms (± 0.73%)}	_{3,235ms (± 0.50%)}	_~	_3,221ms	_3,265ms	_{p=0.054 n=6}
_{Req 2 - geterr}	_{1,751ms (± 1.13%)}	_{1,755ms (± 0.92%)}	_~	_1,734ms	_1,777ms	_{p=0.471 n=6}
_{Req 3 - references}	_{127ms (± 6.77%)}	_{122ms (± 1.70%)}	_~	_119ms	_124ms	_{p=0.180 n=6}
_{Req 4 - navto}	_{357ms (± 0.72%)}	_{352ms (± 0.82%)}	_{-5ms (- 1.49%)}	_348ms	_355ms	_{p=0.019 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{410ms (± 1.80%)}	_{416ms (± 2.05%)}	_~	_404ms	_425ms	_{p=0.336 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,822ms (± 0.59%)}	_{2,788ms (± 0.55%)}	_{-34ms (- 1.20%)}	_2,773ms	_2,816ms	_{p=0.013 n=6}
_{Req 2 - geterr}	_{6,211ms (± 0.45%)}	_{6,189ms (± 0.67%)}	_~	_6,139ms	_6,234ms	_{p=0.521 n=6}
_{Req 3 - references}	_{361ms (± 0.67%)}	_{362ms (± 0.42%)}	_~	_360ms	_364ms	_{p=0.622 n=6}
_{Req 4 - navto}	_{292ms (± 0.40%)}	_{292ms (± 0.45%)}	_~	_290ms	_293ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{102ms (± 6.17%)}	_{104ms (± 1.12%)}	_~	_102ms	_105ms	_{p=0.452 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,990ms (± 0.45%)}	_{2,975ms (± 0.29%)}	_~	_2,964ms	_2,989ms	_{p=0.066 n=6}
_{Req 2 - geterr}	_{4,556ms (± 0.61%)}	_{4,549ms (± 0.68%)}	_~	_4,512ms	_4,577ms	_{p=1.000 n=6}
_{Req 3 - references}	_{377ms (± 0.52%)}	_{377ms (± 0.60%)}	_~	_373ms	_379ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{300ms (± 0.49%)}	_{299ms (± 0.47%)}	_~	_297ms	_301ms	_{p=0.222 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{77ms (± 0.53%)}	_{76ms (± 1.53%)}	_~	_75ms	_78ms	_{p=0.227 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,491ms (± 0.72%)}	_{3,477ms (± 0.43%)}	_~	_3,455ms	_3,493ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{1,856ms (± 1.09%)}	_{1,858ms (± 0.41%)}	_~	_1,848ms	_1,869ms	_{p=0.810 n=6}
_{Req 3 - references}	_{152ms (± 6.75%)}	_{151ms (± 7.75%)}	_~	_135ms	_161ms	_{p=0.872 n=6}
_{Req 4 - navto}	_{397ms (± 0.37%)}	_{397ms (± 0.34%)}	_~	_395ms	_399ms	_{p=0.934 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{432ms (± 2.81%)}	_{435ms (± 1.42%)}	_~	_427ms	_442ms	_{p=0.573 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₇₇₇	₆
_Baseline	_main	₆

Startup

Comparison Report - main..54777

_Metric	_main	₅₄₇₇₇	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{143.72ms (± 0.39%)}	_{142.83ms (± 0.22%)}	_{-0.89ms (- 0.62%)}	_141.94ms	_146.22ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{225.73ms (± 0.51%)}	_{222.83ms (± 0.21%)}	_{-2.90ms (- 1.28%)}	_221.45ms	_227.75ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{226.13ms (± 0.40%)}	_{225.91ms (± 0.38%)}	_{-0.21ms (- 0.09%)}	_223.08ms	_231.09ms	_{p=0.043 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{207.95ms (± 0.41%)}	_{207.98ms (± 0.39%)}	_~	_204.95ms	_215.84ms	_{p=0.623 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₇₇₇	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-06-28T19:43:10Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/54777/merge:

Everything looks good!

typescript-bot · 2023-06-28T19:57:25Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-06-28T20:37:26Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/54777/merge:

Everything looks good!

jakebailey · 2023-07-18T23:50:48Z

Generally speaking I think I probably need to have @RyanCavanaugh / @DanielRosenwasser give the resulting setup a once over to make sure it lines up with their mental models; I think it matches Ryan's comment in the linked issue, but I'm also a little unsure that I like the end result either.

jakebailey · 2023-08-15T18:38:37Z

Just going to do a quick close/open since this is 151 commits behind main.

karlhorky · 2023-08-16T13:48:38Z

Thanks for the PR, review and merge @Andarist @DanielRosenwasser @jakebailey 🙌

…t#54777)

Display write type for property accesses in write locations

7a755d2

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jun 26, 2023

sandersn requested review from jakebailey and navya9singh July 18, 2023 23:45

sandersn assigned jakebailey Jul 18, 2023

jakebailey requested review from DanielRosenwasser and RyanCavanaugh August 15, 2023 17:32

DanielRosenwasser requested a review from gabritto August 15, 2023 18:03

DanielRosenwasser approved these changes Aug 15, 2023

View reviewed changes

jakebailey closed this Aug 15, 2023

jakebailey reopened this Aug 15, 2023

jakebailey merged commit b8b0d26 into microsoft:main Aug 15, 2023

jakebailey mentioned this pull request Aug 28, 2023

[NewErrors] 5.3.0-dev.20230827 vs 5.2.2 #55532

Closed

This was referenced Aug 29, 2023

[next/nightly] Incorrect _'obj.prop' is possibly 'undefined'._ Error in CFA with exactOptionalPropertyTypes and Optional-never Properties #55566

Closed

Discriminate types with divergent read/write property types #55576

Merged

Andarist deleted the use-write-type-in-write-locations branch August 30, 2023 17:49

Andarist mentioned this pull request Aug 31, 2023

Fixed element access expression writes for divergent write types #55585

Merged

snovader pushed a commit to EG-A-S/TypeScript that referenced this pull request Sep 23, 2023

Display write type for property accesses in write locations (microsof…

78a1235

…t#54777)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display write type for property accesses in write locations #54777

Display write type for property accesses in write locations #54777

Andarist commented Jun 26, 2023

jakebailey commented Jun 28, 2023

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023

typescript-bot commented Jun 28, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Jun 28, 2023

Compiler

TSServer

Startup

typescript-bot commented Jun 28, 2023

typescript-bot commented Jun 28, 2023

typescript-bot commented Jun 28, 2023

jakebailey commented Jul 18, 2023

jakebailey commented Aug 15, 2023

karlhorky commented Aug 16, 2023

Display write type for property accesses in write locations #54777

Display write type for property accesses in write locations #54777

Conversation

Andarist commented Jun 26, 2023

jakebailey commented Jun 28, 2023

typescript-bot commented Jun 28, 2023 • edited Loading

typescript-bot commented Jun 28, 2023 • edited Loading

typescript-bot commented Jun 28, 2023 • edited Loading

typescript-bot commented Jun 28, 2023 • edited Loading

typescript-bot commented Jun 28, 2023 • edited Loading

typescript-bot commented Jun 28, 2023 • edited Loading

typescript-bot commented Jun 28, 2023 • edited Loading

typescript-bot commented Jun 28, 2023 • edited Loading

typescript-bot commented Jun 28, 2023 • edited Loading

typescript-bot commented Jun 28, 2023

typescript-bot commented Jun 28, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Jun 28, 2023

Compiler

TSServer

Startup

typescript-bot commented Jun 28, 2023

typescript-bot commented Jun 28, 2023

typescript-bot commented Jun 28, 2023

jakebailey commented Jul 18, 2023

jakebailey commented Aug 15, 2023

karlhorky commented Aug 16, 2023

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading

typescript-bot commented Jun 28, 2023 •

edited

Loading